From 8e310fd264143d8a9075646d1e9fd9a4821fd6d7 Mon Sep 17 00:00:00 2001 From: Tzafrir Cohen Date: Sun, 2 Apr 2017 15:03:26 +0300 Subject: [PATCH] xpp: output of parse_hexbyte() may be negative Signed-off-by: Tzafrir Cohen --- drivers/dahdi/xpp/card_global.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/dahdi/xpp/card_global.c b/drivers/dahdi/xpp/card_global.c index 809ee76..da1393e 100644 --- a/drivers/dahdi/xpp/card_global.c +++ b/drivers/dahdi/xpp/card_global.c @@ -223,11 +223,12 @@ static int execute_chip_command(xpd_t *xpd, const int argc, char *argv[]) goto out; } for (i = 0; i < num_args - 2; i++, argno++) { - input[i] = parse_hexbyte(argv[argno]); - if (input[i] < 0) { + int hexbyte= parse_hexbyte(argv[argno]); + if (hexbyte < 0) { XPD_ERR(xpd, "Illegal input[%d] number '%s'\n", i, argv[argno]); goto out; } + input[i] = hexbyte; } ret = xpp_ram_request(xpd->xbus, xpd, portno, writing, input[0],