FGFS-4.1/OpenSceneGraph
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed 6 Coverity reported issues.

Browse Source 
CID 11820: Uninitialized scalar field (UNINIT_CTOR)
Non-static class member _azAngle is not initialized in this constructor nor in any functions that it calls.
Non-static class member _elevAngle is not initialized in this constructor nor in any functions that it calls.

CID 11819: Uninitialized scalar field (UNINIT_CTOR)
Non-static class member _BoundaryAngle is not initialized in this constructor nor in any functions that it calls.
Non-static class member _planeOrientation is not initialized in this constructor nor in any functions that it calls.

CID 11818: Uninitialized scalar field (UNINIT_CTOR)
Non-static class member _BoundaryAngle is not initialized in this constructor nor in any functions that it calls.
Non-static class member _planeOrientation is not initialized in this constructor nor in any functions that it calls.

CID 11817: Uninitialized scalar field (UNINIT_CTOR)
Non-static class member _distance is not initialized in this constructor nor in any functions that it calls.

CID 11817: Uninitialized scalar field (UNINIT_CTOR)
Non-static class member _distance is not initialized in this constructor nor in any functions that it calls.

CID 11816: Uninitialized scalar field (UNINIT_CTOR)
Non-static class member _leftRightSurfaces is not initialized in this constructor nor in any functions that it calls.
This commit is contained in:
Robert Osfield
2011-05-09 10:52:34 +00:00
parent 7b4d44b2f5
commit 5b0ab95e41
1 changed files with 29 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
src/osgSim/SphereSegment.cpp
View File

@@ -145,24 +145,28 @@ public:
Side(SphereSegment* ss, SphereSegment::SideOrientation po, SphereSegment::BoundaryAngle pa):
osg::Drawable(), _ss(ss), _planeOrientation(po), _BoundaryAngle(pa) {}
Side():_ss(0)
{
OSG_WARN<<
"Warning: unexpected call to osgSim::SphereSegment::Side() default constructor"<<std::endl;
}
Side(const Side& rhs, const osg::CopyOp& co=osg:: CopyOp::SHALLOW_COPY): osg::Drawable(rhs,co), _ss(0)
{
OSG_WARN<<
"Warning: unexpected call to osgSim::SphereSegment::Side() copy constructor"<<std::endl;
}
META_Object(osgSim,Side)
void drawImplementation(osg::RenderInfo& renderInfo) const;
protected:
Side():_ss(0), _planeOrientation(SphereSegment::AZIM), _BoundaryAngle(SphereSegment::MIN)
{
OSG_WARN<<
"Warning: unexpected call to osgSim::SphereSegment::Side() default constructor"<<std::endl;
}
Side(const Side& rhs, const osg::CopyOp& co=osg:: CopyOp::SHALLOW_COPY):
osg::Drawable(rhs,co),
_ss(0),
_planeOrientation(rhs._planeOrientation),
_BoundaryAngle(rhs._BoundaryAngle)
{
OSG_WARN<<
"Warning: unexpected call to osgSim::SphereSegment::Side() copy constructor"<<std::endl;
}
virtual osg::BoundingBox computeBound() const;
private:
@@ -195,6 +199,12 @@ public:
Spoke(SphereSegment* ss, SphereSegment::BoundaryAngle azAngle, SphereSegment::BoundaryAngle elevAngle):
osg::Drawable(), _ss(ss), _azAngle(azAngle), _elevAngle(elevAngle) { init(); }
META_Object(osgSim,Spoke)
void drawImplementation(osg::RenderInfo& renderInfo) const;
protected:
Spoke():_ss(0)
{
init();
@@ -202,17 +212,15 @@ public:
"Warning: unexpected call to osgSim::SphereSegment::Spoke() default constructor"<<std::endl;
}
Spoke(const Spoke& rhs, const osg::CopyOp& co=osg:: CopyOp::SHALLOW_COPY): osg::Drawable(rhs,co), _ss(0)
Spoke(const Spoke& rhs, const osg::CopyOp& co=osg:: CopyOp::SHALLOW_COPY):
osg::Drawable(rhs,co),
_ss(0),
_azAngle(rhs._azAngle), _elevAngle(rhs._elevAngle)
{
OSG_WARN<<
"Warning: unexpected call to osgSim::SphereSegment::Spoke() copy constructor"<<std::endl;
}
META_Object(osgSim,Spoke)
void drawImplementation(osg::RenderInfo& renderInfo) const;
protected:
void init()
{
@@ -1353,6 +1361,7 @@ namespace SphereSegmentIntersector
Region():
_radiusSurface(OUTSIDE),
_leftRightSurfaces(OUTSIDE),
_leftSurface(OUTSIDE),
_rightSurface(OUTSIDE),
_bottomSurface(OUTSIDE),
@@ -2196,7 +2205,8 @@ namespace SphereSegmentIntersector
_line(line),
_lineEnd(0),
_neighbourLine(0),
_neighbourLineEnd(0) {}
_neighbourLineEnd(0),
_distance(FLT_MAX) {}
bool operator < (const LinePair& linePair) const
{