From 634f597feb3339b22ff737395f239e678655597b Mon Sep 17 00:00:00 2001 From: Robert Osfield Date: Tue, 18 Dec 2012 09:49:01 +0000 Subject: [PATCH] =?UTF-8?q?From=20Juergen=20Rensen,=20"This=20is=20a=20fix?= =?UTF-8?q?=20for=20the=20latest=20SVN=20version=20(rev=2013269).=20The=20?= =?UTF-8?q?=E2=80=98destroyFrameBuffer=E2=80=99=20method=20in=20=E2=80=98G?= =?UTF-8?q?raphicsWindowIOS.mm=E2=80=99=20had=20=E2=80=98glDeleteFramebuff?= =?UTF-8?q?ersOES=E2=80=99=20calls=20for=20the=20stencil=20buffer,=20MSAA?= =?UTF-8?q?=20render=20buffer=20and=20MSAA=20depth=20buffer=20instead=20of?= =?UTF-8?q?=20=E2=80=98glDeleteRenderbuffersOES=E2=80=99.=20The=20fix=20ch?= =?UTF-8?q?anges=20the=20mismatched=20calls=20to=20=E2=80=98glDeleteRender?= =?UTF-8?q?buffersOES=E2=80=99.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The impact of the bug was a memory leak that would affect multi-sampling iOS apps that allow for device rotation or window resizing in general. For our app, the leak ranged from ca. 10 MB to 40 MB per device rotation, depending on device, for the MSAA buffers. I have not been able to confirm impact for the stencil buffer. " --- src/osgViewer/GraphicsWindowIOS.mm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/osgViewer/GraphicsWindowIOS.mm b/src/osgViewer/GraphicsWindowIOS.mm index dd9fc4b93..51a753625 100644 --- a/src/osgViewer/GraphicsWindowIOS.mm +++ b/src/osgViewer/GraphicsWindowIOS.mm @@ -469,17 +469,17 @@ typedef std::map TouchPointsIdMapping; } if(_stencilBuffer) { - glDeleteFramebuffersOES(1, &_stencilBuffer); + glDeleteRenderbuffersOES(1, &_stencilBuffer); _stencilBuffer = 0; } if(_msaaRenderBuffer) { - glDeleteFramebuffersOES(1, &_msaaRenderBuffer); + glDeleteRenderbuffersOES(1, &_msaaRenderBuffer); _msaaRenderBuffer = 0; } if(_msaaDepthBuffer) { - glDeleteFramebuffersOES(1, &_msaaDepthBuffer); + glDeleteRenderbuffersOES(1, &_msaaDepthBuffer); _msaaDepthBuffer = 0; }