Warning fixes

src/OpenThreads/win32/Win32Thread.cpp

@@ -136,8 +136,8 @@ namespace OpenThreads {
         // Print information related to thread schduling parameters.
         //
         static void PrintThreadSchedulingInfo(Thread *thread) {
-            Win32ThreadPrivateData *pd =
-                static_cast<Win32ThreadPrivateData *>(thread->_prvData);
+
+            // Win32ThreadPrivateData *pd = static_cast<Win32ThreadPrivateData *>(thread->_prvData);
 
             std::cout<<"Thread "<< thread <<" priority : ";
 

src/osgPlugins/3ds/ReaderWriter3DS.cpp

@@ -78,7 +78,9 @@ class PrintVisitor : public NodeVisitor
         virtual void apply(LOD& node)           { apply((Group&)node); }
 
    protected:
-    
+
+        PrintVisitor& operator = (const PrintVisitor&) { return *this; }
+
         std::ostream& _out;
         int _indent;
         int _step;

src/osgPlugins/cfg/ConfigLexer.cpp

@@ -9,6 +9,10 @@
 #define YY_FLEX_MAJOR_VERSION 2
 #define YY_FLEX_MINOR_VERSION 5
 
+#if defined(_MSC_VER) && defined(OSG_DISABLE_MSVC_WARNINGS)
+    // disable '=' : conversion from 'int' to 'char', possible loss of data style warnings
+    #pragma warning( disable : 4244)
+#endif
 
 
 /* cfront 1.2 defines "c_plusplus" instead of "__cplusplus" */

src/osgPlugins/jpeg/ReaderWriterJPEG.cpp

@@ -56,6 +56,10 @@ extern "C"
 #include <assert.h>
 #include <stdlib.h>
 
+#if defined(_MSC_VER) && defined(OSG_DISABLE_MSVC_WARNINGS)
+    #pragma warning( disable : 4611 )
+#endif
+
 namespace osgDBJPEG
 {
 

src/osgPlugins/lwo/lwo2types.h

@@ -17,8 +17,17 @@ namespace lwo2
 
 // basic types
 
-struct ID4 {
-	char id[4];
+struct ID4
+{
+    ID4()
+    {
+        id[0] = 0;
+        id[1] = 0;
+        id[2] = 0;
+        id[3] = 0;
+    }
+    
+    char id[4];
 };
 
 typedef signed char			I1;

src/osgPlugins/obj/OBJWriterNodeVisitor.cpp

@@ -70,6 +70,9 @@ class ValueVisitor : public osg::ValueVisitor {
             _fout << v[0] << ' ' << v[1] << ' ' << v[2]; 
         }
     private:
+
+        ValueVisitor& operator = (const ValueVisitor&) { return *this; }
+
         std::ostream&    _fout;
         osg::Matrix        _m;
         bool            _applyMatrix, _isNormal;
@@ -302,6 +305,9 @@ class PrimitiveIndexWriter : public osg::PrimitiveIndexFunctor {
         }    
     
     private:
+
+        PrimitiveIndexWriter& operator = (const PrimitiveIndexWriter&) { return *this; }
+
         std::ostream&         _fout;
         GLenum               _modeCache;
         std::vector<GLuint>  _indexCache;
@@ -309,8 +315,6 @@ class PrimitiveIndexWriter : public osg::PrimitiveIndexFunctor {
         bool                 _hasNormalCoords, _hasTexCoords;
         osg::Geometry*         _geo;
         unsigned int         _normalIndex;
-
-
 };
 
 

src/osgPlugins/txp/ReaderWriterTXP.cpp

@@ -652,6 +652,8 @@ public:
 
 protected:
     osg::Node* seamReplacement(osg::Node* node);
+    
+    SeamFinder& operator = (const SeamFinder&) { return *this; }
 
     int _x, _y, _lod;
     const TXPArchive::TileInfo& _info;

src/osgPlugins/txp/TXPIO.cpp

@@ -62,6 +62,10 @@ public:
         NodeVisitor::apply(node);
     }
     osgDB::Output &_fw;
+    
+protected:
+
+    Dump2Osg& operator = (const Dump2Osg&) { return *this; }
 };
 
 

src/osgPlugins/txp/TXPParser.cpp

@@ -293,6 +293,9 @@ public:
         traverse(group);
     }
 protected:
+
+    FindEmptyGroupsVisitor& operator = (const FindEmptyGroupsVisitor&) { return *this; }
+
     osg::NodeList& _nl;
 };
 

src/osgPlugins/txp/trpage_material.cpp

@@ -1074,21 +1074,15 @@ bool trpgTexture::isValid() const
     switch (mode) {
     case External:
 	return (name != NULL);
-	break;
     case Local:
 	return (type != trpg_Unknown && sizeX != -1 && sizeY != -1);
-	break;
     case Global:
 	return (type != trpg_Unknown);
-	break;
     case Template:
 	return (type != trpg_Unknown && sizeX != -1 && sizeY != -1);
-	break;
     default:
 	return false;
     }
-
-    return false;
 }
 
 

src/osgUtil/Simplifier.cpp

@@ -1650,7 +1650,7 @@ class CopyPointsToVertexArrayVisitor : public osg::ArrayVisitor
         
     protected:
     
-        CopyPointsToVertexArrayVisitor& operator = (CopyPointsToArrayVisitor&) { return *this; }
+        CopyPointsToVertexArrayVisitor& operator = (const CopyPointsToArrayVisitor&) { return *this; }
 };
 
 

src/osgUtil/TriStrip_tri_stripper.h

@@ -82,7 +82,28 @@ class triangle
 {
 public:
     triangle();
+    
+    triangle(const triangle& tri):
+        m_A(tri.m_A),
+        m_B(tri.m_B),
+        m_C(tri.m_C),
+        m_StripID(tri.m_StripID)
+    {
+    }
+    
     triangle(const indice A, const indice B, const indice C);
+    
+    triangle& operator = (const triangle& tri)
+    {
+        if (&tri==this) return *this;
+        
+        m_A = tri.m_A;
+        m_B = tri.m_B;
+        m_C = tri.m_C;
+        m_StripID = tri.m_StripID;
+        
+        return *this;
+    }
 
     void SetStripID(const size_t StripID);