From b0b28d21d92308c91e05ad2d4bce8d7cbdea64e5 Mon Sep 17 00:00:00 2001
From: Laurens Voerman <l.voerman@rug.nl>
Date: Fri, 19 Jan 2018 11:38:01 +0100
Subject: [PATCH] fix bug: potentially uninitialized local variable 'hr' used

---
 examples/osgdirectinput/DirectInputRegistry.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/examples/osgdirectinput/DirectInputRegistry.cpp b/examples/osgdirectinput/DirectInputRegistry.cpp
index aa8de2df3..6bdd98ac8 100644
--- a/examples/osgdirectinput/DirectInputRegistry.cpp
+++ b/examples/osgdirectinput/DirectInputRegistry.cpp
@@ -204,7 +204,7 @@ BOOL CALLBACK DirectInputRegistry::EnumJoysticksCallback( const DIDEVICEINSTANCE
     {
         hr = device->CreateDevice( didInstance->guidInstance,
                                    &(DirectInputRegistry::instance()->getJoyStick()), NULL );
+        if ( SUCCEEDED(hr) ) return DIENUM_STOP;
     }
-    if ( FAILED(hr) ) return DIENUM_CONTINUE;
-    return DIENUM_STOP;
+    return DIENUM_CONTINUE;
 }