From David Callu,
"
Found in the join file the fix for the bug found by Rafa.
Problem :
osgIntrospection::Value grp(new osg::Group);
osgIntrospection::ValueList vlcall;
vlcall.push_back(osgIntrospection::Value("toto"));
const osgIntrospection::MethodInfo *m =
grp->getType.getCompatibleMethod("setName", vlcall, true);
if (m)
{
m->invoke(grp, vlcall); // ** SEGFAULT here
}
Algorithm explanation :
The "invoke" method try to convert "grp", which reflect an
"osg::Group*", in a
"osgIntrospection::Value", which reflect a "osg::Node*".
This because
the "setName(const char *)" method found by
"grp->getType.getCompatibleMethod"
is an "osg::Object" type method.
When osgIntrospection do this conversion it try :
- to found a "osgIntrospection::Converter" to convert
from "osg::Group*" to "osg::Node*"
- to found a chain of "osgIntrospection::Converter" to convert
from "osg::Group*" to "one or many type" to "osg::Node*"
- to converte an Enum to int or unsigned int
- to convert the value in its "value string representation",
then converte this string in the destination value
Else it throw a "TypeConversionException".
Bug :
1)
When osgIntrospection try to found a chain of
"osgIntrospection::Converter"
It could do any downcast or (Type to SuperType) or upcast
(SuperType to Type).
This mean the the chain could be :
osg::Group to osg::Transform to osg::Camera to
osg::CullSettings to osg::CullStack to
osg::CollectOccludersVisitor to
osg::NodeVisitor to osg::Referenced to osg::Object
During the convertion with this chain, A METTRE failed and
the pointer in
"grp" is set NULL. But the "grp" is always a valid
"osgIntrospection::Value"
and so, osgIntrospection accept the conversion. Then it try
to use this pointer
to call the "setName" function. And Bing SEGFAULT.
2)
In "bool Reflection::accum_conv_path( ... )"
the convection path isn't accumulate in the recursive loop.
this cause multi request of a conversion path, and a
slowdown in the
conversion algorithm.
3)
Use of the last conversion way in a conversion from
pointer to pointer
this mean you can do this :
"osg::Node*" to " value string representation" to "osg::Material*"
What a bad thing !!!
Solution :
1)
Introduce the concept of dynamic_cast and static_cast.
now, to do a conversion, osgIntrospection does this :
- to found a "osgIntrospection::Converter" to convert
from "osg::Group*" to "osg::Node*"
- to found a chain of "osgIntrospection::Converter" to convert
from "osg::Group*" to "one or many type" to "osg::Node*"
only with static_cast, downcast (Type to SuperType)
- to found, if the source and the destination are two pointer,
a chain of "osgIntrospection::Converter" to convert
from "osg::Group*" to "one or many type" to "osg::Node*"
only with dynamic_cast, upcast (SuperType to Type)
- to convert an Enum to int or to unsigned int
- to convert the value in its "value string representation",
then convert this string in the destination value
Else it throw a "TypeConversionException".
Add the "enum CastType" to distinguish the static_cast or
dynamic_cast converter.
Add file OpenSceneGraph/include/osgIntrospection/CastType
2)
add a line to accumulate converter in converter Path.
3)
add a line to check if source and destination are pointer.
"
This commit is contained in:
@@ -16,18 +16,18 @@
|
||||
#define OSGINTROSPECTION_CONVERTER_
|
||||
|
||||
#include <osgIntrospection/Value>
|
||||
#include <vector>
|
||||
#include <list>
|
||||
|
||||
namespace osgIntrospection
|
||||
{
|
||||
|
||||
struct Converter
|
||||
{
|
||||
virtual CastType getCastType() const = 0;
|
||||
virtual Value convert(const Value& ) const = 0;
|
||||
virtual ~Converter() {}
|
||||
};
|
||||
|
||||
typedef std::vector<const Converter* > ConverterList;
|
||||
typedef std::list<const Converter* > ConverterList;
|
||||
|
||||
class CompositeConverter: public Converter
|
||||
{
|
||||
@@ -44,6 +44,7 @@ namespace osgIntrospection
|
||||
return accum;
|
||||
}
|
||||
|
||||
virtual CastType getCastType() const { return COMPOSITE_CAST; }
|
||||
private:
|
||||
ConverterList cvt_;
|
||||
};
|
||||
@@ -56,6 +57,8 @@ namespace osgIntrospection
|
||||
{
|
||||
return static_cast<D>(variant_cast<S>(src));
|
||||
}
|
||||
|
||||
virtual CastType getCastType() const { return STATIC_CAST; }
|
||||
};
|
||||
|
||||
template<typename S, typename D>
|
||||
@@ -66,6 +69,8 @@ namespace osgIntrospection
|
||||
{
|
||||
return dynamic_cast<D>(variant_cast<S>(src));
|
||||
}
|
||||
|
||||
virtual CastType getCastType() const { return DYNAMIC_CAST; }
|
||||
};
|
||||
|
||||
template<typename S, typename D>
|
||||
@@ -76,6 +81,8 @@ namespace osgIntrospection
|
||||
{
|
||||
return reinterpret_cast<D>(variant_cast<S>(src));
|
||||
}
|
||||
|
||||
virtual CastType getCastType() const { return REINTERPRET_CAST; }
|
||||
};
|
||||
|
||||
}
|
||||
|
||||
@@ -21,6 +21,7 @@
|
||||
#include <typeinfo>
|
||||
#include <map>
|
||||
#include <vector>
|
||||
#include <list>
|
||||
|
||||
/// This macro emulates the behavior of the standard typeid operator,
|
||||
/// returning the Type object associated to the type of the given
|
||||
@@ -34,12 +35,19 @@ namespace osgIntrospection
|
||||
class Type;
|
||||
struct Converter;
|
||||
|
||||
typedef std::vector<const Converter* > ConverterList;
|
||||
typedef std::list<const Converter* > ConverterList;
|
||||
|
||||
/// A map of types, indexed by their associated ExtendedTypeInfo
|
||||
/// structure.
|
||||
typedef std::map<ExtendedTypeInfo, Type*> TypeMap;
|
||||
|
||||
enum CastType
|
||||
{
|
||||
STATIC_CAST,
|
||||
DYNAMIC_CAST,
|
||||
REINTERPRET_CAST,
|
||||
COMPOSITE_CAST
|
||||
};
|
||||
|
||||
/// This class provides basic reflection services such as registration
|
||||
/// of new types and queries on the global type map.
|
||||
@@ -94,7 +102,7 @@ namespace osgIntrospection
|
||||
static void registerConverter(const Type& source, const Type& dest, const Converter* cvt);
|
||||
|
||||
private:
|
||||
static bool accum_conv_path(const Type& source, const Type& dest, ConverterList& conv, std::vector<const Type* > &chain);
|
||||
static bool accum_conv_path(const Type& source, const Type& dest, ConverterList& conv, std::vector<const Type* > &chain, CastType castType);
|
||||
static StaticData* _static_data;
|
||||
};
|
||||
|
||||
|
||||
Reference in New Issue
Block a user