d703c58936
"
and a later post the same osg-submissions thread:
"it's been a while since I have made the changes but I think it was due to problems with static builds of OpenThreads on windows. I was using
OpenThreads in a communication/synchronisation library (without
OpenSceneGraph). It seems I forgot to post a small change in the CMakeLists file of OpenThreads. If a user turns DYNAMIC_OPENTHREADS to OFF (static build) OT_LIBRARY_STATIC will be defined in the Config.
Without these changes a windows user will always end up with a "__declspec(dllexport)" or "__declspec(dllimport)" which is a problem for static builds."
And another post from Blasius on this topic:
"I tested with VS2005 and VS2008. For 32 bit everything works as expected. For x64 and VS2008 I could successfully do the cmake-configure and then the compilation but I had occasional crashes of cmTryCompileExec.exe (during the cmake-configure phase) which seems to be a cmake bug. With VS2005 and 64bit cmake does not set _OPENTHREADS_ATOMIC_USE_WIN32_INTERLOCKED although the interlocked functionality should be there. If I place the source snippet from the CHECK_CXX_SOURCE_RUNS macro to a separate sourcefile I can compile and run the resulting executable successfully. Forcing OPENTHREADS_ATOMIC_USE_WIN32_INTERLOCKED (on VS2005/x64) reveals a bug in "intrin.h" which seems to be fixed in VS2008 but not in VS2005.
In case anyone is interested the lines:
__MACHINEI(unsigned char _interlockedbittestandset(long *a, long b))
__MACHINEI(unsigned char _interlockedbittestandreset(long *a, long b))
__MACHINEX64(unsigned char _interlockedbittestandset64(__int64 *a, __int64 b))
__MACHINEX64(unsigned char _interlockedbittestandreset64(__int64 *a, __int64 b))
should be changed to:
__MACHINEI(unsigned char _interlockedbittestandset(long volatile *a, long b))
__MACHINEI(unsigned char _interlockedbittestandreset(long volatile *a, long b))
__MACHINEX64(unsigned char _interlockedbittestandset64(__int64 volatile *a, __int64 b))
__MACHINEX64(unsigned char _interlockedbittestandreset64(__int64 volatile *a, __int64 b))
The worst thing that can happen is that interlocked funtionality is not detected during cmake-configure and the mutex fallback is used.
Which reminds me another small glitch in the Atomic header so I attached a corrected version.
Why is the OT_LIBRARY_STATIC added to the config file? It is not needed anywhere.
OT_LIBRARY_STATIC is needed if you are doing static-builds on Windows. See my previous post on that.
"
35 lines
1.4 KiB
C++
35 lines
1.4 KiB
C++
/* -*-c++-*- OpenSceneGraph - Copyright (C) 2008 Robert Osfield
|
|
*
|
|
* This library is open source and may be redistributed and/or modified under
|
|
* the terms of the OpenSceneGraph Public License (OSGPL) version 0.0 or
|
|
* (at your option) any later version. The full license is in LICENSE file
|
|
* included with this distribution, and on the openscenegraph.org website.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* OpenSceneGraph Public License for more details.
|
|
*/
|
|
|
|
/****************************************************************************
|
|
* THIS FILE IS AUTOGENERATED BY CMAKE. DO NOT EDIT!
|
|
****************************************************************************/
|
|
|
|
/* Changes to the configuration reflected here can be made with ccmake on
|
|
* unix or with cmake-gui on windows. Alternatively you can use cmake's -D
|
|
* or -P switches to set some configuration values at cmake configuration time.
|
|
*/
|
|
|
|
#ifndef _OPENTHREADS_CONFIG
|
|
#define _OPENTHREADS_CONFIG
|
|
|
|
#cmakedefine _OPENTHREADS_ATOMIC_USE_GCC_BUILTINS
|
|
#cmakedefine _OPENTHREADS_ATOMIC_USE_MIPOSPRO_BUILTINS
|
|
#cmakedefine _OPENTHREADS_ATOMIC_USE_SUN
|
|
#cmakedefine _OPENTHREADS_ATOMIC_USE_WIN32_INTERLOCKED
|
|
#cmakedefine _OPENTHREADS_ATOMIC_USE_BSD_ATOMIC
|
|
#cmakedefine _OPENTHREADS_ATOMIC_USE_MUTEX
|
|
#cmakedefine OT_LIBRARY_STATIC
|
|
|
|
#endif
|