Laravel 9 Update (#1413)

Update to Laravel 9 and PHP 8+

Co-authored-by: B.Fatih KOZ <fatih.koz@gmail.com>

app/Console/Commands/AcarsReplay.php

@@ -17,25 +17,25 @@ class AcarsReplay extends Command
      *
      * @var string
      */
-    protected $apiKey = 'testadminapikey';
+    protected string $apiKey = 'testadminapikey';
 
     /**
      * For automatic updates, how many seconds to sleep between updates
      *
      * @var int
      */
-    protected $sleepTime = 10;
+    protected int $sleepTime = 10;
 
     /**
      * @var array key == update[callsign]
      *            value == PIREP ID
      */
-    protected $pirepList = [];
+    protected array $pirepList = [];
 
     /**
      * @var Client
      */
-    protected $httpClient;
+    protected Client $httpClient;
 
     /**
      * Return an instance of an HTTP client all ready to post

app/Console/Commands/CreateConfigs.php

@@ -2,11 +2,11 @@
 
 namespace App\Console\Commands;
 
-use App;
 use App\Contracts\Command;
 use App\Services\Installer\ConfigService;
 use App\Services\Installer\SeederService;
 use DatabaseSeeder;
+use Illuminate\Support\Facades\App;
 
 /**
  * Create the config files
@@ -16,8 +16,8 @@ class CreateConfigs extends Command
     protected $signature = 'phpvms:config {db_host} {db_name} {db_user} {db_pass}';
     protected $description = 'Create the config files';
 
-    private $databaseSeeder;
-    private $seederSvc;
+    private DatabaseSeeder $databaseSeeder;
+    private SeederService $seederSvc;
 
     public function __construct(DatabaseSeeder $databaseSeeder, SeederService $seederSvc)
     {

app/Console/Commands/CreateDatabase.php

@@ -11,7 +11,11 @@ class CreateDatabase extends Command
 {
     protected $signature = 'database:create {--reset} {--migrate} {--conn=?}';
     protected $description = 'Create a database';
-    protected $os;
+
+    /**
+     * @var Detector
+     */
+    protected Detector $os;
 
     /**
      * CreateDatabase constructor.

app/Console/Commands/DevCommands.php

@@ -24,7 +24,8 @@ class DevCommands extends Command
 {
     protected $signature = 'phpvms {cmd} {param?}';
     protected $description = 'Developer commands';
-    protected $dbSvc;
+
+    protected DatabaseService $dbSvc;
 
     /**
      * DevCommands constructor.

app/Console/Commands/DevInstall.php

@@ -13,7 +13,7 @@ class DevInstall extends Command
     protected $signature = 'phpvms:dev-install {--reset-db} {--reset-configs}';
     protected $description = 'Run a developer install and run the sample migration';
 
-    private $databaseSeeder;
+    private \DatabaseSeeder $databaseSeeder;
 
     public function __construct(\DatabaseSeeder $databaseSeeder)
     {

app/Console/Commands/ImportCsv.php

@@ -10,7 +10,7 @@ class ImportCsv extends Command
     protected $signature = 'phpvms:csv-import {type} {file}';
     protected $description = 'Import from a CSV file';
 
-    private $importer;
+    private ImportService $importer;
 
     /**
      * Import constructor.

app/Console/Commands/ProcessQueue.php

@@ -18,7 +18,7 @@ class ProcessQueue extends Command
     public function handle()
     {
         Artisan::call('queue:work', [
-            '--sansdaemon'      => null,
+            //'--sansdaemon'      => null,
             '--stop-when-empty' => null,
         ]);
 

app/Console/Commands/TestApi.php

@@ -8,7 +8,11 @@ use GuzzleHttp\Client;
 class TestApi extends Command
 {
     protected $signature = 'phpvms:test-api {apikey} {url}';
-    protected $httpClient;
+
+    /**
+     * @var Client
+     */
+    protected Client $httpClient;
 
     /**
      * Run dev related commands

app/Console/Commands/Version.php

@@ -10,8 +10,14 @@ class Version extends Command
 {
     protected $signature = 'phpvms:version {--write} {--base-only} {--write-full-version} {version?}';
 
-    private $versionSvc;
+    /**
+     * @var VersionService
+     */
+    private VersionService $versionSvc;
 
+    /**
+     * @param VersionService $versionSvc
+     */
     public function __construct(VersionService $versionSvc)
     {
         parent::__construct();

app/Console/Commands/YamlImport.php

@@ -12,7 +12,11 @@ class YamlImport extends Command
 {
     protected $signature = 'phpvms:yaml-import {files*}';
     protected $description = 'Developer commands';
-    protected $dbSvc;
+
+    /**
+     * @var DatabaseService
+     */
+    protected DatabaseService $dbSvc;
 
     /**
      * YamlImport constructor.