From 26061decedd1159b19aeb394e084ddd70be25c16 Mon Sep 17 00:00:00 2001 From: Nabeel Shahzad Date: Fri, 13 Jul 2018 07:43:27 -0500 Subject: [PATCH] Fix flight visibility for day --- app/Cron/Nightly/SetActiveFlights.php | 2 +- tests/FlightTest.php | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/app/Cron/Nightly/SetActiveFlights.php b/app/Cron/Nightly/SetActiveFlights.php index daadd9b6..62668974 100644 --- a/app/Cron/Nightly/SetActiveFlights.php +++ b/app/Cron/Nightly/SetActiveFlights.php @@ -70,7 +70,7 @@ class SetActiveFlights extends Listener $visible = Days::isToday($flight->days); if($flight->visible !== $visible) { Log::info('Toggling flight '.$flight->ident.' to '.($visible?'visible':'invisible')); - $flight->visible = true; + $flight->visible = $visible; } } else { if ($flight->visible !== true) { diff --git a/tests/FlightTest.php b/tests/FlightTest.php index 8dacd99a..f1fbe594 100644 --- a/tests/FlightTest.php +++ b/tests/FlightTest.php @@ -283,6 +283,7 @@ class FlightTest extends TestCase 'days' => Days::$isoDayMap[date('N')], ]); + // Not active because of days of week not today $flight_not_active = factory(App\Models\Flight::class)->create([ 'start_date' => Carbon\Carbon::now('UTC')->subDays(1), 'end_date' => Carbon\Carbon::now('UTC')->addDays(1),