From 36c904d98d2c582fa19c96ca794591a535e837ce Mon Sep 17 00:00:00 2001 From: Nabeel Shahzad Date: Fri, 19 Jan 2018 16:02:49 -0500 Subject: [PATCH] safer casting for boolean values --- app/Repositories/SettingRepository.php | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/app/Repositories/SettingRepository.php b/app/Repositories/SettingRepository.php index 8493b99c..fd873020 100644 --- a/app/Repositories/SettingRepository.php +++ b/app/Repositories/SettingRepository.php @@ -42,7 +42,14 @@ class SettingRepository extends BaseRepository implements CacheableInterface switch($setting->type) { case 'bool': case 'boolean': - return (bool) $setting->value; + $value = $setting->value; + if($value === 'true' || $value === '1') { + $value = true; + } elseif($value === 'false' || $value === '0') { + $value = false; + } + + return (bool) $value; break; case 'date': return Carbon::parse($setting->value);