FGFS-4.1/phpvms
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Reduce number of queries for update check (#520)

Browse Source
This commit is contained in:
Nabeel S
2020-01-30 12:44:59 -05:00
committed by GitHub
parent f0719d4d8d
commit 3c1b433c29
4 changed files with 14 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
app/Services/Installer/SeederService.php
View File

@@ -218,6 +218,7 @@ class SeederService extends Service
*/
private function settingsSeedsPending(): bool
{
$all_settings = DB::table('settings')->get();
$data = file_get_contents(database_path('/seeds/settings.yml'));
$yml = Yaml::parse($data);
@@ -228,7 +229,7 @@ class SeederService extends Service
}
$id = Setting::formatKey($setting['key']);
$row = DB::table('settings')->where('id', $id)->first();
$row = $all_settings->firstWhere('id', $id);
// Doesn't exist in the table, quit early and say there is stuff pending
if (!$row) {
@@ -264,14 +265,13 @@ class SeederService extends Service
*/
private function permissionsSeedsPending(): bool
{
$all_permissions = DB::table('permissions')->get();
$data = file_get_contents(database_path('/seeds/permissions.yml'));
$yml = Yaml::parse($data);
foreach ($yml as $perm) {
$row = DB::table('permissions')
->where('name', $perm['name'])
->first();
$row = $all_permissions->firstWhere('name', $perm['name']);
if (!$row) {
return true;
}