Reduce number of queries for update check (#520)

This commit is contained in:
Nabeel S
2020-01-30 12:44:59 -05:00
committed by GitHub
parent f0719d4d8d
commit 3c1b433c29
4 changed files with 14 additions and 10 deletions

View File

@@ -3,6 +3,7 @@
namespace Modules\Updater\Http\Controllers;
use App\Contracts\Controller;
use App\Services\Installer\InstallerService;
use App\Services\Installer\MigrationService;
use App\Services\Installer\SeederService;
use function count;
@@ -11,19 +12,23 @@ use Illuminate\Support\Facades\Log;
class UpdateController extends Controller
{
private $installerSvc;
private $migrationSvc;
private $seederSvc;
/**
* @param InstallerService $installerSvc
* @param MigrationService $migrationSvc
* @param SeederService $seederSvc
*/
public function __construct(
InstallerService $installerSvc,
MigrationService $migrationSvc,
SeederService $seederSvc
) {
$this->migrationSvc = $migrationSvc;
$this->seederSvc = $seederSvc;
$this->installerSvc = $installerSvc;
}
/**
@@ -44,9 +49,8 @@ class UpdateController extends Controller
*/
public function step1(Request $request)
{
$migrations = $this->migrationSvc->migrationsAvailable();
if (count($migrations) > 0) {
Log::info('No migrations found');
if ($this->installerSvc->isUpgradePending()) {
Log::info('Upgrade is pending');
}
return view('updater::steps/step1-update-available');