From 3c32f2d89d0a4628e7fe712677e6278636fc89fe Mon Sep 17 00:00:00 2001 From: Nabeel Shahzad Date: Sun, 26 Aug 2018 18:51:47 +0000 Subject: [PATCH] Apply fixes from StyleCI --- app/Console/Commands/AcarsReplay.php | 2 +- app/Console/Commands/ComposerCommand.php | 2 +- app/Console/Commands/Version.php | 1 + app/Console/Services/Importer.php | 4 ++-- app/Facades/Utils.php | 7 +++++-- app/Http/Controllers/Admin/DashboardController.php | 6 ++++-- app/Http/Controllers/Admin/PirepFieldController.php | 3 ++- app/Http/Controllers/Admin/SubfleetController.php | 4 +++- app/Http/Controllers/Api/PirepController.php | 4 ++-- app/Http/Controllers/Api/UserController.php | 11 +++++------ app/Http/Controllers/Frontend/PirepController.php | 2 +- app/Http/Resources/AcarsLog.php | 1 - app/Http/Resources/AcarsRoute.php | 1 - app/Http/Resources/Aircraft.php | 1 - app/Http/Resources/Airport.php | 1 - app/Http/Resources/Response.php | 1 - app/Interfaces/Controller.php | 2 +- app/Models/Observers/AircraftObserver.php | 1 + app/Models/Pirep.php | 6 ------ app/Providers/AppServiceProvider.php | 2 +- app/Repositories/SettingRepository.php | 1 + app/Services/DatabaseService.php | 2 +- app/Services/Finance/PirepFinanceService.php | 3 +-- app/Services/FlightService.php | 2 +- app/Services/ImportExport/AircraftImporter.php | 3 ++- app/Services/PirepService.php | 9 +++++---- app/Support/ICAO.php | 3 ++- app/Support/Metar.php | 5 +++-- app/Support/TimezonelistExtended.php | 9 +++++---- tests/AcarsTest.php | 1 + tests/ApiTest.php | 1 + tests/FlightTest.php | 1 + tests/GeoTest.php | 1 + tests/ImporterTest.php | 1 + tests/MetarTest.php | 1 - tests/PIREPTest.php | 1 + tests/RegistrationTest.php | 3 ++- tests/TestData.php | 3 ++- 38 files changed, 61 insertions(+), 51 deletions(-) diff --git a/app/Console/Commands/AcarsReplay.php b/app/Console/Commands/AcarsReplay.php index efb3f545..3898f3f9 100644 --- a/app/Console/Commands/AcarsReplay.php +++ b/app/Console/Commands/AcarsReplay.php @@ -249,7 +249,7 @@ class AcarsReplay extends Command if ($this->option('write-all')) { $this->info('In "dump-all" mode, just writing it all in'); } else { - /** @noinspection NestedPositiveIfStatementsInspection */ + /* @noinspection NestedPositiveIfStatementsInspection */ if (!$manual_mode) { $this->info('Going to send updates every 10s'); } else { diff --git a/app/Console/Commands/ComposerCommand.php b/app/Console/Commands/ComposerCommand.php index 8b238f6a..c64c8c35 100644 --- a/app/Console/Commands/ComposerCommand.php +++ b/app/Console/Commands/ComposerCommand.php @@ -33,7 +33,7 @@ class ComposerCommand extends Command protected function postUpdate(): void { if (config('app.env') === 'dev') { - /** @noinspection NestedPositiveIfStatementsInspection */ + /* @noinspection NestedPositiveIfStatementsInspection */ if (class_exists(\Barryvdh\LaravelIdeHelper\IdeHelperServiceProvider::class)) { Artisan::call('ide-helper:generate'); Artisan::call('ide-helper:meta'); diff --git a/app/Console/Commands/Version.php b/app/Console/Commands/Version.php index 6742b97d..37da9033 100644 --- a/app/Console/Commands/Version.php +++ b/app/Console/Commands/Version.php @@ -16,6 +16,7 @@ class Version extends Command * Create the version number that gets written out * * @param mixed $cfg + * * @return bool|string */ protected function createVersionNumber($cfg) diff --git a/app/Console/Services/Importer.php b/app/Console/Services/Importer.php index 09975504..5c978716 100644 --- a/app/Console/Services/Importer.php +++ b/app/Console/Services/Importer.php @@ -56,7 +56,7 @@ class Importer * CONSTANTS */ public const BATCH_READ_ROWS = 300; - public const SUBFLEET_NAME = 'Imported Aircraft'; + public const SUBFLEET_NAME = 'Imported Aircraft'; /** * Importer constructor. @@ -145,7 +145,7 @@ class Importer protected function info($message) { if (\is_array($message)) { - /** @noinspection ForgottenDebugOutputInspection */ + /* @noinspection ForgottenDebugOutputInspection */ print_r($message); } else { $this->log->writeln(''.$message.''); diff --git a/app/Facades/Utils.php b/app/Facades/Utils.php index 67bba325..c077c819 100644 --- a/app/Facades/Utils.php +++ b/app/Facades/Utils.php @@ -81,6 +81,7 @@ class Utils extends Facade /** * @param string $minutes + * * @return array */ public static function minutesToTimeParts($minutes): array @@ -102,8 +103,9 @@ class Utils extends Facade * * @param int $seconds * - * @return array['h', 'm', 's'] * @throws \Exception + * + * @return array['h', 'm', 's'] */ public static function secondsToTimeParts($seconds): array { @@ -126,8 +128,9 @@ class Utils extends Facade * @param int $seconds * @param bool $incl_sec * - * @return string * @throws \Exception + * + * @return string */ public static function secondsToTimeString($seconds, $incl_sec = false): string { diff --git a/app/Http/Controllers/Admin/DashboardController.php b/app/Http/Controllers/Admin/DashboardController.php index 5edd4805..63e2055b 100644 --- a/app/Http/Controllers/Admin/DashboardController.php +++ b/app/Http/Controllers/Admin/DashboardController.php @@ -66,9 +66,11 @@ class DashboardController extends Controller * Show the admin dashboard * * @param Request $request + * + * @throws \GuzzleHttp\Exception\GuzzleException + * @throws \GuzzleHttp\Exception\GuzzleException + * * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View - * @throws \GuzzleHttp\Exception\GuzzleException - * @throws \GuzzleHttp\Exception\GuzzleException */ public function index(Request $request) { diff --git a/app/Http/Controllers/Admin/PirepFieldController.php b/app/Http/Controllers/Admin/PirepFieldController.php index c67d6f29..c6638d1c 100644 --- a/app/Http/Controllers/Admin/PirepFieldController.php +++ b/app/Http/Controllers/Admin/PirepFieldController.php @@ -129,8 +129,9 @@ class PirepFieldController extends Controller * * @param mixed $id * - * @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector * @throws \Prettus\Validator\Exceptions\ValidatorException + * + * @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector */ public function update($id, UpdatePirepFieldRequest $request) { diff --git a/app/Http/Controllers/Admin/SubfleetController.php b/app/Http/Controllers/Admin/SubfleetController.php index 1809f9da..fe95d689 100644 --- a/app/Http/Controllers/Admin/SubfleetController.php +++ b/app/Http/Controllers/Admin/SubfleetController.php @@ -90,6 +90,7 @@ class SubfleetController extends Controller * Get all the fares that haven't been assigned to a given subfleet * * @param mixed $subfleet + * * @return array */ protected function getAvailFares($subfleet) @@ -268,8 +269,9 @@ class SubfleetController extends Controller * * @param Request $request * - * @return \Symfony\Component\HttpFoundation\BinaryFileResponse * @throws \League\Csv\CannotInsertRecord + * + * @return \Symfony\Component\HttpFoundation\BinaryFileResponse */ public function export(Request $request) { diff --git a/app/Http/Controllers/Api/PirepController.php b/app/Http/Controllers/Api/PirepController.php index 4db7ffd0..8fa7e404 100644 --- a/app/Http/Controllers/Api/PirepController.php +++ b/app/Http/Controllers/Api/PirepController.php @@ -222,7 +222,7 @@ class PirepController extends Controller $pirep = new Pirep($attrs); // See if this user is at the current airport - /** @noinspection NotOptimalIfConditionsInspection */ + /* @noinspection NotOptimalIfConditionsInspection */ if (setting('pilots.only_flights_from_current') && $user->curr_airport_id !== $pirep->dpt_airport_id) { throw new UserNotAtAirport(); @@ -235,7 +235,7 @@ class PirepController extends Controller } // See if this aircraft is at the departure airport - /** @noinspection NotOptimalIfConditionsInspection */ + /* @noinspection NotOptimalIfConditionsInspection */ if (setting('pireps.only_aircraft_at_dpt_airport') && $pirep->aircraft_id !== $pirep->dpt_airport_id) { throw new AircraftNotAtAirport(); diff --git a/app/Http/Controllers/Api/UserController.php b/app/Http/Controllers/Api/UserController.php index 5b833993..323c3caa 100644 --- a/app/Http/Controllers/Api/UserController.php +++ b/app/Http/Controllers/Api/UserController.php @@ -12,7 +12,6 @@ use App\Models\Enums\PirepState; use App\Repositories\Criteria\WhereCriteria; use App\Repositories\FlightRepository; use App\Repositories\PirepRepository; -use App\Repositories\SubfleetRepository; use App\Repositories\UserRepository; use App\Services\FlightService; use App\Services\UserService; @@ -35,11 +34,11 @@ class UserController extends Controller /** * UserController constructor. * - * @param FlightRepository $flightRepo - * @param FlightService $flightSvc - * @param PirepRepository $pirepRepo - * @param UserRepository $userRepo - * @param UserService $userSvc + * @param FlightRepository $flightRepo + * @param FlightService $flightSvc + * @param PirepRepository $pirepRepo + * @param UserRepository $userRepo + * @param UserService $userSvc */ public function __construct( FlightRepository $flightRepo, diff --git a/app/Http/Controllers/Frontend/PirepController.php b/app/Http/Controllers/Frontend/PirepController.php index a9538837..8b6c85a0 100644 --- a/app/Http/Controllers/Frontend/PirepController.php +++ b/app/Http/Controllers/Frontend/PirepController.php @@ -284,7 +284,7 @@ class PirepController extends Controller } // is the aircraft in the right place? - /** @noinspection NotOptimalIfConditionsInspection */ + /* @noinspection NotOptimalIfConditionsInspection */ if (setting('pireps.only_aircraft_at_dpt_airport') && $pirep->aircraft_id !== $pirep->dpt_airport_id) { return $this->flashError( diff --git a/app/Http/Resources/AcarsLog.php b/app/Http/Resources/AcarsLog.php index 3c2bfb02..075f9738 100644 --- a/app/Http/Resources/AcarsLog.php +++ b/app/Http/Resources/AcarsLog.php @@ -10,5 +10,4 @@ use Illuminate\Http\Resources\Json\Resource; */ class AcarsLog extends Resource { - } diff --git a/app/Http/Resources/AcarsRoute.php b/app/Http/Resources/AcarsRoute.php index 89cc09f2..32390091 100644 --- a/app/Http/Resources/AcarsRoute.php +++ b/app/Http/Resources/AcarsRoute.php @@ -10,5 +10,4 @@ use Illuminate\Http\Resources\Json\Resource; */ class AcarsRoute extends Resource { - } diff --git a/app/Http/Resources/Aircraft.php b/app/Http/Resources/Aircraft.php index aa62694b..a135fe32 100644 --- a/app/Http/Resources/Aircraft.php +++ b/app/Http/Resources/Aircraft.php @@ -6,5 +6,4 @@ use Illuminate\Http\Resources\Json\Resource; class Aircraft extends Resource { - } diff --git a/app/Http/Resources/Airport.php b/app/Http/Resources/Airport.php index 0a255653..a6c1eae5 100644 --- a/app/Http/Resources/Airport.php +++ b/app/Http/Resources/Airport.php @@ -6,5 +6,4 @@ use Illuminate\Http\Resources\Json\Resource; class Airport extends Resource { - } diff --git a/app/Http/Resources/Response.php b/app/Http/Resources/Response.php index 0c285709..7eb4849b 100644 --- a/app/Http/Resources/Response.php +++ b/app/Http/Resources/Response.php @@ -9,5 +9,4 @@ use Illuminate\Http\Resources\Json\Resource; */ class Response extends Resource { - } diff --git a/app/Interfaces/Controller.php b/app/Interfaces/Controller.php index ee539c25..bf2eb58b 100755 --- a/app/Interfaces/Controller.php +++ b/app/Interfaces/Controller.php @@ -62,7 +62,7 @@ abstract class Controller extends \Illuminate\Routing\Controller $fields[$field] = $request->input($field); } } else { - /** @noinspection NestedPositiveIfStatementsInspection */ + /* @noinspection NestedPositiveIfStatementsInspection */ if (array_key_exists($field, $request)) { $fields[$field] = $request[$field]; } diff --git a/app/Models/Observers/AircraftObserver.php b/app/Models/Observers/AircraftObserver.php index 0c9d8f14..555fc942 100644 --- a/app/Models/Observers/AircraftObserver.php +++ b/app/Models/Observers/AircraftObserver.php @@ -12,6 +12,7 @@ class AircraftObserver { /** * @param Aircraft $aircraft + * * @throws \Exception */ public function creating(Aircraft $aircraft): void diff --git a/app/Models/Pirep.php b/app/Models/Pirep.php index 493524cd..4869f864 100644 --- a/app/Models/Pirep.php +++ b/app/Models/Pirep.php @@ -168,8 +168,6 @@ class Pirep extends Model if (array_key_exists('block_off_time', $this->attributes)) { return new Carbon($this->attributes['block_off_time']); } - - return null; } /** @@ -182,8 +180,6 @@ class Pirep extends Model if (array_key_exists('block_on_time', $this->attributes)) { return new Carbon($this->attributes['block_on_time']); } - - return null; } /** @@ -196,8 +192,6 @@ class Pirep extends Model if (array_key_exists('submitted_at', $this->attributes)) { return new Carbon($this->attributes['submitted_at']); } - - return null; } /** diff --git a/app/Providers/AppServiceProvider.php b/app/Providers/AppServiceProvider.php index 77bc4f50..8979978a 100755 --- a/app/Providers/AppServiceProvider.php +++ b/app/Providers/AppServiceProvider.php @@ -64,7 +64,7 @@ class AppServiceProvider extends ServiceProvider if ($this->app->environment() === 'dev') { // Only load the IDE helper if it's included. This lets use distribute the // package without any dev dependencies - /** @noinspection NestedPositiveIfStatementsInspection */ + /* @noinspection NestedPositiveIfStatementsInspection */ if (class_exists(\Barryvdh\LaravelIdeHelper\IdeHelperServiceProvider::class)) { $this->app->register(\Barryvdh\LaravelIdeHelper\IdeHelperServiceProvider::class); } diff --git a/app/Repositories/SettingRepository.php b/app/Repositories/SettingRepository.php index 0f542c25..960cc952 100644 --- a/app/Repositories/SettingRepository.php +++ b/app/Repositories/SettingRepository.php @@ -70,6 +70,7 @@ class SettingRepository extends Repository implements CacheableInterface * * @param mixed $key * @param mixed $value + * * @return null */ public function save($key, $value) diff --git a/app/Services/DatabaseService.php b/app/Services/DatabaseService.php index 70b492ba..9ab70b8a 100644 --- a/app/Services/DatabaseService.php +++ b/app/Services/DatabaseService.php @@ -70,7 +70,7 @@ class DatabaseService extends Service // see if this table uses a UUID as the PK // if no ID is specified if (\in_array($table, $this->uuid_tables, true)) { - /** @noinspection NestedPositiveIfStatementsInspection */ + /* @noinspection NestedPositiveIfStatementsInspection */ if (!array_key_exists('id', $row)) { $row['id'] = Uuid::generate()->string; } diff --git a/app/Services/Finance/PirepFinanceService.php b/app/Services/Finance/PirepFinanceService.php index 2dc07134..c4a63c7a 100644 --- a/app/Services/Finance/PirepFinanceService.php +++ b/app/Services/Finance/PirepFinanceService.php @@ -11,7 +11,6 @@ use App\Models\Pirep; use App\Repositories\ExpenseRepository; use App\Repositories\JournalRepository; use App\Services\FareService; -use App\Services\PirepService; use App\Support\Math; use App\Support\Money; use Log; @@ -284,7 +283,7 @@ class PirepFinanceService extends Service .$expense->name.'", A='.$expense->amount); // If an airline_id is filled, then see if it matches - /** @noinspection NotOptimalIfConditionsInspection */ + /* @noinspection NotOptimalIfConditionsInspection */ if (filled($expense->airline_id) && $expense->airline_id !== $pirep->airline_id) { Log::info('Finance: Expense has an airline ID and it doesn\'t match, skipping'); continue; diff --git a/app/Services/FlightService.php b/app/Services/FlightService.php index a5d409bf..4fc62bc5 100644 --- a/app/Services/FlightService.php +++ b/app/Services/FlightService.php @@ -237,7 +237,7 @@ class FlightService extends Service throw new BidExists('A bid already exists for this flight'); } } else { - /** @noinspection NestedPositiveIfStatementsInspection */ + /* @noinspection NestedPositiveIfStatementsInspection */ if ($flight->has_bid === true) { Log::info('Bid exists, flight='.$flight->id.'; no entry in bids table, cleaning up'); } diff --git a/app/Services/ImportExport/AircraftImporter.php b/app/Services/ImportExport/AircraftImporter.php index eac8e9d5..2571b3a8 100644 --- a/app/Services/ImportExport/AircraftImporter.php +++ b/app/Services/ImportExport/AircraftImporter.php @@ -53,8 +53,9 @@ class AircraftImporter extends ImportExport * @param array $row * @param int $index * - * @return bool * @throws \Exception + * + * @return bool */ public function import(array $row, $index): bool { diff --git a/app/Services/PirepService.php b/app/Services/PirepService.php index 53389684..6e8cc025 100644 --- a/app/Services/PirepService.php +++ b/app/Services/PirepService.php @@ -19,7 +19,6 @@ use App\Models\Navdata; use App\Models\Pirep; use App\Models\PirepFieldValue; use App\Models\User; -use App\Repositories\PirepRepository; use Carbon\Carbon; use Illuminate\Database\Eloquent\ModelNotFoundException; use Log; @@ -35,8 +34,8 @@ class PirepService extends Service /** * PirepService constructor. * - * @param GeoService $geoSvc - * @param UserService $pilotSvc + * @param GeoService $geoSvc + * @param UserService $pilotSvc */ public function __construct( GeoService $geoSvc, @@ -196,6 +195,7 @@ class PirepService extends Service * Submit the PIREP. Figure out its default state * * @param Pirep $pirep + * * @throws \Exception */ public function submit(Pirep $pirep) @@ -302,8 +302,9 @@ class PirepService extends Service /** * @param Pirep $pirep * - * @return Pirep * @throws \Exception + * + * @return Pirep */ public function accept(Pirep $pirep): Pirep { diff --git a/app/Support/ICAO.php b/app/Support/ICAO.php index affdf22d..49186a2f 100644 --- a/app/Support/ICAO.php +++ b/app/Support/ICAO.php @@ -13,8 +13,9 @@ class ICAO * * @param null $country * - * @return string * @throws \Exception + * + * @return string */ public static function createHexCode($country = null) { diff --git a/app/Support/Metar.php b/app/Support/Metar.php index 37fe7e10..7f48043a 100644 --- a/app/Support/Metar.php +++ b/app/Support/Metar.php @@ -438,7 +438,7 @@ class Metar implements \ArrayAccess if (array_key_exists('cavok', $this->result) && $this->result['cavok']) { $this->result['category'] = 'VFR'; } else { - /** @noinspection NestedPositiveIfStatementsInspection */ + /* @noinspection NestedPositiveIfStatementsInspection */ if (array_key_exists('cloud_height', $this->result) && array_key_exists('visibility', $this->result)) { if ($this->result['cloud_height']['ft'] > 3000 && $this->result['visibility']['nmi'] > 5) { $this->result['category'] = 'VFR'; @@ -567,6 +567,7 @@ class Metar implements \ArrayAccess * Decodes TAF code if present. * * @param mixed $part + * * @return bool */ private function get_taf($part) @@ -772,7 +773,7 @@ class Metar implements \ArrayAccess if ($found[1] === 'CAVOK' || $found[1] === '9999') { $this->set_result_value('visibility', new Distance(10000, 'm')); $this->set_result_value('visibility_report', 'Greater than 10 km'); - /** @noinspection NotOptimalIfConditionsInspection */ + /* @noinspection NotOptimalIfConditionsInspection */ if ($found[1] === 'CAVOK') { $this->set_result_value('cavok', true); $this->method += 4; // can skip the next 4 methods: visibility_min, runway_vr, present_weather, clouds diff --git a/app/Support/TimezonelistExtended.php b/app/Support/TimezonelistExtended.php index 57b3b69c..3fb5919d 100644 --- a/app/Support/TimezonelistExtended.php +++ b/app/Support/TimezonelistExtended.php @@ -14,19 +14,20 @@ class TimezonelistExtended extends Timezonelist * @param string $continent * @param bool $htmlencode * + * @throws \Exception + * @throws \Exception + * * @return string - * @throws \Exception - * @throws \Exception */ protected function formatTimezone($timezone, $continent, $htmlencode = true) { $time = new \DateTimeImmutable(null, new DateTimeZone($timezone)); $offset = $time->format('P'); if ($htmlencode) { - $offset = str_replace(['-', '+'], array(' − ', ' + '), $offset); + $offset = str_replace(['-', '+'], [' − ', ' + '], $offset); } $timezone = substr($timezone, \strlen($continent) + 1); - $timezone = str_replace(['St_', '_'], array('St. ', ' '), $timezone); + $timezone = str_replace(['St_', '_'], ['St. ', ' '], $timezone); return '(GMT/UTC'.$offset.')'.self::WHITESPACE_SEP.$timezone; } diff --git a/tests/AcarsTest.php b/tests/AcarsTest.php index 4b54f36e..ac87b130 100644 --- a/tests/AcarsTest.php +++ b/tests/AcarsTest.php @@ -556,6 +556,7 @@ class AcarsTest extends TestCase /** * Test publishing multiple, batched updates + * * @throws Exception */ public function testMultipleAcarsPositionUpdates() diff --git a/tests/ApiTest.php b/tests/ApiTest.php index bd963227..d1b9031c 100644 --- a/tests/ApiTest.php +++ b/tests/ApiTest.php @@ -137,6 +137,7 @@ class ApiTest extends TestCase /** * Test getting the subfleets + * * @throws Exception */ public function testGetSubfleets() diff --git a/tests/FlightTest.php b/tests/FlightTest.php index f887d428..b438f661 100644 --- a/tests/FlightTest.php +++ b/tests/FlightTest.php @@ -123,6 +123,7 @@ class FlightTest extends TestCase /** * Get the flight's route + * * @throws Exception */ public function testFlightRoute() diff --git a/tests/GeoTest.php b/tests/GeoTest.php index bad765c2..ce585f91 100644 --- a/tests/GeoTest.php +++ b/tests/GeoTest.php @@ -35,6 +35,7 @@ class GeoTest extends TestCase /** * Make sure the departure airports/sid/star are all filtered out + * * @throws Exception */ public function testGetCoords() diff --git a/tests/ImporterTest.php b/tests/ImporterTest.php index f2b9e001..1544377a 100644 --- a/tests/ImporterTest.php +++ b/tests/ImporterTest.php @@ -228,6 +228,7 @@ class ImporterTest extends TestCase /** * Test exporting all the flights to a file + * * @throws \Illuminate\Validation\ValidationException */ public function testAircraftExporter(): void diff --git a/tests/MetarTest.php b/tests/MetarTest.php index 66d03805..00c191f0 100644 --- a/tests/MetarTest.php +++ b/tests/MetarTest.php @@ -122,5 +122,4 @@ class MetarTest extends TestCase $this->assertEquals('VFR', $metar['category']); $this->assertNotNull($metar); } - } diff --git a/tests/PIREPTest.php b/tests/PIREPTest.php index aec1687c..f131e76b 100644 --- a/tests/PIREPTest.php +++ b/tests/PIREPTest.php @@ -62,6 +62,7 @@ class PIREPTest extends TestCase ]); $pirep = $this->pirepSvc->create($pirep, []); + try { $this->pirepSvc->saveRoute($pirep); } catch (Exception $e) { diff --git a/tests/RegistrationTest.php b/tests/RegistrationTest.php index 38ffb630..04178f2f 100644 --- a/tests/RegistrationTest.php +++ b/tests/RegistrationTest.php @@ -8,8 +8,9 @@ class RegistrationTest extends TestCase /** * A basic test example. * - * @return void * @throws Exception + * + * @return void */ public function testRegistration() { diff --git a/tests/TestData.php b/tests/TestData.php index 246d0131..d712c687 100644 --- a/tests/TestData.php +++ b/tests/TestData.php @@ -56,8 +56,9 @@ trait TestData * @param null $aircraft_count * @param null $airport_id * - * @return mixed * @throws \Exception + * + * @return mixed */ public function createSubfleetWithAircraft($aircraft_count = null, $airport_id = null) {