Fixes (#435)

* Add flight level field to PIREP field closes #401

* Default value for distance 0 closes #400

* Block airline deletion if assets exist #367

* Formatting

* Move some of the base exception classes

* Fix skin references to use settings table

* Set default for theme name if setting is wrong

app/Exceptions/Converters/GenericExceptionAbstract.php

@@ -2,10 +2,10 @@
 
 namespace App\Exceptions\Converters;
 
-use App\Exceptions\HttpException;
+use App\Exceptions\AbstractHttpException;
 use Exception;
 
-class GenericException extends HttpException
+class GenericExceptionAbstract extends AbstractHttpException
 {
     private $exception;
 

app/Exceptions/Converters/NotFound.php

@@ -1,44 +0,0 @@
-<?php
-
-namespace App\Exceptions\Converters;
-
-use App\Exceptions\HttpException;
-use Exception;
-
-class NotFound extends HttpException
-{
-    private $exception;
-
-    public function __construct(Exception $exception)
-    {
-        $this->exception = $exception;
-        parent::__construct(
-            404,
-            $exception->getMessage()
-        );
-    }
-
-    /**
-     * Return the RFC 7807 error type (without the URL root)
-     */
-    public function getErrorType(): string
-    {
-        return 'not-found';
-    }
-
-    /**
-     * Get the detailed error string
-     */
-    public function getErrorDetails(): string
-    {
-        return $this->getMessage();
-    }
-
-    /**
-     * Return an array with the error details, merged with the RFC7807 response
-     */
-    public function getErrorMetadata(): array
-    {
-        return [];
-    }
-}

app/Exceptions/Converters/SymfonyException.php

@@ -2,10 +2,10 @@
 
 namespace App\Exceptions\Converters;
 
-use App\Exceptions\HttpException;
+use App\Exceptions\AbstractHttpException;
 use Symfony\Component\HttpKernel\Exception\HttpException as SymfonyHttpException;
 
-class SymfonyException extends HttpException
+class SymfonyException extends AbstractHttpException
 {
     private $exception;
 

app/Exceptions/Converters/ValidationException.php

@@ -2,11 +2,10 @@
 
 namespace App\Exceptions\Converters;
 
-use App\Exceptions\HttpException;
-use Illuminate\Support\Facades\Log;
+use App\Exceptions\AbstractHttpException;
 use Illuminate\Validation\ValidationException as IlluminateValidationException;
 
-class ValidationException extends HttpException
+class ValidationException extends AbstractHttpException
 {
     private $validationException;
     private $errorDetail;