From 7e09cf6c2876ef505e10d0843dbe2a16cd53e86e Mon Sep 17 00:00:00 2001
From: Nabeel Shahzad <nshahzad@gmail.com>
Date: Thu, 18 Jan 2018 22:32:50 -0500
Subject: [PATCH] Add enums for the custom analytics fields

---
 app/Models/Enums/AnalyticsDimensions.php           | 14 ++++++++++++++
 app/Models/Enums/AnalyticsMetrics.php              | 13 +++++++++++++
 .../Http/Controllers/InstallerController.php       |  3 ++-
 3 files changed, 29 insertions(+), 1 deletion(-)
 create mode 100644 app/Models/Enums/AnalyticsDimensions.php
 create mode 100644 app/Models/Enums/AnalyticsMetrics.php

diff --git a/app/Models/Enums/AnalyticsDimensions.php b/app/Models/Enums/AnalyticsDimensions.php
new file mode 100644
index 00000000..f5dbe28f
--- /dev/null
+++ b/app/Models/Enums/AnalyticsDimensions.php
@@ -0,0 +1,14 @@
+<?php
+
+namespace App\Models\Enums;
+
+/**
+ * Class AnalyticsDimensions
+ * @package App\Models\Enums
+ */
+class AnalyticsDimensions
+{
+    const PHP_VERSION = 1;
+    const MYSQL_VERSION = 2;
+    const PHPVMS_VERSION = 3;
+}
diff --git a/app/Models/Enums/AnalyticsMetrics.php b/app/Models/Enums/AnalyticsMetrics.php
new file mode 100644
index 00000000..68431b54
--- /dev/null
+++ b/app/Models/Enums/AnalyticsMetrics.php
@@ -0,0 +1,13 @@
+<?php
+
+namespace App\Models\Enums;
+
+/**
+ * Class AnalyticsMetrics
+ * @package App\Models\Enums
+ */
+class AnalyticsMetrics
+{
+    # Track the lookup time for airports from vaCentral
+    const AIRPORT_LOOKUP_TIME = 1;
+}
diff --git a/modules/Installer/Http/Controllers/InstallerController.php b/modules/Installer/Http/Controllers/InstallerController.php
index d400e577..ff8cf8f9 100644
--- a/modules/Installer/Http/Controllers/InstallerController.php
+++ b/modules/Installer/Http/Controllers/InstallerController.php
@@ -2,6 +2,7 @@
 
 namespace Modules\Installer\Http\Controllers;
 
+use App\Models\Enums\AnalyticsDimensions;
 use Log;
 use Irazasyed\LaravelGAMP\Facades\GAMP;
 use Illuminate\Http\Request;
@@ -270,7 +271,7 @@ class InstallerController extends Controller
 
         $gamp = GAMP::setClientId(uniqid('', true));
         $gamp->setDocumentPath('/install');
-        $gamp->setCustomDimension(PHP_VERSION, 1);
+        $gamp->setCustomDimension(PHP_VERSION, AnalyticsDimensions::PHP_VERSION);
         $gamp->sendPageview();
 
         # If analytics are disabled