FGFS-4.1/phpvms
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use where iso whereTime (#1137)

Browse Source 
Using whereTime may present a problem for flights conducted during utc midnight and some active/live flights may be deleted with whereTime.

Scenario;

now = today-01:00  utc
setting = 2 hours
date = yesterday-23:00 utc

Any live pireps will/may be deleted with whereTime 'cause their last updated TIME will be maximum 00:59 which is smaller than 23:00.
This commit is contained in:
B.Fatih KOZ
2021-04-13 16:08:50 +03:00
committed by GitHub
parent 3d55336823
commit 7e9eb08135
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/Cron/Hourly/RemoveExpiredLiveFlights.php
View File

@@ -27,7 +27,7 @@ class RemoveExpiredLiveFlights extends Listener
} }
$date = Carbon::now()->subHours(setting('acars.live_time')); $date = Carbon::now()->subHours(setting('acars.live_time'));
Pirep::whereTime('updated_at', '<', $date) Pirep::where('updated_at', '<', $date)
->where('state', PirepState::IN_PROGRESS) ->where('state', PirepState::IN_PROGRESS)
->delete(); ->delete();
} }