From 922e754c9e3258307f3f756567da080d4e4b499e Mon Sep 17 00:00:00 2001 From: Nabeel S Date: Tue, 2 Mar 2021 16:19:54 -0500 Subject: [PATCH] Check for valid reference object in recurring finance (#1056) --- app/Services/Finance/RecurringFinanceService.php | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/app/Services/Finance/RecurringFinanceService.php b/app/Services/Finance/RecurringFinanceService.php index d5044f0a..e98a73a3 100644 --- a/app/Services/Finance/RecurringFinanceService.php +++ b/app/Services/Finance/RecurringFinanceService.php @@ -66,6 +66,10 @@ class RecurringFinanceService extends Service $obj = $expense->getReferencedObject(); } + if (empty($obj)) { + return [null, null]; + } + if ($klass === 'Airport') { $memo = "Airport Expense: {$expense->name} ({$expense->ref_model_id})"; $transaction_group = "Airport: {$expense->ref_model_id}"; @@ -128,6 +132,9 @@ class RecurringFinanceService extends Service } [$memo, $ta_group] = $this->getMemoAndGroup($expense); + if (empty($memo) || empty($ta_group)) { + continue; + } $this->financeSvc->debitFromJournal( $journal,