Make sure proper subfleets are returned as part of the user profile #848 (#849)

* Make sure proper subfleets are returned as part of the user profile #848

* Formatting

app/Http/Controllers/Api/UserController.php

@@ -89,10 +89,7 @@ class UserController extends Controller
      */
     public function get($id)
     {
-        $user = $this->userRepo
-            ->with(['airline', 'bids', 'rank'])
-            ->find($id);
-
+        $user = $this->userSvc->getUser($id);
         return new UserResource($user);
     }
 

app/Http/Resources/User.php

@@ -31,6 +31,7 @@ class User extends Resource
         $res['airline'] = Airline::make($this->whenLoaded('airline'));
         $res['bids'] = UserBid::collection($this->whenLoaded('bids'));
         $res['rank'] = Rank::make($this->whenLoaded('rank'));
+        $res['subfleets'] = Subfleet::make($this->whenLoaded('subfleets'));
 
         return $res;
     }

app/Services/UserService.php

@@ -54,6 +54,26 @@ class UserService extends Service
         $this->userRepo = $userRepo;
     }
 
+    /**
+     * Find the user and return them with all of the data properly attached
+     *
+     * @param $user_id
+     *
+     * @return User
+     */
+    public function getUser($user_id): User
+    {
+        $user = $this->userRepo
+            ->with(['airline', 'bids', 'rank'])
+            ->find($user_id);
+
+        // Load the proper subfleets to the rank
+        $user->rank->subfleets = $this->getAllowableSubfleets($user);
+        $user->subfleets = $user->rank->subfleets;
+
+        return $user;
+    }
+
     /**
      * Register a pilot. Also attaches the initial roles
      * required, and then triggers the UserRegistered event