FGFS-4.1/phpvms
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #264 from nkevins/fix_metar_issue

Browse Source 
Fix METAR issue
This commit is contained in:
Nabeel Shahzad
2018-08-28 19:07:31 -05:00
committed by GitHub
parent e5935507c8 525e8ba8bb
commit aba23f99bd
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/Support/Metar.php
View File

@@ -993,7 +993,7 @@ class Metar implements \ArrayAccess
$observed['amount'] = $found[2]; $observed['amount'] = $found[2];
} }
} // Cloud cover observed } // Cloud cover observed
elseif (isset($found[5]) && !empty($found[5])) { elseif (isset($found[5]) && !empty($found[5]) && is_numeric($found[5])) {
$observed['height'] = new Altitude($found[5] * 100, 'feet'); $observed['height'] = new Altitude($found[5] * 100, 'feet');
// Cloud height // Cloud height

8
tests/MetarTest.php
View File

@@ -82,6 +82,14 @@ class MetarTest extends TestCase
{ {
$metar = 'EGLL 261250Z AUTO 17014KT 8000 -RA BKN010/// ' $metar = 'EGLL 261250Z AUTO 17014KT 8000 -RA BKN010/// '
.'BKN016/// OVC040/// //////TCU 13/12 Q1008 TEMPO 4000 RA'; .'BKN016/// OVC040/// //////TCU 13/12 Q1008 TEMPO 4000 RA';
$parsed = Metar::parse($metar);
$this->assertCount(4, $parsed['clouds']);
$this->assertEquals(1000, $parsed['clouds'][0]['height']['ft']);
$this->assertEquals(1600, $parsed['clouds'][1]['height']['ft']);
$this->assertEquals(4000, $parsed['clouds'][2]['height']['ft']);
$this->assertNull($parsed['clouds'][3]['height']['ft']);
} }
public function testMetarTrends() public function testMetarTrends()