From bf878a98a4801cb60e57d10e1ab314b662c3d09d Mon Sep 17 00:00:00 2001
From: Nabeel Shahzad <nshahzad@live.com>
Date: Tue, 13 Oct 2020 18:10:31 -0400
Subject: [PATCH] Extra logging around fares

---
 app/Http/Controllers/Admin/FareController.php |  3 +++
 app/Services/FareService.php                  | 10 +++++++++-
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/app/Http/Controllers/Admin/FareController.php b/app/Http/Controllers/Admin/FareController.php
index 82941fdd..8eaa6fad 100644
--- a/app/Http/Controllers/Admin/FareController.php
+++ b/app/Http/Controllers/Admin/FareController.php
@@ -12,6 +12,7 @@ use App\Repositories\FareRepository;
 use App\Services\ExportService;
 use App\Services\ImportService;
 use Illuminate\Http\Request;
+use Illuminate\Support\Facades\Log;
 use Laracasts\Flash\Flash;
 use Prettus\Repository\Criteria\RequestCriteria;
 
@@ -162,6 +163,8 @@ class FareController extends Controller
             return redirect(route('admin.fares.index'));
         }
 
+        Log::info('Deleting fare "'.$fare->name.'", id='.$fare->id);
+
         $this->fareRepo->delete($id);
 
         Flash::success('Fare deleted successfully.');
diff --git a/app/Services/FareService.php b/app/Services/FareService.php
index 944e8aa8..a62ba14c 100644
--- a/app/Services/FareService.php
+++ b/app/Services/FareService.php
@@ -9,6 +9,7 @@ use App\Models\Pirep;
 use App\Models\PirepFare;
 use App\Models\Subfleet;
 use App\Support\Math;
+use Illuminate\Support\Facades\Log;
 use function count;
 use Illuminate\Support\Collection;
 
@@ -106,6 +107,8 @@ class FareService extends Service
      */
     public function setForFlight(Flight $flight, Fare $fare, array $override = []): Flight
     {
+        Log::info('Setting fare "'.$fare->name.'" to flight "'.$flight->ident.'"');
+
         $flight->fares()->syncWithoutDetaching([$fare->id]);
 
         // modify any pivot values?
@@ -145,6 +148,8 @@ class FareService extends Service
      */
     public function delFareFromFlight(Flight $flight, Fare $fare)
     {
+        Log::info('Removing fare "'.$fare->name.'" to flight "'.$flight->ident.'"');
+
         $flight->fares()->detach($fare->id);
         $flight->refresh();
 
@@ -162,6 +167,8 @@ class FareService extends Service
      */
     public function setForSubfleet(Subfleet $subfleet, Fare $fare, array $override = []): Subfleet
     {
+        Log::info('Setting fare "'.$fare->name.'" to subfleet "'.$subfleet->name.'"');
+
         $subfleet->fares()->syncWithoutDetaching([$fare->id]);
 
         // modify any pivot values?
@@ -203,6 +210,8 @@ class FareService extends Service
      */
     public function delFareFromSubfleet(Subfleet &$subfleet, Fare &$fare)
     {
+        Log::info('Removing fare "'.$fare->name.'" from subfleet "'.$subfleet->name.'"');
+
         $subfleet->fares()->detach($fare->id);
         $subfleet->refresh();
 
@@ -219,7 +228,6 @@ class FareService extends Service
      */
     public function getForPirep(Pirep $pirep)
     {
-        $fares = [];
         $found_fares = PirepFare::where('pirep_id', $pirep->id)->get();
 
         return $found_fares;