From cb772a3c62a81af0f4ac49d226b267f11748e704 Mon Sep 17 00:00:00 2001
From: Nabeel Shahzad <nshahzad@gmail.com>
Date: Tue, 2 Jan 2018 10:59:44 -0600
Subject: [PATCH] Add BASE_URL constant to page and have AJAX calls use it

---
 app/helpers.php                                 |  6 +++++-
 public/assets/admin/js/admin.js                 | 12 ------------
 resources/views/admin/airports/script.blade.php | 11 +++++++++++
 resources/views/admin/app.blade.php             |  1 +
 resources/views/admin/pireps/script.blade.php   |  2 +-
 5 files changed, 18 insertions(+), 14 deletions(-)

diff --git a/app/helpers.php b/app/helpers.php
index bbb3a6be..70ab3394 100644
--- a/app/helpers.php
+++ b/app/helpers.php
@@ -41,8 +41,12 @@ if(!function_exists('show_datetime')) {
      * @param \Carbon\Carbon $date
      * @return string
      */
-    function show_datetime(\Carbon\Carbon $date)
+    function show_datetime(\Carbon\Carbon $date=null)
     {
+        if(empty($date)) {
+            return '-';
+        }
+
         $timezone = 'UTC';
         if (Auth::check()) {
             $timezone = Auth::user()->timezone ?: $timezone;
diff --git a/public/assets/admin/js/admin.js b/public/assets/admin/js/admin.js
index 7718579d..d2ef127a 100644
--- a/public/assets/admin/js/admin.js
+++ b/public/assets/admin/js/admin.js
@@ -2,15 +2,3 @@
  * admin functions, mostly map/mapping related
  */
 
-function phpvms_vacentral_airport_lookup(icao, callback) {
-    $.ajax({
-        url: '/api/airports/' + icao + '/lookup',
-        method: 'GET',
-        headers: {
-            'x-api-key': PHPVMS_USER_API_KEY
-        }
-    }).done(function (data, status) {
-        callback(data.data);
-    });
-}
-
diff --git a/resources/views/admin/airports/script.blade.php b/resources/views/admin/airports/script.blade.php
index 2eb94e25..c90f4bce 100644
--- a/resources/views/admin/airports/script.blade.php
+++ b/resources/views/admin/airports/script.blade.php
@@ -1,5 +1,16 @@
 @section('scripts')
 <script>
+function phpvms_vacentral_airport_lookup(icao, callback) {
+    $.ajax({
+        url: BASE_URL + '/api/airports/'+ icao + '/lookup',
+        method: 'GET',
+        headers: {
+            'x-api-key': PHPVMS_USER_API_KEY
+        }
+    }).done(function (data, status) {
+        callback(data.data);
+    });
+}
 
 $(document).ready(function() {
 
diff --git a/resources/views/admin/app.blade.php b/resources/views/admin/app.blade.php
index cfb52929..f3f4e414 100644
--- a/resources/views/admin/app.blade.php
+++ b/resources/views/admin/app.blade.php
@@ -23,6 +23,7 @@
     </style>
 
     <script>
+        const BASE_URL ='{!! url('/') !!}';
     @if (Auth::user())
         const PHPVMS_USER_API_KEY = "{!! Auth::user()->api_key !!}";
     @else
diff --git a/resources/views/admin/pireps/script.blade.php b/resources/views/admin/pireps/script.blade.php
index fe323861..06765884 100644
--- a/resources/views/admin/pireps/script.blade.php
+++ b/resources/views/admin/pireps/script.blade.php
@@ -3,7 +3,7 @@
 function changeStatus(values) {
     var destContainer = '#pirep_' + values.pirep_id + '_container';
     $.ajax({
-        url: '/admin/pireps/' + values.pirep_id + '/status',
+        url: BASE_URL + '/admin/pireps/' + values.pirep_id + '/status',
         data: values,
         type: 'POST',
         headers: {