From e04fa2e056031b35c65ff6f54b0615156c1b875d Mon Sep 17 00:00:00 2001
From: Nabeel Shahzad <nshahzad@gmail.com>
Date: Thu, 4 Jan 2018 23:31:57 -0600
Subject: [PATCH] Do a cleanup of the state check

---
 .../Controllers/Admin/AirportController.php   | 27 ++++++++-----------
 1 file changed, 11 insertions(+), 16 deletions(-)

diff --git a/app/Http/Controllers/Admin/AirportController.php b/app/Http/Controllers/Admin/AirportController.php
index dcd6dcf5..32f4edd2 100644
--- a/app/Http/Controllers/Admin/AirportController.php
+++ b/app/Http/Controllers/Admin/AirportController.php
@@ -18,6 +18,13 @@ class AirportController extends BaseController
     /** @var  AirportRepository */
     private $airportRepository;
 
+    public static $enabledStates = [
+        'on',
+        'true',
+        '1',
+        true,
+    ];
+
     public function __construct(AirportRepository $airportRepo)
     {
         $this->airportRepository = $airportRepo;
@@ -66,15 +73,9 @@ class AirportController extends BaseController
     public function store(CreateAirportRequest $request)
     {
         $input = $request->all();
+        $input['hub'] = \in_array($input['hub'], self::$enabledStates);
 
-        if($input['hub'] === 'on' || $input['hub'] === 'true' || $input['hub'] === '1') {
-            $input['hub'] = true;
-        } else {
-            $input['hub'] = false;
-        }
-
-        Log::info('Airport save', $input);
-        $airport = $this->airportRepository->create($input);
+        $this->airportRepository->create($input);
 
         Flash::success('Airport saved successfully.');
         return redirect(route('admin.airports.index'));
@@ -136,15 +137,9 @@ class AirportController extends BaseController
         }
 
         $attrs = $request->all();
-        Log::info('Airport update', $attrs);
+        $attrs['hub'] = \in_array($attrs['hub'], self::$enabledStates);
 
-        if ($attrs['hub'] === 'on' || $attrs['hub'] === 'true' || $attrs['hub'] === '1') {
-            $attrs['hub'] = true;
-        } else {
-            $attrs['hub'] = false;
-        }
-
-        $airport = $this->airportRepository->update($attrs, $id);
+        $this->airportRepository->update($attrs, $id);
 
         Flash::success('Airport updated successfully.');
         return redirect(route('admin.airports.index'));