Code cleanup from inspection results

This commit is contained in:
Nabeel Shahzad
2018-08-26 13:50:08 -05:00
parent 0f3424f41e
commit e95b3eb366
76 changed files with 226 additions and 268 deletions

View File

@@ -241,7 +241,7 @@ class AcarsReplay extends Command
*
* @return mixed
*/
public function handle()
public function handle(): void
{
$files = $this->argument('files');
$manual_mode = $this->option('manual');
@@ -249,6 +249,7 @@ class AcarsReplay extends Command
if ($this->option('write-all')) {
$this->info('In "dump-all" mode, just writing it all in');
} else {
/** @noinspection NestedPositiveIfStatementsInspection */
if (!$manual_mode) {
$this->info('Going to send updates every 10s');
} else {

View File

@@ -33,6 +33,7 @@ class ComposerCommand extends Command
protected function postUpdate(): void
{
if (config('app.env') === 'dev') {
/** @noinspection NestedPositiveIfStatementsInspection */
if (class_exists(\Barryvdh\LaravelIdeHelper\IdeHelperServiceProvider::class)) {
Artisan::call('ide-helper:generate');
Artisan::call('ide-helper:meta');

View File

@@ -16,6 +16,7 @@ class Version extends Command
* Create the version number that gets written out
*
* @param mixed $cfg
* @return bool|string
*/
protected function createVersionNumber($cfg)
{

View File

@@ -14,16 +14,6 @@ use Illuminate\Foundation\Console\Kernel as ConsoleKernel;
*/
class Kernel extends ConsoleKernel
{
protected $commands = [
/*Commands\AcarsReplay::class,
Commands\CreateDatabase::class,
Commands\DevCommands::class,
Commands\YamlImport::class,
Commands\ImportFromClassic::class,
Commands\NavdataImport::class,
Commands\TestApi::class,*/
];
/**
* Define the application's command schedule.
*

View File

@@ -43,7 +43,7 @@ class Importer
/**
* @var array
*/
private $creds = [];
private $creds;
/**
* Hold the instance of the console logger
@@ -55,8 +55,8 @@ class Importer
/**
* CONSTANTS
*/
const BATCH_READ_ROWS = 300;
const SUBFLEET_NAME = 'Imported Aircraft';
public const BATCH_READ_ROWS = 300;
public const SUBFLEET_NAME = 'Imported Aircraft';
/**
* Importer constructor.
@@ -140,11 +140,12 @@ class Importer
}
/**
* @param string $message
* @param string|array $message
*/
protected function info($message)
{
if (\is_array($message)) {
/** @noinspection ForgottenDebugOutputInspection */
print_r($message);
} else {
$this->log->writeln('<info>'.$message.'</info>');