Code cleanup from inspection results

2018-08-26 13:50:08 -05:00
parent 0f3424f41e
commit e95b3eb366
76 changed files with 226 additions and 268 deletions
--- a/app/Http/Controllers/Api/PirepController.php
+++ b/app/Http/Controllers/Api/PirepController.php
@@ -222,6 +222,7 @@ class PirepController extends Controller
        $pirep = new Pirep($attrs);

        // See if this user is at the current airport
+        /** @noinspection NotOptimalIfConditionsInspection */
        if (setting('pilots.only_flights_from_current')
            && $user->curr_airport_id !== $pirep->dpt_airport_id) {
            throw new UserNotAtAirport();
@@ -234,6 +235,7 @@ class PirepController extends Controller
        }

        // See if this aircraft is at the departure airport
+        /** @noinspection NotOptimalIfConditionsInspection */
        if (setting('pireps.only_aircraft_at_dpt_airport')
            && $pirep->aircraft_id !== $pirep->dpt_airport_id) {
            throw new AircraftNotAtAirport();