Code cleanup from inspection results

This commit is contained in:
Nabeel Shahzad
2018-08-26 13:50:08 -05:00
parent 0f3424f41e
commit e95b3eb366
76 changed files with 226 additions and 268 deletions

View File

@@ -96,7 +96,7 @@ abstract class Award
$e->getTrace()
);
return;
return false;
}
return $award;

View File

@@ -62,6 +62,7 @@ abstract class Controller extends \Illuminate\Routing\Controller
$fields[$field] = $request->input($field);
}
} else {
/** @noinspection NestedPositiveIfStatementsInspection */
if (array_key_exists($field, $request)) {
$fields[$field] = $request[$field];
}

View File

@@ -138,7 +138,7 @@ abstract class Enum
*/
final public function equals(self $enum): bool
{
return $this->getValue() === $enum->getValue() && get_called_class() == get_class($enum);
return $this->getValue() === $enum->getValue() && static::class === \get_class($enum);
}
/**
@@ -161,7 +161,7 @@ abstract class Enum
}
throw new \BadMethodCallException(
"No static method or enum constant '$name' in class ".get_called_class()
"No static method or enum constant '$name' in class ".static::class
);
}
}

View File

@@ -51,7 +51,7 @@ class ImportExport
*
* @param $code
*
* @return Airline
* @return \Illuminate\Database\Eloquent\Model
*/
public function getAirline($code)
{

View File

@@ -15,7 +15,7 @@ abstract class Repository extends \Prettus\Repository\Eloquent\BaseRepository
*
* @return mixed|null
*/
public function findWithoutFail($id, $columns = ['*'])
public function findWithoutFail($id, array $columns = ['*'])
{
try {
return $this->find($id, $columns);