Code cleanup from inspection results

2018-08-26 13:50:08 -05:00
parent 0f3424f41e
commit e95b3eb366
76 changed files with 226 additions and 268 deletions
--- a/app/Models/Flight.php
+++ b/app/Models/Flight.php
@@ -104,6 +104,7 @@ class Flight extends Model
     */
    public static function findByDays(array $days)
    {
+        /** @noinspection DynamicInvocationViaScopeResolutionInspection */
        $flights = self::where('active', true);
        foreach ($days as $day) {
            $flights = $flights->where('days', '&', $day);
@@ -139,7 +140,7 @@ class Flight extends Model
    public function getDistanceAttribute()
    {
        if (!array_key_exists('distance', $this->attributes)) {
-            return;
+            return 0;
        }

        try {