Code cleanup from inspection results

This commit is contained in:
Nabeel Shahzad
2018-08-26 13:50:08 -05:00
parent 0f3424f41e
commit e95b3eb366
76 changed files with 226 additions and 268 deletions

View File

@@ -31,23 +31,19 @@ class PirepService extends Service
{
private $geoSvc;
private $pilotSvc;
private $pirepRepo;
/**
* PirepService constructor.
*
* @param GeoService $geoSvc
* @param PirepRepository $pirepRepo
* @param UserService $pilotSvc
*/
public function __construct(
GeoService $geoSvc,
PirepRepository $pirepRepo,
UserService $pilotSvc
) {
$this->geoSvc = $geoSvc;
$this->pilotSvc = $pilotSvc;
$this->pirepRepo = $pirepRepo;
}
/**
@@ -200,6 +196,7 @@ class PirepService extends Service
* Submit the PIREP. Figure out its default state
*
* @param Pirep $pirep
* @throws \Exception
*/
public function submit(Pirep $pirep)
{
@@ -306,6 +303,7 @@ class PirepService extends Service
* @param Pirep $pirep
*
* @return Pirep
* @throws \Exception
*/
public function accept(Pirep $pirep): Pirep
{