Notifications fixes (#804)

* Emails not sending #795 #722

* Fix for news items not being sent; refactor some events; check for opt-in #722

* Formatting

* Remove extra parameter

tests/NewsTest.php

@@ -0,0 +1,43 @@
+<?php
+
+namespace Tests;
+
+use App\Models\User;
+use App\Notifications\Messages\NewsAdded;
+use App\Services\NewsService;
+use Illuminate\Support\Facades\Notification;
+
+class NewsTest extends TestCase
+{
+    /** @var NewsService */
+    private $newsSvc;
+
+    public function setUp(): void
+    {
+        parent::setUp();
+
+        $this->newsSvc = app(NewsService::class);
+    }
+
+    /**
+     * Tests that news is added but mainly that notifications are sent out to all users
+     *
+     * @throws \Prettus\Validator\Exceptions\ValidatorException
+     */
+    public function testNewsNotifications()
+    {
+        /** @var User[] $users */
+        $users_opt_in = factory(User::class, 5)->create(['opt_in' => true]);
+
+        /** @var User[] $users */
+        $users_opt_out = factory(User::class, 5)->create(['opt_in' => false]);
+
+        $this->newsSvc->addNews([
+            'user_id' => $users_opt_out[0]->id,
+            'subject' => 'News Item',
+            'body'    => 'News!',
+        ]);
+
+        Notification::assertSentTo($users_opt_in, NewsAdded::class);
+    }
+}