FGFS-4.1/phpvms
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add stricter validation around ACARS/PIREP API updates #149

Browse Source
This commit is contained in:
Nabeel Shahzad
2018-01-23 11:46:26 -06:00
parent ea4f4d25f5
commit edb72e462f
4 changed files with 130 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
tests/AcarsTest.php
View File

@@ -54,6 +54,34 @@ class AcarsTest extends TestCase
return $resp->json();
}
/**
* Post a PIREP into a PREFILE state and post ACARS
*/
public function testPrefileErrors()
{
$this->user = factory(App\Models\User::class)->create();
$airport = factory(App\Models\Airport::class)->create();
$airline = factory(App\Models\Airline::class)->create();
$aircraft = factory(App\Models\Aircraft::class)->create();
$uri = '/api/pireps/prefile';
$pirep = [
'_airline_id' => $airline->id,
'aircraft_id' => $aircraft->id,
'dpt_airport_id' => $airport->icao,
'arr_airport_id' => $airport->icao,
'flight_number' => '6000',
'level' => 38000,
'planned_flight_time' => 120,
'route' => 'POINTA POINTB',
];
$response = $this->post($uri, $pirep);
$response->assertStatus(400);
}
/**
* Post a PIREP into a PREFILE state and post ACARS
*/
@@ -121,6 +149,17 @@ class AcarsTest extends TestCase
$this->assertCount(1, $body);
$this->assertEquals(round($acars['lat'], 2), round($body[0]['lat'], 2));
$this->assertEquals(round($acars['lon'], 2), round($body[0]['lon'], 2));
# File the PIREP now
$uri = '/api/pireps/'.$pirep_id.'/file';
$response = $this->post($uri, []);
$response->assertStatus(400); // missing the flight time
$response = $this->post($uri, ['flight_time' => '1:30']);
$response->assertStatus(400); // invalid flight time
$response = $this->post($uri, ['flight_time' => '130']);
$response->assertStatus(200); // invalid flight time
}
/**