FGFS-4.1/phpvms
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix METAR decoding (text correction only) (#950)

Browse Source 
* Update Metar Decoding (Text Correction Only)

SKC means Sky Clear or Clear Skies.

Rest is ok

* Update MetarTest.php
This commit is contained in:
B.Fatih KOZ
2020-12-04 20:47:42 +03:00
committed by GitHub
parent 7379e93c46
commit fb44b73f44
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/Support/Metar.php
View File

@@ -172,11 +172,11 @@ class Metar implements \ArrayAccess
'NSW' => 'no significant weather are observed', 'NSW' => 'no significant weather are observed',
'NSC' => 'no significant clouds are observed', 'NSC' => 'no significant clouds are observed',
'NCD' => 'nil cloud detected', 'NCD' => 'nil cloud detected',
'SKC' => 'no significant changes expected', 'SKC' => 'sky is clear',
'CLR' => 'clear skies', 'CLR' => 'clear skies',
'NOBS' => 'no observation', 'NOBS' => 'no observation',
// //
'FEW' => 'a few', 'FEW' => 'few',
'SCT' => 'scattered', 'SCT' => 'scattered',
'BKN' => 'broken sky', 'BKN' => 'broken sky',
'OVC' => 'overcast sky', 'OVC' => 'overcast sky',

6
tests/MetarTest.php
View File

@@ -64,7 +64,7 @@ class MetarTest extends TestCase
$this->assertCount(4, $parsed['clouds']); $this->assertCount(4, $parsed['clouds']);
$this->assertEquals( $this->assertEquals(
'A few at 1676 meters; scattered at 2896 meters; broken sky at 3353 meters; broken sky at 7010 meters', 'Few at 1676 meters; scattered at 2896 meters; broken sky at 3353 meters; broken sky at 7010 meters',
$parsed['clouds_report'] $parsed['clouds_report']
); );
$this->assertEquals(1676.4, $parsed['cloud_height']['m']); $this->assertEquals(1676.4, $parsed['cloud_height']['m']);
@@ -147,8 +147,8 @@ class MetarTest extends TestCase
$metar = Metar::parse($metar); $metar = Metar::parse($metar);
$this->assertEquals(2, count($metar['clouds'])); $this->assertEquals(2, count($metar['clouds']));
$this->assertEquals('A few at 457 meters; a few at 7620 meters', $metar['clouds_report']); $this->assertEquals('Few at 457 meters; few at 7620 meters', $metar['clouds_report']);
$this->assertEquals('A few at 1500 feet; a few at 25000 feet', $metar['clouds_report_ft']); $this->assertEquals('Few at 1500 feet; few at 25000 feet', $metar['clouds_report_ft']);
} }
/** /**