From fc381da21bfe225345ad3c08b5bf421feb6304d7 Mon Sep 17 00:00:00 2001
From: Nabeel Shahzad <nshahzad@gmail.com>
Date: Thu, 22 Feb 2018 11:47:28 -0600
Subject: [PATCH] Clean JS in admin to use const/let instead of var

---
 resources/views/admin/app.blade.php | 45 ++++++++++++++---------------
 1 file changed, 22 insertions(+), 23 deletions(-)

diff --git a/resources/views/admin/app.blade.php b/resources/views/admin/app.blade.php
index c4019b70..d552f8a1 100644
--- a/resources/views/admin/app.blade.php
+++ b/resources/views/admin/app.blade.php
@@ -102,8 +102,9 @@
 <script src="{!! public_asset('/assets/admin/js/admin.js') !!}"></script>
 
 <script>
-var getStorage = function(key) {
-    var st = window.localStorage.getItem(key);
+const getStorage = function(key) {
+    const st = window.localStorage.getItem(key);
+
     console.log('storage: ', key, st);
     if(_.isNil(st)) {
         return {
@@ -114,17 +115,16 @@ var getStorage = function(key) {
     return JSON.parse(st);
 };
 
-var saveStorage = function(key, obj) {
+const saveStorage = function(key, obj) {
     console.log('save: ', key, obj);
     window.localStorage.setItem(key, JSON.stringify(obj));
 };
 
-var addItem = function(obj, item) {
-    if (_.isNil(obj)) {
-        obj = [];
-    }
+const addItem = function(obj, item) {
 
-    var index = _.indexOf(obj, item);
+    if (_.isNil(obj)) { obj = []; }
+
+    const index = _.indexOf(obj, item);
     if(index === -1) {
         obj.push(item);
     }
@@ -132,11 +132,11 @@ var addItem = function(obj, item) {
     return obj;
 };
 
-var removeItem = function (obj, item) {
-    if (_.isNil(obj)) {
-        obj = [];
-    }
-    var index = _.indexOf(obj, item);
+const removeItem = function (obj, item) {
+
+    if (_.isNil(obj)) { obj = []; }
+
+    const index = _.indexOf(obj, item);
     if (index !== -1) {
         console.log("removing", item);
         obj.splice(index, 1);
@@ -154,35 +154,34 @@ $(document).ready(function () {
         radioClass: 'icheckbox_square-blue'
     });
 
-    var storage = getStorage("phpvms.admin");
+    let storage = getStorage("phpvms.admin");
 
     // see what menu items should be open
-    for(var idx = 0; idx < storage.menu.length; idx++) {
-        var id = storage.menu[idx];
-        var elem = $(".collapse#" + id);
+    for(let idx = 0; idx < storage.menu.length; idx++) {
+        const id = storage.menu[idx];
+        const elem = $(".collapse#" + id);
         elem.addClass("in").trigger("show.bs.collapse");
 
-        var caret = $("a." + id + " b");
+        const caret = $("a." + id + " b");
         caret.addClass("pe-7s-angle-down");
         caret.removeClass("pe-7s-angle-up");
     }
 
     $(".collapse").on("hide.bs.collapse", function () {
         console.log('hiding');
-        var id = $(this).attr('id');
-        var elem = $("a." + id + " b");
+        const id = $(this).attr('id');
+        const elem = $("a." + id + " b");
         elem.removeClass("pe-7s-angle-down");
         elem.addClass("pe-7s-angle-up");
 
         removeItem(storage.menu, id);
         saveStorage("phpvms.admin", storage);
-
     });
 
     $(".collapse").on("show.bs.collapse", function () {
         console.log('showing');
-        var id = $(this).attr('id');
-        var caret = $("a." + id + " b");
+        const id = $(this).attr('id');
+        const caret = $("a." + id + " b");
         caret.addClass("pe-7s-angle-down");
         caret.removeClass("pe-7s-angle-up");