fix: package.json & package-lock.json to reduce vulnerabilities

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-POSTCSS-1255640

.github/scripts/build.sh

@@ -30,7 +30,6 @@ declare -a remove_files=(
   intellij_style.xml
   config.php
   docker-compose.yml
-  docker-compose.local.yml
   Makefile
   phpcs.xml
   phpunit.xml
@@ -74,12 +73,8 @@ ls -al $BASE_DIR/../
 
 tar -czf $TAR_NAME -C $BASE_DIR .
 sha256sum $TAR_NAME >"$TAR_NAME.sha256"
-
+tar2zip $TAR_NAME
-cd $BASE_DIR;
-zip -r $ZIP_NAME *
 sha256sum $ZIP_NAME >"$ZIP_NAME.sha256"
-mv $ZIP_NAME /tmp
-mv "$ZIP_NAME.sha256" /tmp
 
 ls -al /tmp
 

.github/workflows/build.yml

@@ -7,7 +7,7 @@ jobs:
     strategy:
       fail-fast: true
       matrix:
-        php-versions: ['7.3', '7.4', '8.0']
+        php-versions: ['7.3', '7.4']
     name: PHP ${{ matrix.php-versions }}
     env:
       extensions: intl, pcov, mbstring
@@ -41,6 +41,7 @@ jobs:
       with:
         path: ${{ steps.composer-cache.outputs.dir }}
         key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
+        restore-keys: ${{ runner.os }}-composer-
 
     # Configure PHP
     - name: Setup PHP

Dockerfile

@@ -2,7 +2,7 @@ FROM php:7.4-fpm-alpine
 
 WORKDIR /var/www/
 
-RUN apk add gmp-dev icu-dev zlib-dev libpng-dev
+RUN apk add gmp-dev icu-dev
 RUN curl --silent --show-error https://getcomposer.org/installer | php
 
 # Copy any config files in
@@ -14,7 +14,6 @@ RUN docker-php-ext-install \
   calendar \
   intl \
   pdo_mysql \
-  gd \
   gmp \
   opcache && \
   docker-php-ext-enable pdo_mysql opcache
@@ -27,6 +26,4 @@ RUN php composer.phar install \
     --no-scripts \
     --prefer-dist
 
-RUN chown -R www-data:www-data /var/www
-
 EXPOSE 9000

Makefile

@@ -109,9 +109,17 @@ reset-installer:
 	@php artisan database:create --reset
 	@php artisan migrate:refresh --seed
 
-.PHONY: docker-test
+.PHONY: docker
-docker-test:
+docker:
-	@docker-compose -f docker-compose.yml -f docker-compose.local.yml up
+	@mkdir -p $(CURR_PATH)/tmp/mysql
+
+	-docker rm -f phpvms
+	docker build -t phpvms .
+	docker run --name=phpvms \
+       -v $(CURR_PATH):/var/www/ \
+       -v $(CURR_PATH)/tmp/mysql:/var/lib/mysql \
+       -p 8080:80 \
+       phpvms
 
 .PHONY: docker-clean
 docker-clean:

README.md

@@ -30,16 +30,15 @@ A full distribution, with all of the composer dependencies, is available at this
 
 [View installation details](https://docs.phpvms.net/installation/installation)
 
-## Development Environment with Docker
+## Development Environment
 
-A full development environment can be brought up using Docker, without having to install composer/npm locally
+A full development environment can be brought up using Docker:
 
 ```bash
-make docker-test
+composer install
-
+npm install
-# **OR** with docker-compose directly
+docker-compose build
-
+docker-compose up
-docker-compose -f docker-compose.yml -f docker-compose.local.yml up
 ```
 
 Then go to `http://localhost`. If you're using dnsmasq, the `app` container is listening on `phpvms.test`, or you can add to your `/etc/hosts` file:
@@ -48,8 +47,6 @@ Then go to `http://localhost`. If you're using dnsmasq, the `app` container is l
 127.0.0.1   phpvms.test
 ```
 
-The `docker-compose.local.yml` overrides the `app` section in `docker-compose.yml`. The standard `docker-compose.yml` can be used if you want to deploy from the image, or as a template for your own Dockerized deployments.
-
 ### Building JS/CSS assets
 
 Yarn is required, run:

app/Console/Commands/EmailTest.php

@@ -1,32 +0,0 @@
-<?php
-
-namespace App\Console\Commands;
-
-use App;
-use App\Contracts\Command;
-
-class EmailTest extends Command
-{
-    protected $signature = 'phpvms:email-test';
-    protected $description = 'Send a test notification to admins';
-
-    /**
-     * Run dev related commands
-     *
-     * @throws \Symfony\Component\HttpFoundation\File\Exception\FileException
-     */
-    public function handle()
-    {
-        /** @var App\Notifications\NotificationEventsHandler $eventHandler */
-        $eventHandler = app(App\Notifications\NotificationEventsHandler::class);
-
-        $news = new App\Models\News();
-        $news->user_id = 1;
-        $news->subject = 'Test News';
-        $news->body = 'Test Body';
-        $news->save();
-
-        $newsEvent = new App\Events\NewsAdded($news);
-        $eventHandler->onNewsAdded($newsEvent);
-    }
-}

app/Console/Commands/ProcessQueue.php

@@ -1,38 +0,0 @@
-<?php
-
-namespace App\Console\Commands;
-
-use App;
-use App\Contracts\Command;
-use Illuminate\Support\Facades\Artisan;
-use Illuminate\Support\Facades\Log;
-
-class ProcessQueue extends Command
-{
-    protected $signature = 'queue:cron';
-    protected $description = 'Process the queue from a cron job';
-
-    /**
-     * Run the queue tasks
-     */
-    public function handle()
-    {
-        Artisan::call('queue:work', [
-            '--sansdaemon'      => null,
-            '--stop-when-empty' => null,
-        ]);
-
-        Log::info(Artisan::output());
-        ///** @var App\Support\WorkCommand $queueWorker */
-        //$queueWorker = new App\Support\WorkCommand(app('queue.worker'), app('cache.store'));
-
-        //$queueWorker->setInput($queueWorker->createInputFromArguments([]));
-        //$queueWorker->handle();
-
-        /*$output = $this->call('queue:work', [
-            '--stop-when-empty' => null,
-        ]);
-
-        Log::info($output);*/
-    }
-}

app/Console/Cron/JobQueue.php

@@ -1,25 +0,0 @@
-<?php
-
-namespace App\Console\Cron;
-
-use App\Contracts\Command;
-use Illuminate\Support\Facades\Artisan;
-
-/**
- * This just calls the CronHourly event, so all of the
- * listeners, etc can just be called to run those tasks
- */
-class JobQueue extends Command
-{
-    protected $signature = 'cron:queue';
-    protected $description = 'Run the cron queue tasks';
-    protected $schedule;
-
-    public function handle(): void
-    {
-        $this->redirectLoggingToFile('cron');
-        Artisan::call('queue:cron');
-
-        $this->info(Artisan::output());
-    }
-}

app/Console/Kernel.php

@@ -3,7 +3,6 @@
 namespace App\Console;
 
 use App\Console\Cron\Hourly;
-use App\Console\Cron\JobQueue;
 use App\Console\Cron\Monthly;
 use App\Console\Cron\Nightly;
 use App\Console\Cron\Weekly;
@@ -26,13 +25,6 @@ class Kernel extends ConsoleKernel
      */
     protected function schedule(Schedule $schedule): void
     {
-        // If not using the queue worker then run those via cron
-        if (!config('queue.worker', false)) {
-            $schedule->command(JobQueue::class)
-                ->everyMinute()
-                ->withoutOverlapping();
-        }
-
         $schedule->command(Nightly::class)->dailyAt('01:00');
         $schedule->command(Weekly::class)->weeklyOn(0);
         $schedule->command(Monthly::class)->monthlyOn(1);

app/Contracts/Command.php

@@ -24,9 +24,9 @@ abstract class Command extends \Illuminate\Console\Command
         parent::__construct();
 
         // Running in the console but not in the tests
-        /*if (app()->runningInConsole() && env('APP_ENV') !== 'testing') {
+        if (app()->runningInConsole() && env('APP_ENV') !== 'testing') {
             $this->redirectLoggingToFile('stdout');
-        }*/
+        }
     }
 
     /**

app/Contracts/Notification.php

@@ -2,9 +2,9 @@
 
 namespace App\Contracts;
 
-use App\Notifications\Channels\Discord\DiscordMessage;
 use Illuminate\Bus\Queueable;
 use Illuminate\Contracts\Queue\ShouldQueue;
+use Illuminate\Support\Facades\Log;
 
 class Notification extends \Illuminate\Notifications\Notification implements ShouldQueue
 {
@@ -17,14 +17,14 @@ class Notification extends \Illuminate\Notifications\Notification implements Sho
     {
         // Look in the notifications.channels config and see where this particular
         // notification can go. Map it to $channels
-        /*$klass = static::class;
+        $klass = static::class;
         $notif_config = config('notifications.channels', []);
         if (!array_key_exists($klass, $notif_config)) {
             Log::error('Notification type '.$klass.' missing from notifications config, defaulting to mail');
             return;
         }
 
-        $this->channels = $notif_config[$klass];*/
+        $this->channels = $notif_config[$klass];
     }
 
     /**
@@ -34,16 +34,8 @@ class Notification extends \Illuminate\Notifications\Notification implements Sho
      *
      * @return array
      */
-    /*public function via($notifiable)
+    public function via($notifiable)
     {
         return $this->channels;
-    }*/
-
-    /**
-     * @return DiscordMessage|null
-     */
-    public function toDiscordChannel($notifiable): ?DiscordMessage
-    {
-        return null;
     }
 }

app/Contracts/Repository.php

@@ -2,14 +2,11 @@
 
 namespace App\Contracts;
 
-use Exception;
 use Illuminate\Validation\Validator;
-use function is_array;
 use Prettus\Repository\Eloquent\BaseRepository;
-use Prettus\Repository\Exceptions\RepositoryException;
 
 /**
- * @mixin BaseRepository
+ * @mixin \Prettus\Repository\Eloquent\BaseRepository
  */
 abstract class Repository extends BaseRepository
 {
@@ -23,8 +20,8 @@ abstract class Repository extends BaseRepository
     {
         try {
             return $this->find($id, $columns);
-        } catch (Exception $e) {
+        } catch (\Exception $e) {
-            return null;
+            return;
         }
     }
 
@@ -35,7 +32,11 @@ abstract class Repository extends BaseRepository
      */
     public function validate($values)
     {
-        $validator = Validator::make($values, $this->model()->rules);
+        $validator = Validator::make(
+            $values,
+            $this->model()->rules
+        );
+
         if ($validator->fails()) {
             return $validator->messages();
         }
@@ -49,8 +50,6 @@ abstract class Repository extends BaseRepository
      * @param int    $count
      * @param string $sort_by created_at (default) or updated_at
      *
-     * @throws RepositoryException
-     *
      * @return mixed
      */
     public function recent($count = null, $sort_by = 'created_at')
@@ -72,7 +71,7 @@ abstract class Repository extends BaseRepository
         return $this->scopeQuery(function ($query) use ($where, $sort_by, $order_by) {
             $q = $query->where($where);
             // See if there are multi-column sorts
-            if (is_array($sort_by)) {
+            if (\is_array($sort_by)) {
                 foreach ($sort_by as $key => $sort) {
                     $q = $q->orderBy($key, $sort);
                 }
@@ -99,7 +98,7 @@ abstract class Repository extends BaseRepository
         return $this->scopeQuery(function ($query) use ($col, $values, $sort_by, $order_by) {
             $q = $query->whereNotIn($col, $values);
             // See if there are multi-column sorts
-            if (is_array($sort_by)) {
+            if (\is_array($sort_by)) {
                 foreach ($sort_by as $key => $sort) {
                     $q = $q->orderBy($key, $sort);
                 }
@@ -119,7 +118,7 @@ abstract class Repository extends BaseRepository
      * @param array  $columns
      * @param string $method
      *
-     * @throws RepositoryException
+     * @throws \Prettus\Repository\Exceptions\RepositoryException
      *
      * @return mixed
      */

app/Contracts/Resource.php

@@ -2,10 +2,7 @@
 
 namespace App\Contracts;
 
-use App\Support\Resources\CustomAnonymousResourceCollection;
-use App\Support\Resources\CustomPaginatedResourceResponse;
 use Illuminate\Http\Resources\Json\JsonResource;
-use Illuminate\Pagination\AbstractPaginator;
 
 /**
  * Base class for a resource/response
@@ -29,28 +26,4 @@ class Resource extends JsonResource
             }
         }
     }
-
-    /**
-     * Customize the response to exclude all the extra data that isn't used. Based on:
-     * https://gist.github.com/derekphilipau/4be52164a69ce487dcd0673656d280da
-     *
-     * @param \Illuminate\Http\Request $request
-     *
-     * @return \Illuminate\Http\JsonResponse
-     */
-    public function toResponse($request)
-    {
-        return $this->resource instanceof AbstractPaginator
-                    ? (new CustomPaginatedResourceResponse($this))->toResponse($request)
-                    : parent::toResponse($request);
-    }
-
-    public static function collection($resource)
-    {
-        return tap(new CustomAnonymousResourceCollection($resource, static::class), function ($collection) {
-            if (property_exists(static::class, 'preserveKeys')) {
-                $collection->preserveKeys = (new static([]))->preserveKeys === true;
-            }
-        });
-    }
 }

app/Cron/Hourly/RemoveExpiredLiveFlights.php

@@ -4,11 +4,9 @@ namespace App\Cron\Hourly;
 
 use App\Contracts\Listener;
 use App\Events\CronHourly;
-use App\Events\PirepCancelled;
 use App\Models\Enums\PirepState;
 use App\Models\Pirep;
 use Carbon\Carbon;
-use Illuminate\Support\Facades\Log;
 
 /**
  * Remove expired live flights
@@ -29,13 +27,8 @@ class RemoveExpiredLiveFlights extends Listener
         }
 
         $date = Carbon::now('UTC')->subHours(setting('acars.live_time'));
-        $pireps = Pirep::where('updated_at', '<', $date)
+        Pirep::where('updated_at', '<', $date)
             ->where('state', PirepState::IN_PROGRESS)
-            ->get();
+            ->delete();
-        foreach ($pireps as $pirep) {
-            event(new PirepCancelled($pirep));
-            Log::info('Cron: Deleting Expired Live PIREP id='.$pirep->id.', state='.PirepState::label($pirep->state));
-            $pirep->delete();
-        }
     }
 }

app/Cron/Nightly/ClearExpiredSimbrief.php

@@ -1,9 +1,9 @@
 <?php
 
-namespace App\Cron\Hourly;
+namespace App\Cron\Nightly;
 
 use App\Contracts\Listener;
-use App\Events\CronHourly;
+use App\Events\CronNightly;
 use App\Services\SimBriefService;
 use Illuminate\Support\Facades\Log;
 
@@ -22,9 +22,9 @@ class ClearExpiredSimbrief extends Listener
     /**
      * @param \App\Events\CronNightly $event
      */
-    public function handle(CronHourly $event): void
+    public function handle(CronNightly $event): void
     {
-        Log::info('Hourly: Removing expired Simbrief entries');
+        Log::info('Nightly: Removing expired Simbrief entries');
         $this->simbriefSvc->removeExpiredEntries();
     }
 }

app/Cron/Nightly/NewVersionCheck.php

@@ -7,6 +7,9 @@ use App\Events\CronNightly;
 use App\Services\VersionService;
 use Illuminate\Support\Facades\Log;
 
+/**
+ * Determine if any pilots should be set to ON LEAVE status
+ */
 class NewVersionCheck extends Listener
 {
     private $versionSvc;

app/Database/factories/AirportFactory.php

@@ -11,7 +11,7 @@ if (!function_exists('createFactoryICAO')) {
         $characters = 'ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789';
         $max = strlen($characters) - 1;
         $string = '';
-        for ($i = 0; $i < 5; $i++) {
+        for ($i = 0; $i < 4; $i++) {
             try {
                 $string .= $characters[random_int(0, $max)];
             } catch (Exception $e) {

app/Database/migrations/2021_05_21_141152_increase_icao_sizes.php

@@ -1,26 +0,0 @@
-<?php
-
-use App\Contracts\Migration;
-use Illuminate\Database\Schema\Blueprint;
-use Illuminate\Support\Facades\Schema;
-
-/**
- * Increase Airport ICAO size to 5 chars
- * https://github.com/nabeelio/phpvms/issues/1052
- */
-class IncreaseIcaoSizes extends Migration
-{
-    public function up()
-    {
-        Schema::table('airports', function (Blueprint $table) {
-            $table->string('iata', 5)->change();
-            $table->string('icao', 5)->change();
-        });
-
-        Schema::table('pireps', function (Blueprint $table) {
-            $table->string('dpt_airport_id', 5)->change();
-            $table->string('arr_airport_id', 5)->change();
-            $table->string('alt_airport_id', 5)->change();
-        });
-    }
-}

app/Database/migrations/2021_05_28_165608_remove_setting_simbriefexpiredays.php

@@ -1,19 +0,0 @@
-<?php
-
-use Illuminate\Database\Migrations\Migration;
-use Illuminate\Support\Facades\DB;
-
-class RemoveSettingSimbriefExpireDays extends Migration
-{
-    /**
-     * Run the migrations.
-     *
-     * @return void
-     */
-    public function up()
-    {
-        DB::table('settings')
-            ->where(['key' => 'simbrief.expire_days'])
-            ->delete();
-    }
-}

app/Database/migrations/2021_06_01_141152_discord_fields.php

@@ -1,32 +0,0 @@
-<?php
-
-use App\Contracts\Migration;
-use Illuminate\Database\Schema\Blueprint;
-use Illuminate\Support\Facades\DB;
-use Illuminate\Support\Facades\Schema;
-
-class DiscordFields extends Migration
-{
-    public function up()
-    {
-        // Delete the old Discord fields and then a webhook will get added
-        DB::table('settings')
-            ->where(['key' => 'notifications.discord_api_key'])
-            ->delete();
-
-        DB::table('settings')
-            ->where(['key' => 'notifications.discord_public_channel_id'])
-            ->delete();
-
-        DB::table('settings')
-            ->where(['key' => 'notifications.discord_public_channel_id'])
-            ->delete();
-
-        // Add a field to the user to enter their own Discord ID
-        Schema::table('users', function (Blueprint $table) {
-            $table->string('discord_id')
-                ->default('')
-                ->after('rank_id');
-        });
-    }
-}

app/Database/migrations/2021_06_04_141152_discord_private_channel_id.php

@@ -1,18 +0,0 @@
-<?php
-
-use App\Contracts\Migration;
-use Illuminate\Database\Schema\Blueprint;
-use Illuminate\Support\Facades\Schema;
-
-class DiscordPrivateChannelId extends Migration
-{
-    public function up()
-    {
-        // Add a field to the user to enter their own Discord ID
-        Schema::table('users', function (Blueprint $table) {
-            $table->string('discord_private_channel_id')
-                ->default('')
-                ->after('discord_id');
-        });
-    }
-}

app/Database/seeds/dev/in_progress.yml

@@ -1,5 +1,519 @@
 acars:
-  - pirep_id: b68R5gwVzpVe
+  - id: aM8QpMPEB15e
+    pirep_id: b68R5gwVzpVe
+    type: '0'
+    nav_type: null
+    order: '0'
+    name: null
+    log: null
+    lat: '17.934117958358'
+    lon: '-76.77856721815'
+    heading: '124'
+    altitude: '8.1663703232199'
+    vs: '0'
+    gs: '0.0064996252497234'
+    transponder: null
+    autopilot: null
+    fuel_flow: null
+    sim_time: now
+    created_at: 'now'
+    updated_at: 'now'
+  - id: eZ6VJ3xj8vge
+    pirep_id: b68R5gwVzpVe
+    type: '0'
+    nav_type: null
+    order: '0'
+    name: null
+    log: null
+    lat: '17.934117498661'
+    lon: '-76.778566516289'
+    heading: '124'
+    altitude: '8.1664622222087'
+    vs: '0'
+    gs: '0'
+    transponder: null
+    autopilot: null
+    fuel_flow: null
+    sim_time: now
+    created_at: 'now'
+    updated_at: 'now'
+  - id: bo2QqDLl2lLa
+    pirep_id: b68R5gwVzpVe
+    type: '0'
+    nav_type: null
+    order: '0'
+    name: null
+    log: null
+    lat: '17.933884143334'
+    lon: '-76.778210172233'
+    heading: '124'
+    altitude: '8.1707802663933'
+    vs: '0'
+    gs: '14.419195209695'
+    transponder: null
+    autopilot: null
+    fuel_flow: null
+    sim_time: now
+    created_at: 'now'
+    updated_at: 'now'
+  - id: aM8QpM4qV2Be
+    pirep_id: b68R5gwVzpVe
+    type: '0'
+    nav_type: null
+    order: '0'
+    name: null
+    log: null
+    lat: '17.933705349611'
+    lon: '-76.777936938059'
+    heading: '124'
+    altitude: '8.170089899507'
+    vs: '0'
+    gs: '15.392330039049'
+    transponder: null
+    autopilot: null
+    fuel_flow: null
+    sim_time: now
+    created_at: 'now'
+    updated_at: 'now'
+  - id: dR6oxR9qjoOd
+    pirep_id: b68R5gwVzpVe
+    type: '0'
+    nav_type: null
+    order: '0'
+    name: null
+    log: null
+    lat: '17.933130691906'
+    lon: '-76.777152737985'
+    heading: '158'
+    altitude: '8.1683570286331'
+    vs: '0'
+    gs: '10.450467475023'
+    transponder: null
+    autopilot: null
+    fuel_flow: null
+    sim_time: now
+    created_at: 'now'
+    updated_at: 'now'
+  - id: erkRwJODRvEa
+    pirep_id: b68R5gwVzpVe
+    type: '0'
+    nav_type: null
+    order: '0'
+    name: null
+    log: null
+    lat: '17.932580370289'
+    lon: '-76.777450200122'
+    heading: '221'
+    altitude: '8.1695896791822'
+    vs: '0'
+    gs: '12.932334300694'
+    transponder: null
+    autopilot: null
+    fuel_flow: null
+    sim_time: now
+    created_at: 'now'
+    updated_at: 'now'
+  - id: b2kv53VMy7Ad
+    pirep_id: b68R5gwVzpVe
+    type: '0'
+    nav_type: null
+    order: '0'
+    name: null
+    log: null
+    lat: '17.932012550651'
+    lon: '-76.778009113329'
+    heading: '296'
+    altitude: '8.1683852467213'
+    vs: '0'
+    gs: '10.502719192825'
+    transponder: null
+    autopilot: null
+    fuel_flow: null
+    sim_time: now
+    created_at: 'now'
+    updated_at: 'now'
+  - id: eXDoE14JxAve
+    pirep_id: b68R5gwVzpVe
+    type: '0'
+    nav_type: null
+    order: '0'
+    name: null
+    log: null
+    lat: '17.932052237309'
+    lon: '-76.778111495187'
+    heading: '290'
+    altitude: '8.1719753739837'
+    vs: '0'
+    gs: '12.643743277153'
+    transponder: null
+    autopilot: null
+    fuel_flow: null
+    sim_time: now
+    created_at: 'now'
+    updated_at: 'now'
+  - id: b68R5gZ5YyOe
+    pirep_id: b68R5gwVzpVe
+    type: '0'
+    nav_type: null
+    order: '0'
+    name: null
+    log: null
+    lat: '17.932664026837'
+    lon: '-76.779705339967'
+    heading: '293'
+    altitude: '8.2203963962548'
+    vs: '0'
+    gs: '64.870244840054'
+    transponder: null
+    autopilot: null
+    fuel_flow: null
+    sim_time: now
+    created_at: 'now'
+    updated_at: 'now'
+  - id: bqxYvGNN5N0a
+    pirep_id: b68R5gwVzpVe
+    type: '0'
+    nav_type: null
+    order: '0'
+    name: null
+    log: null
+    lat: '17.934300220408'
+    lon: '-76.783954914814'
+    heading: '293'
+    altitude: '8.3302468103811'
+    vs: '0'
+    gs: '122.78529244208'
+    transponder: null
+    autopilot: null
+    fuel_flow: null
+    sim_time: now
+    created_at: 'now'
+    updated_at: 'now'
+  - id: en5rpBKw514d
+    pirep_id: b68R5gwVzpVe
+    type: '0'
+    nav_type: null
+    order: '0'
+    name: null
+    log: null
+    lat: '17.935736496556'
+    lon: '-76.78765616448'
+    heading: '293'
+    altitude: '49.554739665916'
+    vs: '21'
+    gs: '146.79677958636'
+    transponder: null
+    autopilot: null
+    fuel_flow: null
+    sim_time: now
+    created_at: 'now'
+    updated_at: 'now'
+  - id: erkRwJA29l2a
+    pirep_id: b68R5gwVzpVe
+    type: '0'
+    nav_type: null
+    order: '0'
+    name: null
+    log: null
+    lat: '17.976972983585'
+    lon: '-76.896548114872'
+    heading: '297'
+    altitude: '6228.684012199'
+    vs: '62'
+    gs: '281.03976876098'
+    transponder: null
+    autopilot: null
+    fuel_flow: null
+    sim_time: now
+    created_at: 'now'
+    updated_at: 'now'
+  - id: dR6oxR3r5nwd
+    pirep_id: b68R5gwVzpVe
+    type: '0'
+    nav_type: null
+    order: '0'
+    name: null
+    log: null
+    lat: '18.061360208405'
+    lon: '-77.056156629983'
+    heading: '301'
+    altitude: '12522.331716891'
+    vs: '25'
+    gs: '371.70833265547'
+    transponder: null
+    autopilot: null
+    fuel_flow: null
+    sim_time: now
+    created_at: 'now'
+    updated_at: 'now'
+  - id: e1wr82J877Zb
+    pirep_id: b68R5gwVzpVe
+    type: '0'
+    nav_type: null
+    order: '0'
+    name: null
+    log: null
+    lat: '18.17373613295'
+    lon: '-77.260347185993'
+    heading: '301'
+    altitude: '16802.15636323'
+    vs: '43'
+    gs: '421.37353688139'
+    transponder: null
+    autopilot: null
+    fuel_flow: null
+    sim_time: now
+    created_at: 'now'
+    updated_at: 'now'
+  - id: bqxYvGyExN2a
+    pirep_id: b68R5gwVzpVe
+    type: '0'
+    nav_type: null
+    order: '0'
+    name: null
+    log: null
+    lat: '18.193907285814'
+    lon: '-77.29810465405'
+    heading: '297'
+    altitude: '17395.953175647'
+    vs: '40'
+    gs: '425.98105291451'
+    transponder: null
+    autopilot: null
+    fuel_flow: null
+    sim_time: now
+    created_at: 'now'
+    updated_at: 'now'
+  - id: aQW0wQDQk5Md
+    pirep_id: b68R5gwVzpVe
+    type: '0'
+    nav_type: null
+    order: '0'
+    name: null
+    log: null
+    lat: '18.648921231143'
+    lon: '-78.014696613517'
+    heading: '323'
+    altitude: '37108.124381987'
+    vs: '22'
+    gs: '438.52028383384'
+    transponder: null
+    autopilot: null
+    fuel_flow: null
+    sim_time: now
+    created_at: 'now'
+    updated_at: 'now'
+  - id: e9rQ5lk3p63a
+    pirep_id: b68R5gwVzpVe
+    type: '0'
+    nav_type: null
+    order: '0'
+    name: null
+    log: null
+    lat: '18.796585259338'
+    lon: '-78.194734005052'
+    heading: '260'
+    altitude: '39718.178225504'
+    vs: '19'
+    gs: '432.41969107334'
+    transponder: null
+    autopilot: null
+    fuel_flow: null
+    sim_time: now
+    created_at: 'now'
+    updated_at: 'now'
+  - id: aQW0wQP8vZqd
+    pirep_id: b68R5gwVzpVe
+    type: '0'
+    nav_type: null
+    order: '0'
+    name: null
+    log: null
+    lat: '18.660552760063'
+    lon: '-78.407597067994'
+    heading: '242'
+    altitude: '40998.775690971'
+    vs: '-25'
+    gs: '449.51695639627'
+    transponder: null
+    autopilot: null
+    fuel_flow: null
+    sim_time: now
+    created_at: 'now'
+    updated_at: 'now'
+  - id: bqxYvGKgp32a
+    pirep_id: b68R5gwVzpVe
+    type: '0'
+    nav_type: null
+    order: '0'
+    name: null
+    log: null
+    lat: '18.592775999582'
+    lon: '-78.638711340118'
+    heading: '298'
+    altitude: '41060.297106821'
+    vs: '0'
+    gs: '427.14806185954'
+    transponder: null
+    autopilot: null
+    fuel_flow: null
+    sim_time: now
+    created_at: 'now'
+    updated_at: 'now'
+  - id: bqxYvGg2r02a
+    pirep_id: b68R5gwVzpVe
+    type: '0'
+    nav_type: null
+    order: '0'
+    name: null
+    log: null
+    lat: '18.718367591656'
+    lon: '-78.840980459275'
+    heading: '284'
+    altitude: '41065.55293844'
+    vs: '1'
+    gs: '424.89060056552'
+    transponder: null
+    autopilot: null
+    fuel_flow: null
+    sim_time: now
+    created_at: 'now'
+    updated_at: 'now'
+  - id: e0RV61wPj53b
+    pirep_id: b68R5gwVzpVe
+    type: '0'
+    nav_type: null
+    order: '0'
+    name: null
+    log: null
+    lat: '18.77448809677'
+    lon: '-79.082727467209'
+    heading: '283'
+    altitude: '41069.809333539'
+    vs: '0'
+    gs: '425.02780492483'
+    transponder: null
+    autopilot: null
+    fuel_flow: null
+    sim_time: now
+    created_at: 'now'
+    updated_at: 'now'
+  - id: dwpmBOo3wWwe
+    pirep_id: b68R5gwVzpVe
+    type: '0'
+    nav_type: null
+    order: '0'
+    name: null
+    log: null
+    lat: '18.813031600863'
+    lon: '-79.249543355636'
+    heading: '283'
+    altitude: '41072.545805172'
+    vs: '0'
+    gs: '425.04687332464'
+    transponder: null
+    autopilot: null
+    fuel_flow: null
+    sim_time: now
+    created_at: 'now'
+    updated_at: 'now'
+  - id: ejRqlxXoZPle
+    pirep_id: b68R5gwVzpVe
+    type: '0'
+    nav_type: null
+    order: '0'
+    name: null
+    log: null
+    lat: '18.840653974635'
+    lon: '-79.370042672541'
+    heading: '283'
+    altitude: '40396.200981621'
+    vs: '-16'
+    gs: '428.08364925851'
+    transponder: null
+    autopilot: null
+    fuel_flow: null
+    sim_time: now
+    created_at: 'now'
+    updated_at: 'now'
+  - id: eVOPBYw4q9Xa
+    pirep_id: b68R5gwVzpVe
+    type: '0'
+    nav_type: null
+    order: '0'
+    name: null
+    log: null
+    lat: '18.868358744495'
+    lon: '-79.491434926253'
+    heading: '283'
+    altitude: '39399.093383161'
+    vs: '-16'
+    gs: '427.57826037174'
+    transponder: null
+    autopilot: null
+    fuel_flow: null
+    sim_time: now
+    created_at: 'now'
+    updated_at: 'now'
+  - id: aOYyrOmVPzEd
+    pirep_id: b68R5gwVzpVe
+    type: '0'
+    nav_type: null
+    order: '0'
+    name: null
+    log: null
+    lat: '18.896191929474'
+    lon: '-79.613169477385'
+    heading: '284'
+    altitude: '36491.730092364'
+    vs: '-55'
+    gs: '429.74732238829'
+    transponder: null
+    autopilot: null
+    fuel_flow: null
+    sim_time: now
+    created_at: 'now'
+    updated_at: 'now'
+  - id: dL98oLQgyzje
+    pirep_id: b68R5gwVzpVe
+    type: '0'
+    nav_type: null
+    order: '0'
+    name: null
+    log: null
+    lat: '18.9242378342'
+    lon: '-79.736368411294'
+    heading: '284'
+    altitude: '32998.644142986'
+    vs: '-61'
+    gs: '434.90864533098'
+    transponder: null
+    autopilot: null
+    fuel_flow: null
+    sim_time: now
+    created_at: 'now'
+    updated_at: 'now'
+  - id: e9rQ5lqD2o8a
+    pirep_id: b68R5gwVzpVe
+    type: '0'
+    nav_type: null
+    order: '0'
+    name: null
+    log: null
+    lat: '18.952608029755'
+    lon: '-79.861339775352'
+    heading: '284'
+    altitude: '29069.168636089'
+    vs: '-68'
+    gs: '441.90475491564'
+    transponder: null
+    autopilot: null
+    fuel_flow: null
+    sim_time: now
+    created_at: 'now'
+    updated_at: 'now'
+  - id: av2oANWY1vma
+    pirep_id: b68R5gwVzpVe
     type: '0'
     nav_type: null
     order: '0'
@@ -36,7 +550,8 @@ acars:
     sim_time: now
     created_at: 'now'
     updated_at: 'now'
-  - pirep_id: b68R5gwVzpVe
+  - id: e1wr82gp8zGb
+    pirep_id: b68R5gwVzpVe
     type: '0'
     nav_type: null
     order: '0'
@@ -54,7 +569,8 @@ acars:
     sim_time: now
     created_at: 'now'
     updated_at: 'now'
-  - pirep_id: b68R5gwVzpVe
+  - id: dG65jDL2gK0b
+    pirep_id: b68R5gwVzpVe
     type: '0'
     nav_type: null
     order: '0'
@@ -72,7 +588,8 @@ acars:
     sim_time: now
     created_at: 'now'
     updated_at: 'now'
-  - pirep_id: b68R5gwVzpVe
+  - id: epYQ0ENmyvXa
+    pirep_id: b68R5gwVzpVe
     type: '0'
     nav_type: null
     order: '0'
@@ -90,7 +607,8 @@ acars:
     sim_time: now
     created_at: 'now'
     updated_at: 'now'
-  - pirep_id: b68R5gwVzpVe
+  - id: erkRwJPrVoEa
+    pirep_id: b68R5gwVzpVe
     type: '0'
     nav_type: null
     order: '0'
@@ -108,7 +626,8 @@ acars:
     sim_time: now
     created_at: 'now'
     updated_at: 'now'
-  - pirep_id: b68R5gwVzpVe
+  - id: e1wr82gZXqZb
+    pirep_id: b68R5gwVzpVe
     type: '0'
     nav_type: null
     order: '0'
@@ -126,7 +645,8 @@ acars:
     sim_time: now
     created_at: 'now'
     updated_at: 'now'
-  - pirep_id: b68R5gwVzpVe
+  - id: eER95AJ4XLga
+    pirep_id: b68R5gwVzpVe
     type: '0'
     nav_type: null
     order: '0'
@@ -144,7 +664,8 @@ acars:
     sim_time: now
     created_at: 'now'
     updated_at: 'now'
-  - pirep_id: b68R5gwVzpVe
+  - id: dPNZvP0O0Gza
+    pirep_id: b68R5gwVzpVe
     type: '0'
     nav_type: null
     order: '0'
@@ -162,7 +683,8 @@ acars:
     sim_time: now
     created_at: 'now'
     updated_at: 'now'
-  - pirep_id: b68R5gwVzpVe
+  - id: aQW0wQYVm2Yd
+    pirep_id: b68R5gwVzpVe
     type: '0'
     nav_type: null
     order: '0'
@@ -180,7 +702,8 @@ acars:
     sim_time: now
     created_at: 'now'
     updated_at: 'now'
-  - pirep_id: b68R5gwVzpVe
+  - id: eXDoE11x32We
+    pirep_id: b68R5gwVzpVe
     type: '0'
     nav_type: null
     order: '0'

app/Database/seeds/settings.yml

@@ -54,13 +54,6 @@
   options: ''
   type: text
   description: 'Enter your Google Analytics Tracking ID'
-- key: general.record_user_ip
-  name: 'Record user IP address'
-  group: general
-  value: true
-  options: ''
-  type: boolean
-  description: Record the user's IP address on register/login
 - key: units.currency
   name: 'Currency'
   group: units
@@ -151,20 +144,6 @@
   options:
   type: text
   description: If an airport's Jet A Fuel Cost isn't added, set this value by default
-- key: airports.default_100ll_fuel_cost
-  name: 'Default 100LL Fuel Cost'
-  group: airports
-  value: 0.9
-  options:
-  type: text
-  description: If an airport's 100LL Fuel Cost isn't added, set this value by default
-- key: airports.default_mogas_fuel_cost
-  name: 'Default MOGAS Fuel Cost'
-  group: airports
-  value: 0.8
-  options:
-  type: text
-  description: If an airport's MOGAS Fuel Cost isn't added, set this value by default
 - key: bids.disable_flight_on_bid
   name: 'Disable flight on bid'
   group: bids
@@ -214,13 +193,13 @@
   options: ''
   type: boolean
   description: 'Only allow briefs to be created for bidded flights'
-- key: simbrief.expire_hours
+- key: simbrief.expire_days
   name: 'Simbrief Expire Time'
   group: simbrief
-  value: 6
+  value: 5
   options: ''
   type: number
-  description: 'Hours after how long to remove unused briefs'
+  description: 'Days after how long to remove unused briefs'
 - key: simbrief.noncharter_pax_weight
   name: 'Non-Charter Passenger Weight'
   group: simbrief
@@ -263,13 +242,6 @@
   options: ''
   type: boolean
   description: 'Use privatized user name as SimBrief OFP captain name'
-- key: simbrief.block_aircraft
-  name: 'Restrict Aircraft'
-  group: simbrief
-  value: false
-  options: ''
-  type: boolean
-  description: 'When enabled, an aircraft can only be used for one active SimBrief OFP and Flight/Pirep'
 - key: pireps.duplicate_check_time
   name: 'PIREP duplicate time check'
   group: pireps
@@ -375,20 +347,20 @@
   options: ''
   type: boolean
   description: 'Count transfer hours in calculations, like ranks and the total hours'
-- key: notifications.discord_public_webhook_url
+- key: notifications.discord_api_key
-  name: Discord Public Webhook URL
+  name: Discord API token
   group: notifications
   value: ''
   options: ''
   type: text
-  description: The Discord Webhook URL for public notifications
+  description: Discord API token for notifications
-- key: notifications.discord_private_webhook_url
+- key: 'notifications.discord_public_channel_id'
-  name: Discord Private Webhook URL
+  name: 'Discord Public Channel ID'
-  group: notifications
+  group: 'notifications'
   value: ''
   options: ''
-  type: text
+  type: 'text'
-  description: The Discord Webhook URL for private notifications
+  description: 'Discord public channel ID for broadcasat notifications'
 - key: 'cron.random_id'
   name: 'Cron Randomized ID'
   group: 'cron'

app/Events/PirepStateChange.php

@@ -1,16 +0,0 @@
-<?php
-
-namespace App\Events;
-
-use App\Contracts\Event;
-use App\Models\Pirep;
-
-class PirepStateChange extends Event
-{
-    public $pirep;
-
-    public function __construct(Pirep $pirep)
-    {
-        $this->pirep = $pirep;
-    }
-}

app/Events/PirepStatusChange.php

@@ -1,19 +0,0 @@
-<?php
-
-namespace App\Events;
-
-use App\Contracts\Event;
-use App\Models\Pirep;
-
-/**
- * Status change like Boarding, Taxi, etc
- */
-class PirepStatusChange extends Event
-{
-    public $pirep;
-
-    public function __construct(Pirep $pirep)
-    {
-        $this->pirep = $pirep;
-    }
-}

app/Exceptions/AircraftNotAvailable.php

@@ -1,38 +0,0 @@
-<?php
-
-namespace App\Exceptions;
-
-use App\Models\Aircraft;
-
-class AircraftNotAvailable extends AbstractHttpException
-{
-    public const MESSAGE = 'The aircraft is not available for flight';
-
-    private $aircraft;
-
-    public function __construct(Aircraft $aircraft)
-    {
-        $this->aircraft = $aircraft;
-        parent::__construct(
-            400,
-            static::MESSAGE
-        );
-    }
-
-    public function getErrorType(): string
-    {
-        return 'aircraft-not-available';
-    }
-
-    public function getErrorDetails(): string
-    {
-        return $this->getMessage();
-    }
-
-    public function getErrorMetadata(): array
-    {
-        return [
-            'aircraft_id' => $this->aircraft->id,
-        ];
-    }
-}

app/Exceptions/PirepError.php

@@ -1,44 +0,0 @@
-<?php
-
-namespace App\Exceptions;
-
-use App\Models\Pirep;
-
-class PirepError extends AbstractHttpException
-{
-    private $pirep;
-    private $error;
-
-    public function __construct(Pirep $pirep, string $error)
-    {
-        $this->error = $error;
-        $this->pirep = $pirep;
-        parent::__construct(400, $error);
-    }
-
-    /**
-     * Return the RFC 7807 error type (without the URL root)
-     */
-    public function getErrorType(): string
-    {
-        return 'pirep-error';
-    }
-
-    /**
-     * Get the detailed error string
-     */
-    public function getErrorDetails(): string
-    {
-        return $this->getMessage();
-    }
-
-    /**
-     * Return an array with the error details, merged with the RFC7807 response
-     */
-    public function getErrorMetadata(): array
-    {
-        return [
-            'pirep_id' => $this->pirep->id,
-        ];
-    }
-}

app/Http/Controllers/Admin/FlightController.php

@@ -152,7 +152,7 @@ class FlightController extends Controller
     {
         return view('admin.flights.create', [
             'flight'        => null,
-            'days'          => 0,
+            'days'          => [],
             'flight_fields' => $this->flightFieldRepo->all(),
             'airlines'      => $this->airlineRepo->selectBoxList(),
             'airports'      => $this->airportRepo->selectBoxList(true, false),

app/Http/Controllers/Admin/MaintenanceController.php

@@ -7,24 +7,29 @@ use App\Repositories\KvpRepository;
 use App\Services\CronService;
 use App\Services\VersionService;
 use App\Support\Utils;
+use Codedge\Updater\UpdaterManager;
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Artisan;
 use Illuminate\Support\Facades\Log;
 use Laracasts\Flash\Flash;
+use Nwidart\Modules\Facades\Module;
 
 class MaintenanceController extends Controller
 {
     private $cronSvc;
     private $kvpRepo;
+    private $updateManager;
     private $versionSvc;
 
     public function __construct(
         CronService $cronSvc,
         KvpRepository $kvpRepo,
+        UpdaterManager $updateManager,
         VersionService $versionSvc
     ) {
         $this->cronSvc = $cronSvc;
         $this->kvpRepo = $kvpRepo;
+        $this->updateManager = $updateManager;
         $this->versionSvc = $versionSvc;
     }
 
@@ -101,6 +106,24 @@ class MaintenanceController extends Controller
         return redirect(route('admin.maintenance.index'));
     }
 
+    /**
+     * Update the phpVMS install
+     *
+     * @param \Illuminate\Http\Request $request
+     *
+     * @return mixed
+     */
+    public function update(Request $request)
+    {
+        $new_version_tag = $this->kvpRepo->get('latest_version_tag');
+        Log::info('Attempting to update to '.$new_version_tag);
+
+        $module = Module::find('updater');
+        $module->enable();
+
+        return redirect('/update/downloader');
+    }
+
     /**
      * Enable the cron, or if it's enabled, change the ID that is used
      *

app/Http/Controllers/Admin/PirepController.php

@@ -100,7 +100,7 @@ class PirepController extends Controller
                 $tmp[$ac->id] = $ac['name'].' - '.$ac['registration'];
             }
 
-            $aircraft[$subfleet->type] = $tmp;
+            $aircraft[$subfleet->name] = $tmp;
         }
 
         return $aircraft;

app/Http/Controllers/Admin/UserController.php

@@ -6,12 +6,12 @@ use App\Contracts\Controller;
 use App\Http\Requests\CreateUserRequest;
 use App\Http\Requests\UpdateUserRequest;
 use App\Models\Rank;
+use App\Models\Role;
 use App\Models\User;
 use App\Models\UserAward;
 use App\Repositories\AirlineRepository;
 use App\Repositories\AirportRepository;
 use App\Repositories\PirepRepository;
-use App\Repositories\RoleRepository;
 use App\Repositories\UserRepository;
 use App\Services\UserService;
 use App\Support\Timezonelist;
@@ -29,7 +29,6 @@ class UserController extends Controller
     private $airlineRepo;
     private $airportRepo;
     private $pirepRepo;
-    private $roleRepo;
     private $userRepo;
     private $userSvc;
 
@@ -39,7 +38,6 @@ class UserController extends Controller
      * @param AirlineRepository $airlineRepo
      * @param AirportRepository $airportRepo
      * @param PirepRepository   $pirepRepo
-     * @param RoleRepository    $roleRepo
      * @param UserRepository    $userRepo
      * @param UserService       $userSvc
      */
@@ -47,14 +45,12 @@ class UserController extends Controller
         AirlineRepository $airlineRepo,
         AirportRepository $airportRepo,
         PirepRepository $pirepRepo,
-        RoleRepository $roleRepo,
         UserRepository $userRepo,
         UserService $userSvc
     ) {
         $this->airlineRepo = $airlineRepo;
         $this->airportRepo = $airportRepo;
         $this->pirepRepo = $pirepRepo;
-        $this->roleRepo = $roleRepo;
         $this->userSvc = $userSvc;
         $this->userRepo = $userRepo;
     }
@@ -92,7 +88,6 @@ class UserController extends Controller
             ->mapWithKeys(function ($item, $key) {
                 return [strtolower($item['alpha2']) => $item['name']];
             });
-        $roles = $this->roleRepo->selectBoxList(false, true);
 
         return view('admin.users.create', [
             'user'      => null,
@@ -103,7 +98,7 @@ class UserController extends Controller
             'countries' => $countries,
             'airports'  => $airports,
             'ranks'     => Rank::all()->pluck('name', 'id'),
-            'roles'     => $roles,
+            'roles'     => Role::all()->pluck('name', 'id'),
         ]);
     }
 
@@ -168,7 +163,6 @@ class UserController extends Controller
 
         $airlines = $this->airlineRepo->selectBoxList();
         $airports = $this->airportRepo->selectBoxList(false);
-        $roles = $this->roleRepo->selectBoxList(false, true);
 
         return view('admin.users.edit', [
             'user'      => $user,
@@ -179,7 +173,7 @@ class UserController extends Controller
             'airports'  => $airports,
             'airlines'  => $airlines,
             'ranks'     => Rank::all()->pluck('name', 'id'),
-            'roles'     => $roles,
+            'roles'     => Role::all()->pluck('name', 'id'),
         ]);
     }
 

app/Http/Controllers/Api/AirlineController.php

@@ -16,8 +16,9 @@ class AirlineController extends Controller
      *
      * @param AirlineRepository $airlineRepo
      */
-    public function __construct(AirlineRepository $airlineRepo)
+    public function __construct(
-    {
+        AirlineRepository $airlineRepo
+    ) {
         $this->airlineRepo = $airlineRepo;
     }
 
@@ -30,7 +31,9 @@ class AirlineController extends Controller
      */
     public function index(Request $request)
     {
-        $airports = $this->airlineRepo->whereOrder(['active' => true], 'name')->get();
+        $airports = $this->airlineRepo
+            ->whereOrder(['active' => true], 'name', 'asc')
+            ->paginate();
 
         return AirlineResource::collection($airports);
     }

app/Http/Controllers/Api/PirepController.php

@@ -23,10 +23,10 @@ use App\Models\Enums\PirepFieldSource;
 use App\Models\Enums\PirepSource;
 use App\Models\Pirep;
 use App\Models\PirepComment;
-use App\Models\PirepFare;
+use App\Repositories\AcarsRepository;
-use App\Models\PirepFieldValue;
 use App\Repositories\JournalRepository;
 use App\Repositories\PirepRepository;
+use App\Services\FareService;
 use App\Services\Finance\PirepFinanceService;
 use App\Services\PirepService;
 use App\Services\UserService;
@@ -37,6 +37,8 @@ use Illuminate\Support\Facades\Log;
 
 class PirepController extends Controller
 {
+    private $acarsRepo;
+    private $fareSvc;
     private $financeSvc;
     private $journalRepo;
     private $pirepRepo;
@@ -44,6 +46,8 @@ class PirepController extends Controller
     private $userSvc;
 
     /**
+     * @param AcarsRepository     $acarsRepo
+     * @param FareService         $fareSvc
      * @param PirepFinanceService $financeSvc
      * @param JournalRepository   $journalRepo
      * @param PirepRepository     $pirepRepo
@@ -51,12 +55,16 @@ class PirepController extends Controller
      * @param UserService         $userSvc
      */
     public function __construct(
+        AcarsRepository $acarsRepo,
+        FareService $fareSvc,
         PirepFinanceService $financeSvc,
         JournalRepository $journalRepo,
         PirepRepository $pirepRepo,
         PirepService $pirepSvc,
         UserService $userSvc
     ) {
+        $this->acarsRepo = $acarsRepo;
+        $this->fareSvc = $fareSvc;
         $this->financeSvc = $financeSvc;
         $this->journalRepo = $journalRepo;
         $this->pirepRepo = $pirepRepo;
@@ -93,7 +101,7 @@ class PirepController extends Controller
     /**
      * Check if a PIREP is cancelled
      *
-     * @param Pirep $pirep
+     * @param $pirep
      *
      * @throws \App\Exceptions\PirepCancelled
      */
@@ -105,52 +113,50 @@ class PirepController extends Controller
     }
 
     /**
+     * @param         $pirep
      * @param Request $request
-     *
-     * @return PirepFieldValue[]
      */
-    protected function getFields(Request $request): ?array
+    protected function updateFields($pirep, Request $request)
     {
         if (!$request->filled('fields')) {
-            return [];
+            return;
         }
 
         $pirep_fields = [];
         foreach ($request->input('fields') as $field_name => $field_value) {
-            $pirep_fields[] = new PirepFieldValue([
+            $pirep_fields[] = [
                 'name'   => $field_name,
                 'value'  => $field_value,
                 'source' => PirepFieldSource::ACARS,
-            ]);
+            ];
         }
 
-        return $pirep_fields;
+        $this->pirepSvc->updateCustomFields($pirep->id, $pirep_fields);
     }
 
     /**
      * Save the fares
      *
+     * @param         $pirep
      * @param Request $request
      *
      * @throws \Exception
-     *
-     * @return PirepFare[]
      */
-    protected function getFares(Request $request): ?array
+    protected function updateFares($pirep, Request $request)
     {
         if (!$request->filled('fares')) {
-            return [];
+            return;
         }
 
         $fares = [];
         foreach ($request->post('fares') as $fare) {
-            $fares[] = new PirepFare([
+            $fares[] = [
                 'fare_id' => $fare['id'],
                 'count'   => $fare['count'],
-            ]);
+            ];
         }
 
-        return $fares;
+        $this->fareSvc->saveForPirep($pirep, $fares);
     }
 
     /**
@@ -167,7 +173,6 @@ class PirepController extends Controller
             'comments',
             'flight',
             'simbrief',
-            'position',
             'user',
         ];
 
@@ -205,13 +210,14 @@ class PirepController extends Controller
         $attrs = $this->parsePirep($request);
         $attrs['source'] = PirepSource::ACARS;
 
-        $fields = $this->getFields($request);
+        $pirep = $this->pirepSvc->prefile($user, $attrs);
-        $fares = $this->getFares($request);
-        $pirep = $this->pirepSvc->prefile($user, $attrs, $fields, $fares);
 
         Log::info('PIREP PREFILED');
         Log::info($pirep->id);
 
+        $this->updateFields($pirep, $request);
+        $this->updateFares($pirep, $request);
+
         return $this->get($pirep->id);
     }
 
@@ -252,9 +258,9 @@ class PirepController extends Controller
             }
         }
 
-        $fields = $this->getFields($request);
+        $pirep = $this->pirepRepo->update($attrs, $pirep_id);
-        $fares = $this->getFares($request);
+        $this->updateFields($pirep, $request);
-        $pirep = $this->pirepSvc->update($pirep_id, $attrs, $fields, $fares);
+        $this->updateFares($pirep, $request);
 
         event(new PirepUpdated($pirep));
 
@@ -297,13 +303,11 @@ class PirepController extends Controller
         }
 
         try {
-            $fields = $this->getFields($request);
+            $pirep = $this->pirepSvc->file($pirep, $attrs);
-            $fares = $this->getFares($request);
+            $this->updateFields($pirep, $request);
-            $pirep = $this->pirepSvc->file($pirep, $attrs, $fields, $fares);
+            $this->updateFares($pirep, $request);
         } catch (\Exception $e) {
             Log::error($e);
-
-            throw $e;
         }
 
         // See if there there is any route data posted
@@ -405,8 +409,7 @@ class PirepController extends Controller
         $pirep = Pirep::find($pirep_id);
         $this->checkCancelled($pirep);
 
-        $fields = $this->getFields($request);
+        $this->updateFields($pirep, $request);
-        $this->pirepSvc->updateCustomFields($pirep_id, $fields);
 
         return new PirepFieldCollection($pirep->fields);
     }

app/Http/Controllers/Auth/LoginController.php

@@ -5,7 +5,6 @@ namespace App\Http\Controllers\Auth;
 use App\Contracts\Controller;
 use App\Exceptions\PilotIdNotFound;
 use App\Models\Enums\UserState;
-use App\Models\User;
 use App\Services\UserService;
 use Illuminate\Foundation\Auth\AuthenticatesUsers;
 use Illuminate\Http\Request;
@@ -105,16 +104,14 @@ class LoginController extends Controller
      */
     protected function sendLoginResponse(Request $request)
     {
-        /** @var User $user */
         $user = Auth::user();
 
-        if (setting('general.record_user_ip', true)) {
         $user->last_ip = $request->ip();
         $user->save();
-        }
 
         if ($user->state !== UserState::ACTIVE && $user->state !== UserState::ON_LEAVE) {
-            Log::info('Trying to login '.$user->ident.', state '.UserState::label($user->state));
+            Log::info('Trying to login '.$user->ident.', state '
+                .UserState::label($user->state));
 
             // Log them out
             $this->guard()->logout();

app/Http/Controllers/Auth/RegisterController.php

@@ -119,16 +119,11 @@ class RegisterController extends Controller
      *
      * @return User
      */
-    protected function create(Request $request): User
+    protected function create(array $opts)
     {
         // Default options
-        $opts = $request->all();
         $opts['password'] = Hash::make($opts['password']);
 
-        if (setting('general.record_user_ip', true)) {
-            $opts['last_ip'] = $request->ip();
-        }
-
         // Convert transfer hours into minutes
         if (isset($opts['transfer_time'])) {
             $opts['transfer_time'] *= 60;
@@ -163,7 +158,7 @@ class RegisterController extends Controller
     {
         $this->validator($request->all())->validate();
 
-        $user = $this->create($request);
+        $user = $this->create($request->all());
         if ($user->state === UserState::PENDING) {
             return view('auth.pending');
         }

app/Http/Controllers/Frontend/AirportController.php

@@ -36,8 +36,8 @@ class AirportController extends Controller
     {
         $id = strtoupper($id);
 
-        $airport = $this->airportRepo->where('id', $id)->first();
+        $airport = $this->airportRepo->find($id);
-        if (!$airport) {
+        if (empty($airport)) {
             Flash::error('Airport not found!');
             return redirect(route('frontend.dashboard.index'));
         }
@@ -46,14 +46,12 @@ class AirportController extends Controller
             ->with(['dpt_airport', 'arr_airport', 'airline'])
             ->findWhere([
                 'arr_airport_id' => $id,
-                'active'         => 1,
             ])->all();
 
         $outbound_flights = $this->flightRepo
             ->with(['dpt_airport', 'arr_airport', 'airline'])
             ->findWhere([
                 'dpt_airport_id' => $id,
-                'active'         => 1,
             ])->all();
 
         return view('airports.show', [

app/Http/Controllers/Frontend/FlightController.php

@@ -5,7 +5,6 @@ namespace App\Http\Controllers\Frontend;
 use App\Contracts\Controller;
 use App\Models\Bid;
 use App\Models\Enums\FlightType;
-use App\Models\Flight;
 use App\Repositories\AirlineRepository;
 use App\Repositories\AirportRepository;
 use App\Repositories\Criteria\WhereCriteria;
@@ -106,15 +105,6 @@ class FlightController extends Controller
             Log::emergency($e);
         }
 
-        // Get only used Flight Types for the search form
-        // And filter according to settings
-        $usedtypes = Flight::select('flight_type')->where($where)->groupby('flight_type')->orderby('flight_type', 'asc')->get();
-        // Build collection with type codes and labels
-        $flight_types = collect('', '');
-        foreach ($usedtypes as $ftype) {
-            $flight_types->put($ftype->flight_type, FlightType::label($ftype->flight_type));
-        }
-
         $flights = $this->flightRepo->searchCriteria($request)
             ->with([
                 'dpt_airport',
@@ -138,7 +128,7 @@ class FlightController extends Controller
             'saved'         => $saved_flights,
             'subfleets'     => $this->subfleetRepo->selectBoxList(true),
             'flight_number' => $request->input('flight_number'),
-            'flight_types'  => $flight_types,
+            'flight_types'  => FlightType::select(true),
             'flight_type'   => $request->input('flight_type'),
             'arr_icao'      => $request->input('arr_icao'),
             'dep_icao'      => $request->input('dep_icao'),

app/Http/Controllers/Frontend/HomeController.php

@@ -3,7 +3,6 @@
 namespace App\Http\Controllers\Frontend;
 
 use App\Contracts\Controller;
-use App\Models\Enums\UserState;
 use App\Models\User;
 use Illuminate\Database\QueryException;
 use Illuminate\Support\Facades\Log;
@@ -16,7 +15,7 @@ class HomeController extends Controller
     public function index()
     {
         try {
-            $users = User::where('state', '!=', UserState::DELETED)->orderBy('created_at', 'desc')->take(4)->get();
+            $users = User::orderBy('created_at', 'desc')->take(4)->get();
         } catch (\PDOException $e) {
             Log::emergency($e);
             return view('system/errors/database_error', [

app/Http/Controllers/Frontend/PirepController.php

@@ -9,7 +9,6 @@ use App\Models\Enums\PirepSource;
 use App\Models\Enums\PirepState;
 use App\Models\Fare;
 use App\Models\Pirep;
-use App\Models\PirepFare;
 use App\Models\SimBrief;
 use App\Models\User;
 use App\Repositories\AircraftRepository;
@@ -104,7 +103,7 @@ class PirepController extends Controller
                 $tmp[$ac->id] = $ac['name'].' - '.$ac['registration'];
             }
 
-            $aircraft[$subfleet->type] = $tmp;
+            $aircraft[$subfleet->name] = $tmp;
         }
 
         return $aircraft;
@@ -113,18 +112,19 @@ class PirepController extends Controller
     /**
      * Save any custom fields found
      *
+     * @param Pirep   $pirep
      * @param Request $request
      */
-    protected function saveCustomFields(Request $request): array
+    protected function saveCustomFields(Pirep $pirep, Request $request)
     {
-        $fields = [];
+        $custom_fields = [];
         $pirep_fields = $this->pirepFieldRepo->all();
         foreach ($pirep_fields as $field) {
             if (!$request->filled($field->slug)) {
                 continue;
             }
 
-            $fields[] = [
+            $custom_fields[] = [
                 'name'   => $field->name,
                 'slug'   => $field->slug,
                 'value'  => $request->input($field->slug),
@@ -132,9 +132,8 @@ class PirepController extends Controller
             ];
         }
 
-        Log::info('PIREP Custom Fields', $fields);
+        Log::info('PIREP Custom Fields', $custom_fields);
-
+        $this->pirepSvc->updateCustomFields($pirep->id, $custom_fields);
-        return $fields;
     }
 
     /**
@@ -160,10 +159,10 @@ class PirepController extends Controller
                 $count = $request->input($field_name);
             }
 
-            $fares[] = new PirepFare([
+            $fares[] = [
                 'fare_id' => $fare->id,
                 'count'   => $count,
-            ]);
+            ];
         }
 
         $this->fareSvc->saveForPirep($pirep, $fares);
@@ -390,8 +389,8 @@ class PirepController extends Controller
         $attrs['submitted_at'] = Carbon::now('UTC');
         $pirep->submitted_at = Carbon::now('UTC');
 
-        $fields = $this->saveCustomFields($request);
+        $pirep = $this->pirepSvc->create($pirep);
-        $pirep = $this->pirepSvc->create($pirep, $fields);
+        $this->saveCustomFields($pirep, $request);
         $this->saveFares($pirep, $request);
         $this->pirepSvc->saveRoute($pirep);
 
@@ -400,15 +399,9 @@ class PirepController extends Controller
             if ($brief !== null) {
                 /** @var SimBriefService $sbSvc */
                 $sbSvc = app(SimBriefService::class);
-                // Keep the flight_id with SimBrief depending on the button selected
-                // Save = Keep the flight_id , Submit = Remove the flight_id
-                if ($attrs['submit'] === 'save') {
-                    $sbSvc->attachSimbriefToPirep($pirep, $brief, true);
-                } elseif ($attrs['submit'] === 'submit') {
                 $sbSvc->attachSimbriefToPirep($pirep, $brief);
             }
         }
-        }
 
         // Depending on the button they selected, set an initial state
         // Can be saved as a draft or just submitted
@@ -532,8 +525,7 @@ class PirepController extends Controller
             $this->pirepSvc->saveRoute($pirep);
         }
 
-        $fields = $this->saveCustomFields($request);
+        $this->saveCustomFields($pirep, $request);
-        $this->pirepSvc->updateCustomFields($pirep->id, $fields);
         $this->saveFares($pirep, $request);
 
         if ($attrs['submit'] === 'save') {

app/Http/Controllers/Frontend/ProfileController.php

@@ -10,7 +10,6 @@ use App\Repositories\AirlineRepository;
 use App\Repositories\AirportRepository;
 use App\Repositories\UserRepository;
 use App\Support\Countries;
-use App\Support\Discord;
 use App\Support\Timezonelist;
 use App\Support\Utils;
 use Illuminate\Http\Request;
@@ -182,16 +181,6 @@ class ProfileController extends Controller
             Storage::delete($user->avatar);
         }
 
-        // Find out the user's private channel id
-        /*
-        // TODO: Uncomment when Discord API functionality is enabled
-        if ($request->filled('discord_id')) {
-            $discord_id = $request->post('discord_id');
-            if ($discord_id !== $user->discord_id) {
-                $req_data['discord_private_channel_id'] = Discord::getPrivateChannelId($discord_id);
-            }
-        }*/
-
         if ($request->hasFile('avatar')) {
             $avatar = $request->file('avatar');
             $file_name = $user->ident.'.'.$avatar->getClientOriginalExtension();

app/Http/Controllers/Frontend/SimBriefController.php

@@ -70,9 +70,6 @@ class SimBriefController
             return redirect(route('frontend.flights.index'));
         }
 
-        // Generate SimBrief Static ID
-        $static_id = $user->ident.'_'.$flight->id;
-
         // No aircraft selected, show selection form
         if (!$aircraft_id) {
             // If no subfleets defined for flight get them from user
@@ -103,13 +100,6 @@ class SimBriefController
                 $aircrafts = $aircrafts->where('airport_id', $flight->dpt_airport_id);
             }
 
-            if (setting('simbrief.block_aircraft')) {
-                // Build a list of aircraft_id's being used for active sb packs
-                $sb_aircraft = SimBrief::whereNotNull('flight_id')->pluck('aircraft_id');
-                // Filter aircraft list to non used/blocked ones
-                $aircrafts = $aircrafts->whereNotIn('id', $sb_aircraft);
-            }
-
             return view('flights.simbrief_aircraft', [
                 'flight'    => $flight,
                 'aircrafts' => $aircrafts,
@@ -240,7 +230,6 @@ class SimBriefController
             'tpayload'         => $tpayload,
             'tcargoload'       => $tcargoload,
             'loaddist'         => implode(' ', $loaddist),
-            'static_id'        => $static_id,
         ]);
     }
 
@@ -371,31 +360,6 @@ class SimBriefController
         ]);
     }
 
-    /**
-     * Get the latest generated OFP. Pass in two additional items, the Simbrief userid and static_id
-     * This will get the latest edited/regenerated of from Simbrief and update our records
-     * We do not need to send the fares again, so used an empty array
-     */
-    public function update_ofp(Request $request)
-    {
-        /** @var User $user */
-        $user = Auth::user();
-        $ofp_id = $request->input('ofp_id');
-        $flight_id = $request->input('flight_id');
-        $aircraft_id = $request->input('aircraft_id');
-        $sb_userid = $request->input('sb_userid');
-        $sb_static_id = $request->input('sb_static_id');
-        $fares = [];
-
-        $simbrief = $this->simBriefSvc->downloadOfp($user->id, $ofp_id, $flight_id, $aircraft_id, $fares, $sb_userid, $sb_static_id);
-        if ($simbrief === null) {
-            $error = new AssetNotFound(new Exception('Simbrief OFP not found'));
-            return $error->getResponse();
-        }
-
-        return redirect(route('frontend.simbrief.briefing', [$ofp_id]));
-    }
-
     /**
      * Generate the API code
      *

app/Http/Controllers/System/InstallerController.php

@@ -25,6 +25,7 @@ use Illuminate\Support\Facades\Log;
 use Illuminate\Support\Facades\Validator;
 use Illuminate\View\View;
 use function in_array;
+use Laracasts\Flash\Flash;
 use RuntimeException;
 
 class InstallerController extends Controller

app/Http/Controllers/System/UpdateController.php

@@ -3,32 +3,49 @@
 namespace App\Http\Controllers\System;
 
 use App\Contracts\Controller;
+use App\Repositories\KvpRepository;
+use App\Services\AnalyticsService;
 use App\Services\Installer\InstallerService;
 use App\Services\Installer\MigrationService;
 use App\Services\Installer\SeederService;
+use Codedge\Updater\UpdaterManager;
 use function count;
+use Illuminate\Contracts\View\Factory;
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Log;
+use Illuminate\View\View;
 
 class UpdateController extends Controller
 {
+    private $analyticsSvc;
     private $installerSvc;
+    private $kvpRepo;
     private $migrationSvc;
     private $seederSvc;
+    private $updateManager;
 
     /**
+     * @param AnalyticsService $analyticsSvc
      * @param InstallerService $installerSvc
+     * @param KvpRepository    $kvpRepo
      * @param MigrationService $migrationSvc
      * @param SeederService    $seederSvc
+     * @param UpdaterManager   $updateManager
      */
     public function __construct(
+        AnalyticsService $analyticsSvc,
         InstallerService $installerSvc,
+        KvpRepository $kvpRepo,
         MigrationService $migrationSvc,
-        SeederService $seederSvc
+        SeederService $seederSvc,
+        UpdaterManager $updateManager
     ) {
+        $this->analyticsSvc = $analyticsSvc;
         $this->migrationSvc = $migrationSvc;
         $this->seederSvc = $seederSvc;
         $this->installerSvc = $installerSvc;
+        $this->kvpRepo = $kvpRepo;
+        $this->updateManager = $updateManager;
     }
 
     /**
@@ -90,4 +107,38 @@ class UpdateController extends Controller
     {
         return redirect('/admin');
     }
+
+    /**
+     * Show the update page with the latest version
+     *
+     * @return Factory|View
+     */
+    public function updater()
+    {
+        $version = $this->kvpRepo->get('latest_version_tag');
+
+        return view('system.updater.downloader/downloader', [
+            'version' => $version,
+        ]);
+    }
+
+    /**
+     * Download the actual update and then forward the user to the updater page
+     *
+     * @return mixed
+     */
+    public function update_download()
+    {
+        $version = $this->kvpRepo->get('latest_version_tag');
+        if (empty($version)) {
+            return view('system.updater.steps.step1-no-update');
+        }
+
+        $release = $this->updateManager->source('github')->fetch($version);
+        $this->updateManager->source('github')->update($release);
+        $this->analyticsSvc->sendUpdate();
+
+        Log::info('Update completed to '.$version.', redirecting');
+        return redirect('/update');
+    }
 }

app/Http/Middleware/ApiAuth.php

@@ -50,9 +50,6 @@ class ApiAuth implements Middleware
             return $user;
         });
 
-        // Force english locale for API
-        app()->setLocale('en');
-
         return $next($request);
     }
 

app/Http/Middleware/JsonResponse.php

@@ -15,7 +15,6 @@ class JsonResponse implements Middleware
     {
         $response = $next($request);
         $response->headers->set('Content-Type', 'application/json');
-        $response->headers->set('charset', 'utf-8');
 
         return $response;
     }

app/Http/Requests/Acars/FileRequest.php

@@ -19,7 +19,7 @@ class FileRequest extends FormRequest
         return [
             'distance'            => 'required|numeric',
             'flight_time'         => 'required|integer',
-            'fuel_used'           => 'sometimes|numeric',
+            'fuel_used'           => 'required|numeric',
             'block_time'          => 'sometimes|integer',
             'airline_id'          => 'sometimes|exists:airlines,id',
             'aircraft_id'         => 'sometimes|exists:aircraft,id',

app/Http/Resources/News.php

@@ -18,7 +18,7 @@ class News extends Resource
         $res = parent::toArray($request);
         $res['user'] = [
             'id'   => $this->user->id,
-            'name' => $this->user->name_private,
+            'name' => $this->user->name,
         ];
 
         return $res;

app/Listeners/MessageLoggedListener.php

@@ -1,22 +0,0 @@
-<?php
-
-namespace App\Listeners;
-
-use Illuminate\Log\Events\MessageLogged;
-use Symfony\Component\Console\Output\ConsoleOutput;
-
-/**
- * Show logs in the console
- *
- * https://stackoverflow.com/questions/48264479/log-laravel-with-artisan-output
- */
-class MessageLoggedListener
-{
-    public function handle(MessageLogged $event)
-    {
-        if (app()->runningInConsole() && app()->environment() !== 'testing') {
-            $output = new ConsoleOutput();
-            $output->writeln("<$event->level>$event->message</$event->level>");
-        }
-    }
-}

app/Listeners/PirepEventsHandler.php

@@ -6,7 +6,10 @@ use App\Contracts\Listener;
 use App\Events\PirepPrefiled;
 
 /**
- * Handler for PIREP events
+ * Look for and run any of the award classes. Don't modify this.
+ * See the documentation on creating awards:
+ *
+ * @url http://docs.phpvms.net/customizing/awards
  */
 class PirepEventsHandler extends Listener
 {

app/Models/Aircraft.php

@@ -12,7 +12,6 @@ use Carbon\Carbon;
  * @property int      id
  * @property mixed    subfleet_id
  * @property string   airport_id   The apt where the aircraft is
- * @property string   ident
  * @property string   name
  * @property string   icao
  * @property string   registration
@@ -72,14 +71,6 @@ class Aircraft extends Model
         'zfw'          => 'nullable|numeric',
     ];
 
-    /**
-     * @return string
-     */
-    public function getIdentAttribute(): string
-    {
-        return $this->registration.' ('.$this->icao.')';
-    }
-
     /**
      * See if this aircraft is active
      *

app/Models/Airline.php

@@ -6,7 +6,6 @@ use App\Contracts\Model;
 use App\Models\Enums\JournalType;
 use App\Models\Traits\FilesTrait;
 use App\Models\Traits\JournalTrait;
-use Illuminate\Support\Str;
 
 /**
  * Class Airline
@@ -85,7 +84,7 @@ class Airline extends Model
      */
     public function setIataAttribute($iata)
     {
-        $this->attributes['iata'] = Str::upper($iata);
+        $this->attributes['iata'] = strtoupper($iata);
     }
 
     /**
@@ -95,7 +94,7 @@ class Airline extends Model
      */
     public function setIcaoAttribute($icao): void
     {
-        $this->attributes['icao'] = Str::upper($icao);
+        $this->attributes['icao'] = strtoupper($icao);
     }
 
     public function subfleets()

app/Models/Enums/Days.php

@@ -77,7 +77,7 @@ class Days extends Enum
      */
     public static function in($mask, $day): bool
     {
-        return in_mask($mask, $day);
+        return ($mask & $day) === $day;
     }
 
     /**

app/Models/Enums/PirepStatus.php

@@ -33,7 +33,7 @@ class PirepStatus extends Enum
     public const LANDED = 'LAN';
     public const ARRIVED = 'ONB'; // On block
     public const CANCELLED = 'DX';
-    public const EMERG_DESCENT = 'EMG';
+    public const EMERG_DECENT = 'EMG';
 
     protected static $labels = [
         self::INITIATED     => 'pireps.status.initialized',
@@ -58,6 +58,6 @@ class PirepStatus extends Enum
         self::LANDED        => 'pireps.status.landed',
         self::ARRIVED       => 'pireps.status.arrived',
         self::CANCELLED     => 'pireps.status.cancelled',
-        self::EMERG_DESCENT => 'pireps.status.emerg_decent',
+        self::EMERG_DECENT  => 'pireps.status.emerg_decent',
     ];
 }

app/Models/Expense.php

@@ -13,7 +13,6 @@ use App\Models\Traits\ReferenceTrait;
  * @property string flight_type
  * @property string ref_model
  * @property string ref_model_id
- * @property bool   charge_to_user
  *
  * @mixin \Illuminate\Database\Eloquent\Builder
  */
@@ -37,7 +36,7 @@ class Expense extends Model
     ];
 
     public static $rules = [
-        'active'         => 'bool',
+        'active'         => 'boolean',
         'airline_id'     => 'integer',
         'amount'         => 'float',
         'multiplier'     => 'bool',

app/Models/News.php

@@ -3,19 +3,13 @@
 namespace App\Models;
 
 use App\Contracts\Model;
-use Illuminate\Notifications\Notifiable;
 
 /**
- * @property int       id
- * @property int|mixed user_id
  * @property string subject
  * @property string body
- * @property User      user
  */
 class News extends Model
 {
-    use Notifiable;
-
     public $table = 'news';
 
     protected $fillable = [

app/Models/Pirep.php

@@ -3,8 +3,6 @@
 namespace App\Models;
 
 use App\Contracts\Model;
-use App\Events\PirepStateChange;
-use App\Events\PirepStatusChange;
 use App\Models\Enums\AcarsType;
 use App\Models\Enums\PirepFieldSource;
 use App\Models\Enums\PirepState;
@@ -12,9 +10,7 @@ use App\Models\Traits\HashIdTrait;
 use App\Support\Units\Distance;
 use App\Support\Units\Fuel;
 use Carbon\Carbon;
-use Illuminate\Notifications\Notifiable;
 use Illuminate\Support\Collection;
-use Kleemans\AttributeEvents;
 
 /**
  * @property string      id
@@ -48,9 +44,8 @@ use Kleemans\AttributeEvents;
  * @property Flight|null flight
  * @property Collection  fields
  * @property string      status
- * @property int         state
+ * @property bool        state
- * @property int         source
+ * @property string      source
- * @property string      source_name
  * @property Carbon      submitted_at
  * @property Carbon      created_at
  * @property Carbon      updated_at
@@ -61,9 +56,7 @@ use Kleemans\AttributeEvents;
  */
 class Pirep extends Model
 {
-    use AttributeEvents;
     use HashIdTrait;
-    use Notifiable;
 
     public $table = 'pireps';
 
@@ -143,14 +136,6 @@ class Pirep extends Model
         'route'          => 'nullable',
     ];
 
-    /**
-     * Auto-dispatch events for lifecycle state changes
-     */
-    protected $dispatchesEvents = [
-        'status:*' => PirepStatusChange::class,
-        'state:*'  => PirepStateChange::class,
-    ];
-
     /*
      * If a PIREP is in these states, then it can't be changed.
      */

app/Models/PirepFieldValue.php

@@ -11,7 +11,6 @@ use App\Models\Enums\PirepFieldSource;
  * @property string slug
  * @property string value
  * @property string source
- * @property Pirep  pirep
  *
  * @method static updateOrCreate(array $array, array $array1)
  */

app/Models/Subfleet.php

@@ -20,7 +20,6 @@ use App\Models\Traits\FilesTrait;
  * @property float   cost_delay_minute
  * @property Airline airline
  * @property Airport hub
- * @property int     fuel_type
  */
 class Subfleet extends Model
 {

app/Models/User.php

@@ -3,6 +3,7 @@
 namespace App\Models;
 
 use App\Models\Enums\JournalType;
+use App\Models\Enums\PirepState;
 use App\Models\Traits\JournalTrait;
 use Illuminate\Foundation\Auth\User as Authenticatable;
 use Illuminate\Notifications\Notifiable;
@@ -32,11 +33,8 @@ use Laratrust\Traits\LaratrustUserTrait;
  * @property Rank             rank
  * @property Journal          journal
  * @property int              rank_id
- * @property string           discord_id
  * @property int              state
- * @property string           last_ip
  * @property bool             opt_in
- * @property Pirep[]          pireps
  * @property string           last_pirep_id
  * @property Pirep            last_pirep
  * @property UserFieldValue[] fields
@@ -68,8 +66,6 @@ class User extends Authenticatable
         'pilot_id',
         'airline_id',
         'rank_id',
-        'discord_id',
-        'discord_private_channel_id',
         'api_key',
         'country',
         'home_airport_id',
@@ -84,7 +80,6 @@ class User extends Authenticatable
         'status',
         'toc_accepted',
         'opt_in',
-        'last_ip',
         'created_at',
         'updated_at',
     ];
@@ -94,9 +89,7 @@ class User extends Authenticatable
      */
     protected $hidden = [
         'api_key',
-        'discord_id',
         'password',
-        'last_ip',
         'remember_token',
     ];
 
@@ -258,7 +251,8 @@ class User extends Authenticatable
 
     public function pireps()
     {
-        return $this->hasMany(Pirep::class, 'user_id');
+        return $this->hasMany(Pirep::class, 'user_id')
+            ->where('state', '!=', PirepState::CANCELLED);
     }
 
     public function rank()

app/Notifications/Channels/Discord/DiscordMessage.php

@@ -1,145 +0,0 @@
-<?php
-
-namespace App\Notifications\Channels\Discord;
-
-use Carbon\Carbon;
-
-/**
- * Original is from https://gist.github.com/freekmurze/e4415090f650e070d3de8b905875cf78
- *
- * Markdown guide: https://birdie0.github.io/discord-webhooks-guide/other/discord_markdown.html
- */
-class DiscordMessage
-{
-    const COLOR_SUCCESS = '#0B6623';
-    const COLOR_WARNING = '#FD6A02';
-    const COLOR_ERROR = '#ED2939';
-
-    public $webhook_url;
-
-    protected $title;
-    protected $url;
-    protected $description;
-    protected $timestamp;
-    protected $footer;
-    protected $color;
-    protected $author = [];
-    protected $fields = [];
-
-    /**
-     * Supply the webhook URL that this should be going to
-     */
-    public function webhook(string $url): self
-    {
-        $this->webhook_url = $url;
-        return $this;
-    }
-
-    /**
-     * Title of the notification
-     */
-    public function title(string $title): self
-    {
-        $this->title = $title;
-        return $this;
-    }
-
-    public function url(string $url): self
-    {
-        $this->url = $url;
-        return $this;
-    }
-
-    /**
-     * @param array|string $descriptionLines
-     */
-    public function description($descriptionLines): self
-    {
-        if (!is_array($descriptionLines)) {
-            $descriptionLines = [$descriptionLines];
-        }
-
-        $this->description = implode(PHP_EOL, $descriptionLines);
-        return $this;
-    }
-
-    /**
-     * Set the author information:
-     * [
-     *    'name'     => '',
-     *    'url'      => '',
-     *    'icon_url' => '',
-     */
-    public function author(array $author): self
-    {
-        $this->author = $author;
-        return $this;
-    }
-
-    /**
-     * Set the fields
-     */
-    public function fields(array $fields): self
-    {
-        $this->fields = [];
-        foreach ($fields as $name => $value) {
-            $this->fields[] = [
-                'name'   => '**'.$name.'**', // bold
-                'value'  => $value,
-                'inline' => true,
-            ];
-        }
-
-        return $this;
-    }
-
-    public function footer(string $footer): self
-    {
-        $this->footer = $footer;
-        return $this;
-    }
-
-    public function success(): self
-    {
-        $this->color = static::COLOR_SUCCESS;
-        return $this;
-    }
-
-    public function warning(): self
-    {
-        $this->color = static::COLOR_WARNING;
-        return $this;
-    }
-
-    public function error(): self
-    {
-        $this->color = static::COLOR_ERROR;
-        return $this;
-    }
-
-    public function toArray(): array
-    {
-        $embeds = [
-            'title'       => $this->title,
-            'url'         => $this->url,
-            'type'        => 'rich',
-            'description' => $this->description,
-            'author'      => $this->author,
-            'timestamp'   => Carbon::now('UTC'),
-        ];
-
-        if (!empty($this->fields)) {
-            $embeds['fields'] = $this->fields;
-        }
-
-        if (!empty($this->footer)) {
-            $embeds['footer'] = [
-                'text' => $this->footer,
-            ];
-        }
-
-        return [
-            'embeds' => [$embeds],
-        ];
-    }
-}

app/Notifications/Channels/Discord/DiscordWebhook.php

@@ -1,38 +0,0 @@
-<?php
-
-namespace App\Notifications\Channels\Discord;
-
-use App\Contracts\Notification;
-use App\Support\HttpClient;
-use GuzzleHttp\Exception\RequestException;
-use GuzzleHttp\Psr7;
-use Illuminate\Support\Facades\Log;
-
-class DiscordWebhook
-{
-    private $httpClient;
-
-    public function __construct(HttpClient $httpClient)
-    {
-        $this->httpClient = $httpClient;
-    }
-
-    public function send($notifiable, Notification $notification)
-    {
-        $message = $notification->toDiscordChannel($notifiable);
-        if ($message === null || empty($message->webhook_url)) {
-            Log::debug('Discord notifications not configured, skipping');
-            return;
-        }
-
-        try {
-            $data = $message->toArray();
-            $this->httpClient->post($message->webhook_url, $data);
-        } catch (RequestException $e) {
-            $request = Psr7\Message::toString($e->getRequest());
-            $response = Psr7\Message::toString($e->getResponse());
-            Log::error('Error sending Discord notification: request: '.$e->getMessage().', '.$request);
-            Log::error('Error sending Discord notification: response: '.$response);
-        }
-    }
-}

app/Notifications/Channels/MailChannel.php

@@ -17,7 +17,7 @@ trait MailChannel
      * @param string $template Markdown template to use
      * @param array  $args     Arguments to pass to the template
      */
-    public function setMailable(string $subject, string $template, array $args)
+    public function setMailable($subject, $template, $args)
     {
         $this->mailSubject = $subject;
         $this->mailTemplate = $template;

app/Notifications/EventHandler.php

@@ -6,13 +6,13 @@ use App\Contracts\Listener;
 use App\Events\NewsAdded;
 use App\Events\PirepAccepted;
 use App\Events\PirepFiled;
-use App\Events\PirepPrefiled;
 use App\Events\PirepRejected;
-use App\Events\PirepStatusChange;
 use App\Events\UserRegistered;
 use App\Events\UserStateChanged;
 use App\Models\Enums\UserState;
 use App\Models\User;
+use App\Notifications\Messages\PirepSubmitted;
+use App\Notifications\Messages\UserPending;
 use App\Notifications\Messages\UserRejected;
 use App\Notifications\Notifiables\Broadcast;
 use Exception;
@@ -23,14 +23,12 @@ use Illuminate\Support\Facades\Notification;
 /**
  * Listen for different events and map them to different notifications
  */
-class NotificationEventsHandler extends Listener
+class EventHandler extends Listener
 {
     private static $broadcastNotifyable;
 
     public static $callbacks = [
         NewsAdded::class        => 'onNewsAdded',
-        PirepPrefiled::class     => 'onPirepPrefile',
-        PirepStatusChange::class => 'onPirepStatusChange',
         PirepAccepted::class    => 'onPirepAccepted',
         PirepFiled::class       => 'onPirepFile',
         PirepRejected::class    => 'onPirepRejected',
@@ -58,8 +56,7 @@ class NotificationEventsHandler extends Listener
             }
 
             try {
-                $this->notifyUser($user, $notification);
+                Notification::send([$user], $notification);
-                // Notification::send([$user], $notification);
             } catch (Exception $e) {
                 Log::emergency('Error emailing admin ('.$user->email.'). Error='.$e->getMessage());
             }
@@ -120,24 +117,19 @@ class NotificationEventsHandler extends Listener
             .$event->user->ident.' is '
             .UserState::label($event->user->state).', sending active email');
 
+        /*
+         * Send all of the admins a notification that a new user registered
+         */
+        $this->notifyAdmins(new Messages\AdminUserRegistered($event->user));
+
         /*
          * Send the user a confirmation email
          */
         if ($event->user->state === UserState::ACTIVE) {
             $this->notifyUser($event->user, new Messages\UserRegistered($event->user));
         } elseif ($event->user->state === UserState::PENDING) {
-            $this->notifyUser($event->user, new Messages\UserPending($event->user));
+            $this->notifyUser($event->user, new UserPending($event->user));
         }
-
-        /*
-         * Send all of the admins a notification that a new user registered
-         */
-        $this->notifyAdmins(new Messages\AdminUserRegistered($event->user));
-
-        /**
-         * Discord and other notifications
-         */
-        Notification::send([$event->user], new Messages\AdminUserRegistered($event->user));
     }
 
     /**
@@ -160,34 +152,15 @@ class NotificationEventsHandler extends Listener
         }
     }
 
-    /**
-     * Prefile notification
-     */
-    public function onPirepPrefile(PirepPrefiled $event): void
-    {
-        Log::info('NotificationEvents::onPirepPrefile: '.$event->pirep->id.' prefiled');
-        Notification::send([$event->pirep], new Messages\PirepPrefiled($event->pirep));
-    }
-
-    /**
-     * Status Change notification
-     */
-    public function onPirepStatusChange(PirepStatusChange $event): void
-    {
-        Log::info('NotificationEvents::onPirepStatusChange: '.$event->pirep->id.' prefiled');
-        Notification::send([$event->pirep], new Messages\PirepStatusChanged($event->pirep));
-    }
-
     /**
      * Notify the admins that a new PIREP has been filed
      *
-     * @param PirepFiled $event
+     * @param \App\Events\PirepFiled $event
      */
     public function onPirepFile(PirepFiled $event): void
     {
-        Log::info('NotificationEvents::onPirepFile: '.$event->pirep->id.' filed');
+        Log::info('NotificationEvents::onPirepFile: '.$event->pirep->id.' filed ');
-        $this->notifyAdmins(new Messages\PirepSubmitted($event->pirep));
+        $this->notifyAdmins(new PirepSubmitted($event->pirep));
-        Notification::send([$event->pirep], new Messages\PirepSubmitted($event->pirep));
     }
 
     /**
@@ -221,6 +194,5 @@ class NotificationEventsHandler extends Listener
     {
         Log::info('NotificationEvents::onNewsAdded');
         $this->notifyAllUsers(new Messages\NewsAdded($event->news));
-        Notification::send([$event->news], new Messages\NewsAdded($event->news));
     }
 }

app/Notifications/Messages/AdminUserRegistered.php

@@ -4,15 +4,14 @@ namespace App\Notifications\Messages;
 
 use App\Contracts\Notification;
 use App\Models\User;
-use App\Notifications\Channels\Discord\DiscordMessage;
-use App\Notifications\Channels\Discord\DiscordWebhook;
 use App\Notifications\Channels\MailChannel;
-use Illuminate\Contracts\Queue\ShouldQueue;
 
-class AdminUserRegistered extends Notification implements ShouldQueue
+class AdminUserRegistered extends Notification
 {
     use MailChannel;
 
+    public $channels = ['mail'];
+
     private $user;
 
     /**
@@ -32,32 +31,6 @@ class AdminUserRegistered extends Notification implements ShouldQueue
         );
     }
 
-    public function via($notifiable)
-    {
-        return ['mail', DiscordWebhook::class];
-    }
-
-    /**
-     * Send a Discord notification
-     *
-     * @param User  $pirep
-     * @param mixed $user
-     *
-     * @return DiscordMessage|null
-     */
-    public function toDiscordChannel($user): ?DiscordMessage
-    {
-        if (empty(setting('notifications.discord_private_webhook_url'))) {
-            return null;
-        }
-
-        $dm = new DiscordMessage();
-        return $dm->webhook(setting('notifications.discord_private_webhook_url'))
-            ->success()
-            ->title('New User Registered: '.$user->ident)
-            ->fields([]);
-    }
-
     public function toArray($notifiable)
     {
         return [

app/Notifications/Messages/NewsAdded.php

@@ -4,15 +4,13 @@ namespace App\Notifications\Messages;
 
 use App\Contracts\Notification;
 use App\Models\News;
-use App\Notifications\Channels\Discord\DiscordMessage;
-use App\Notifications\Channels\Discord\DiscordWebhook;
 use App\Notifications\Channels\MailChannel;
-use Illuminate\Contracts\Queue\ShouldQueue;
 
-class NewsAdded extends Notification implements ShouldQueue
+class NewsAdded extends Notification
 {
     use MailChannel;
 
+    public $channels = ['mail'];
     public $requires_opt_in = true;
 
     private $news;
@@ -29,34 +27,6 @@ class NewsAdded extends Notification implements ShouldQueue
         );
     }
 
-    public function via($notifiable)
-    {
-        return ['mail', DiscordWebhook::class];
-    }
-
-    /**
-     * @param News $news
-     *
-     * @return DiscordMessage|null
-     */
-    public function toDiscordChannel($news): ?DiscordMessage
-    {
-        if (empty(setting('notifications.discord_public_webhook_url'))) {
-            return null;
-        }
-
-        $dm = new DiscordMessage();
-        return $dm->webhook(setting('notifications.discord_public_webhook_url'))
-            ->success()
-            ->title('News: '.$news->subject)
-            ->author([
-                'name'     => $news->user->ident.' - '.$news->user->name_private,
-                'url'      => '',
-                'icon_url' => $news->user->resolveAvatarUrl(),
-            ])
-            ->description($news->body);
-    }
-
     /**
      * Get the array representation of the notification.
      *

app/Notifications/Messages/PirepAccepted.php

@@ -5,15 +5,16 @@ namespace App\Notifications\Messages;
 use App\Contracts\Notification;
 use App\Models\Pirep;
 use App\Notifications\Channels\MailChannel;
-use Illuminate\Contracts\Queue\ShouldQueue;
 
 /**
- * Send the PIREP accepted message to a particular user, can also be sent to Discord
+ * Send the PIREP accepted message to a particular user
  */
-class PirepAccepted extends Notification implements ShouldQueue
+class PirepAccepted extends Notification
 {
     use MailChannel;
 
+    public $channels = ['mail'];
+
     private $pirep;
 
     /**
@@ -34,11 +35,6 @@ class PirepAccepted extends Notification implements ShouldQueue
         );
     }
 
-    public function via($notifiable)
-    {
-        return ['mail'];
-    }
-
     /**
      * Get the array representation of the notification.
      *

app/Notifications/Messages/PirepPrefiled.php

@@ -1,102 +0,0 @@
-<?php
-
-namespace App\Notifications\Messages;
-
-use App\Contracts\Notification;
-use App\Models\Pirep;
-use App\Notifications\Channels\Discord\DiscordMessage;
-use App\Notifications\Channels\Discord\DiscordWebhook;
-use App\Support\Units\Distance;
-use App\Support\Units\Time;
-use Illuminate\Contracts\Queue\ShouldQueue;
-use PhpUnitsOfMeasure\Exception\NonNumericValue;
-use PhpUnitsOfMeasure\Exception\NonStringUnitName;
-
-/**
- * Send the PIREP accepted message to a particular user, can also be sent to Discord
- */
-class PirepPrefiled extends Notification implements ShouldQueue
-{
-    private $pirep;
-
-    /**
-     * Create a new notification instance.
-     *
-     * @param Pirep $pirep
-     */
-    public function __construct(Pirep $pirep)
-    {
-        parent::__construct();
-        $this->pirep = $pirep;
-    }
-
-    public function via($notifiable)
-    {
-        return [DiscordWebhook::class];
-    }
-
-    /**
-     * Send a Discord notification
-     *
-     * @param Pirep $pirep
-     *
-     * @return DiscordMessage|null
-     */
-    public function toDiscordChannel($pirep): ?DiscordMessage
-    {
-        if (empty(setting('notifications.discord_public_webhook_url'))) {
-            return null;
-        }
-
-        $title = 'Flight '.$pirep->airline->code.$pirep->ident.' Prefiled';
-        $fields = [
-            'Flight'                => $pirep->airline->code.$pirep->ident,
-            'Departure Airport'     => $pirep->dpt_airport_id,
-            'Arrival Airport'       => $pirep->arr_airport_id,
-            'Equipment'             => $pirep->aircraft->ident,
-            'Flight Time (Planned)' => Time::minutesToTimeString($pirep->planned_flight_time),
-        ];
-
-        if ($pirep->planned_distance) {
-            try {
-                $planned_distance = new Distance(
-                    $pirep->planned_distance,
-                    config('phpvms.internal_units.distance')
-                );
-
-                $pd = $planned_distance[$planned_distance->unit].' '.$planned_distance->unit;
-                $fields['Distance (Planned)'] = $pd;
-            } catch (NonNumericValue $e) {
-            } catch (NonStringUnitName $e) {
-            }
-        }
-
-        $dm = new DiscordMessage();
-        return $dm->webhook(setting('notifications.discord_public_webhook_url'))
-            ->success()
-            ->title($title)
-            ->description($pirep->user->discord_id ? 'Flight by <@'.$pirep->user->discord_id.'>' : '')
-            ->url(route('frontend.pireps.show', [$pirep->id]))
-            ->author([
-                'name'     => $pirep->user->ident.' - '.$pirep->user->name_private,
-                'url'      => route('frontend.profile.show', [$pirep->user_id]),
-                'icon_url' => $pirep->user->resolveAvatarUrl(),
-            ])
-            ->fields($fields);
-    }
-
-    /**
-     * Get the array representation of the notification.
-     *
-     * @param mixed $notifiable
-     *
-     * @return array
-     */
-    public function toArray($notifiable)
-    {
-        return [
-            'pirep_id' => $this->pirep->id,
-            'user_id'  => $this->pirep->user_id,
-        ];
-    }
-}

app/Notifications/Messages/PirepRejected.php

@@ -5,18 +5,19 @@ namespace App\Notifications\Messages;
 use App\Contracts\Notification;
 use App\Models\Pirep;
 use App\Notifications\Channels\MailChannel;
-use Illuminate\Contracts\Queue\ShouldQueue;
 
-class PirepRejected extends Notification implements ShouldQueue
+class PirepRejected extends Notification
 {
     use MailChannel;
 
+    public $channels = ['mail'];
+
     private $pirep;
 
     /**
      * Create a new notification instance.
      *
-     * @param Pirep $pirep
+     * @param \App\Models\Pirep $pirep
      */
     public function __construct(Pirep $pirep)
     {
@@ -31,11 +32,6 @@ class PirepRejected extends Notification implements ShouldQueue
         );
     }
 
-    public function via($notifiable)
-    {
-        return ['mail'];
-    }
-
     /**
      * Get the array representation of the notification.
      *

app/Notifications/Messages/PirepStatusChanged.php

@@ -1,141 +0,0 @@
-<?php
-
-namespace App\Notifications\Messages;
-
-use App\Contracts\Notification;
-use App\Models\Enums\PirepStatus;
-use App\Models\Pirep;
-use App\Notifications\Channels\Discord\DiscordMessage;
-use App\Notifications\Channels\Discord\DiscordWebhook;
-use App\Support\Units\Distance;
-use App\Support\Units\Time;
-use Illuminate\Contracts\Queue\ShouldQueue;
-use PhpUnitsOfMeasure\Exception\NonNumericValue;
-use PhpUnitsOfMeasure\Exception\NonStringUnitName;
-
-/**
- * Send the PIREP accepted message to a particular user, can also be sent to Discord
- */
-class PirepStatusChanged extends Notification implements ShouldQueue
-{
-    private $pirep;
-
-    // TODO: Int'l languages for these
-    protected static $verbs = [
-        PirepStatus::INITIATED     => 'is initialized',
-        PirepStatus::SCHEDULED     => 'is scheduled',
-        PirepStatus::BOARDING      => 'is boarding',
-        PirepStatus::RDY_START     => 'is ready for start',
-        PirepStatus::PUSHBACK_TOW  => 'is pushing back',
-        PirepStatus::DEPARTED      => 'has departed',
-        PirepStatus::RDY_DEICE     => 'is ready for de-icing',
-        PirepStatus::STRT_DEICE    => 'is de-icing',
-        PirepStatus::GRND_RTRN     => 'on ground return',
-        PirepStatus::TAXI          => 'is taxiing',
-        PirepStatus::TAKEOFF       => 'has taken off',
-        PirepStatus::INIT_CLIM     => 'in initial climb',
-        PirepStatus::AIRBORNE      => 'is enroute',
-        PirepStatus::ENROUTE       => 'is enroute',
-        PirepStatus::DIVERTED      => 'has diverted',
-        PirepStatus::APPROACH      => 'on approach',
-        PirepStatus::APPROACH_ICAO => 'on approach',
-        PirepStatus::ON_FINAL      => 'on final approach',
-        PirepStatus::LANDING       => 'is landing',
-        PirepStatus::LANDED        => 'has landed',
-        PirepStatus::ARRIVED       => 'has arrived',
-        PirepStatus::CANCELLED     => 'is cancelled',
-        PirepStatus::EMERG_DESCENT => 'in emergency descent',
-    ];
-
-    /**
-     * Create a new notification instance.
-     *
-     * @param Pirep $pirep
-     */
-    public function __construct(Pirep $pirep)
-    {
-        parent::__construct();
-        $this->pirep = $pirep;
-    }
-
-    public function via($notifiable)
-    {
-        return [DiscordWebhook::class];
-    }
-
-    /**
-     * Send a Discord notification
-     *
-     * @param Pirep $pirep
-     *
-     * @return DiscordMessage|null
-     */
-    public function toDiscordChannel($pirep): ?DiscordMessage
-    {
-        if (empty(setting('notifications.discord_public_webhook_url'))) {
-            return null;
-        }
-
-        $title = 'Flight '.$pirep->airline->code.$pirep->ident.' '.self::$verbs[$pirep->status];
-
-        $fields = [
-            'Flight'            => $pirep->airline->code.$pirep->ident,
-            'Departure Airport' => $pirep->dpt_airport_id,
-            'Arrival Airport'   => $pirep->arr_airport_id,
-            'Equipment'         => $pirep->aircraft->ident,
-            'Flight Time'       => Time::minutesToTimeString($pirep->flight_time),
-        ];
-
-        // Show the distance, but include the planned distance if it's been set
-        if ($pirep->distance) {
-            $unit = config('phpvms.internal_units.distance');
-
-            try {
-                $planned_distance = new Distance($pirep->distance, $unit);
-                $pd = $planned_distance[$planned_distance->unit];
-                $fields['Distance'] = $pd;
-
-                // Add the planned distance in
-                if ($pirep->planned_distance) {
-                    try {
-                        $planned_distance = new Distance($pirep->planned_distance, $unit);
-                        $pd = $planned_distance[$planned_distance->unit];
-                        $fields['Distance'] .= '/'.$pd;
-                    } catch (NonNumericValue | NonStringUnitName $e) {
-                    }
-                }
-
-                $fields['Distance'] .= ' '.$planned_distance->unit;
-            } catch (NonNumericValue | NonStringUnitName $e) {
-            }
-        }
-
-        $dm = new DiscordMessage();
-        return $dm->webhook(setting('notifications.discord_public_webhook_url'))
-            ->success()
-            ->title($title)
-            ->description($pirep->user->discord_id ? 'Flight by <@'.$pirep->user->discord_id.'>' : '')
-            ->url(route('frontend.pireps.show', [$pirep->id]))
-            ->author([
-                'name'     => $pirep->user->ident.' - '.$pirep->user->name_private,
-                'url'      => route('frontend.profile.show', [$pirep->user_id]),
-                'icon_url' => $pirep->user->resolveAvatarUrl(),
-            ])
-            ->fields($fields);
-    }
-
-    /**
-     * Get the array representation of the notification.
-     *
-     * @param mixed $notifiable
-     *
-     * @return array
-     */
-    public function toArray($notifiable)
-    {
-        return [
-            'pirep_id' => $this->pirep->id,
-            'user_id'  => $this->pirep->user_id,
-        ];
-    }
-}

app/Notifications/Messages/PirepSubmitted.php

@@ -4,19 +4,14 @@ namespace App\Notifications\Messages;
 
 use App\Contracts\Notification;
 use App\Models\Pirep;
-use App\Notifications\Channels\Discord\DiscordMessage;
-use App\Notifications\Channels\Discord\DiscordWebhook;
 use App\Notifications\Channels\MailChannel;
-use App\Support\Units\Distance;
-use App\Support\Units\Time;
-use Illuminate\Contracts\Queue\ShouldQueue;
-use PhpUnitsOfMeasure\Exception\NonNumericValue;
-use PhpUnitsOfMeasure\Exception\NonStringUnitName;
 
-class PirepSubmitted extends Notification implements ShouldQueue
+class PirepSubmitted extends Notification
 {
     use MailChannel;
 
+    public $channels = ['mail'];
+
     private $pirep;
 
     /**
@@ -37,60 +32,6 @@ class PirepSubmitted extends Notification implements ShouldQueue
         );
     }
 
-    public function via($notifiable)
-    {
-        return ['mail', DiscordWebhook::class];
-    }
-
-    /**
-     * Send a Discord notification
-     *
-     * @param Pirep $pirep
-     *
-     * @return DiscordMessage|null
-     */
-    public function toDiscordChannel($pirep): ?DiscordMessage
-    {
-        if (empty(setting('notifications.discord_public_webhook_url'))) {
-            return null;
-        }
-
-        $title = 'Flight '.$pirep->airline->code.$pirep->ident.' Filed';
-        $fields = [
-            'Flight'                => $pirep->airline->code.$pirep->ident,
-            'Departure Airport'     => $pirep->dpt_airport_id,
-            'Arrival Airport'       => $pirep->arr_airport_id,
-            'Equipment'             => $pirep->aircraft->ident,
-            'Flight Time (Planned)' => Time::minutesToTimeString($pirep->planned_flight_time),
-        ];
-
-        if ($pirep->planned_distance) {
-            try {
-                $planned_distance = new Distance(
-                    $pirep->planned_distance,
-                    config('phpvms.internal_units.distance')
-                );
-
-                $pd = $planned_distance[$planned_distance->unit].' '.$planned_distance->unit;
-                $fields['Distance (Planned)'] = $pd;
-            } catch (NonNumericValue | NonStringUnitName $e) {
-            }
-        }
-
-        $dm = new DiscordMessage();
-        return $dm->webhook(setting('notifications.discord_public_webhook_url'))
-            ->success()
-            ->title($title)
-            ->description($pirep->user->discord_id ? 'Flight by <@'.$pirep->user->discord_id.'>' : '')
-            ->url(route('frontend.pireps.show', [$pirep->id]))
-            ->author([
-                'name'     => $pirep->user->ident.' - '.$pirep->user->name_private,
-                'url'      => route('frontend.profile.show', [$pirep->user_id]),
-                'icon_url' => $pirep->user->resolveAvatarUrl(),
-            ])
-            ->fields($fields);
-    }
-
     /**
      * Get the array representation of the notification.
      *

app/Notifications/Messages/UserPending.php

@@ -5,16 +5,17 @@ namespace App\Notifications\Messages;
 use App\Contracts\Notification;
 use App\Models\User;
 use App\Notifications\Channels\MailChannel;
-use Illuminate\Contracts\Queue\ShouldQueue;
 
-class UserPending extends Notification implements ShouldQueue
+class UserPending extends Notification
 {
     use MailChannel;
 
+    public $channels = ['mail'];
+
     private $user;
 
     /**
-     * @param User $user
+     * @param \App\Models\User $user
      */
     public function __construct(User $user)
     {
@@ -29,11 +30,6 @@ class UserPending extends Notification implements ShouldQueue
         );
     }
 
-    public function via($notifiable)
-    {
-        return ['mail'];
-    }
-
     /**
      * Get the array representation of the notification.
      *

app/Notifications/Messages/UserRegistered.php

@@ -5,18 +5,19 @@ namespace App\Notifications\Messages;
 use App\Contracts\Notification;
 use App\Models\User;
 use App\Notifications\Channels\MailChannel;
-use Illuminate\Contracts\Queue\ShouldQueue;
 
-class UserRegistered extends Notification implements ShouldQueue
+class UserRegistered extends Notification
 {
     use MailChannel;
 
+    public $channels = ['mail'];
+
     private $user;
 
     /**
      * Create a new notification instance.
      *
-     * @param User $user
+     * @param \App\Models\User $user
      */
     public function __construct(User $user)
     {
@@ -31,11 +32,6 @@ class UserRegistered extends Notification implements ShouldQueue
         );
     }
 
-    public function via($notifiable)
-    {
-        return ['mail'];
-    }
-
     public function toArray($notifiable)
     {
         return [

app/Notifications/Messages/UserRejected.php

@@ -5,14 +5,13 @@ namespace App\Notifications\Messages;
 use App\Contracts\Notification;
 use App\Models\User;
 use App\Notifications\Channels\MailChannel;
-use Illuminate\Bus\Queueable;
-use Illuminate\Contracts\Queue\ShouldQueue;
 
-class UserRejected extends Notification implements ShouldQueue
+class UserRejected extends Notification
 {
-    use Queueable;
     use MailChannel;
 
+    public $channels = ['mail'];
+
     private $user;
 
     /**
@@ -31,11 +30,6 @@ class UserRejected extends Notification implements ShouldQueue
         );
     }
 
-    public function via($notifiable)
-    {
-        return ['mail'];
-    }
-
     /**
      * Get the array representation of the notification.
      *

app/Providers/CronServiceProvider.php

@@ -2,11 +2,11 @@
 
 namespace App\Providers;
 
-use App\Cron\Hourly\ClearExpiredSimbrief;
 use App\Cron\Hourly\DeletePireps;
 use App\Cron\Hourly\RemoveExpiredBids;
 use App\Cron\Hourly\RemoveExpiredLiveFlights;
 use App\Cron\Nightly\ApplyExpenses;
+use App\Cron\Nightly\ClearExpiredSimbrief;
 use App\Cron\Nightly\NewVersionCheck;
 use App\Cron\Nightly\PilotLeave;
 use App\Cron\Nightly\RecalculateBalances;
@@ -31,6 +31,7 @@ class CronServiceProvider extends ServiceProvider
             SetActiveFlights::class,
             RecalculateStats::class,
             NewVersionCheck::class,
+            ClearExpiredSimbrief::class,
         ],
 
         CronWeekly::class => [
@@ -44,7 +45,6 @@ class CronServiceProvider extends ServiceProvider
             DeletePireps::class,
             RemoveExpiredBids::class,
             RemoveExpiredLiveFlights::class,
-            ClearExpiredSimbrief::class,
         ],
     ];
 }

app/Providers/EventServiceProvider.php

@@ -11,7 +11,7 @@ use App\Listeners\ExpenseListener;
 use App\Listeners\FinanceEventHandler;
 use App\Listeners\PirepEventsHandler;
 use App\Listeners\UserStateListener;
-use App\Notifications\NotificationEventsHandler;
+use App\Notifications\EventHandler;
 use Codedge\Updater\Events\UpdateAvailable;
 use Codedge\Updater\Events\UpdateSucceeded;
 use Illuminate\Auth\Events\Registered;
@@ -39,17 +39,12 @@ class EventServiceProvider extends ServiceProvider
 
         UpdateAvailable::class => [],
         UpdateSucceeded::class => [],
-
-        // Log messages out to the console if running there
-        'Illuminate\Log\Events\MessageLogged' => [
-            'App\Listeners\MessageLoggedListener',
-        ],
     ];
 
     protected $subscribe = [
         BidEventHandler::class,
         FinanceEventHandler::class,
-        NotificationEventsHandler::class,
+        EventHandler::class,
         AwardHandler::class,
         PirepEventsHandler::class,
     ];

app/Providers/RouteServiceProvider.php

@@ -90,6 +90,10 @@ class RouteServiceProvider extends ServiceProvider
 
             Route::post('/run-migrations', 'UpdateController@run_migrations')->name('run_migrations');
             Route::get('/complete', 'UpdateController@complete')->name('complete');
+
+            // Routes for the update downloader
+            Route::get('/downloader', 'UpdateController@updater')->name('updater');
+            Route::post('/downloader', 'UpdateController@update_download')->name('update_download');
         });
     }
 
@@ -140,7 +144,6 @@ class RouteServiceProvider extends ServiceProvider
                 Route::get('simbrief/generate', 'SimBriefController@generate')->name('simbrief.generate');
                 Route::post('simbrief/apicode', 'SimBriefController@api_code')->name('simbrief.api_code');
                 Route::get('simbrief/check_ofp', 'SimBriefController@check_ofp')->name('simbrief.check_ofp');
-                Route::get('simbrief/update_ofp', 'SimBriefController@update_ofp')->name('simbrief.update_ofp');
                 Route::get('simbrief/{id}', 'SimBriefController@briefing')->name('simbrief.briefing');
                 Route::get('simbrief/{id}/prefile', 'SimBriefController@prefile')->name('simbrief.prefile');
                 Route::get('simbrief/{id}/cancel', 'SimBriefController@cancel')->name('simbrief.cancel');
@@ -534,9 +537,6 @@ class RouteServiceProvider extends ServiceProvider
                 Route::get('fleet', 'FleetController@index');
                 Route::get('fleet/aircraft/{id}', 'FleetController@get_aircraft');
 
-                Route::get('subfleet', 'FleetController@index');
-                Route::get('subfleet/aircraft/{id}', 'FleetController@get_aircraft');
-
                 Route::get('flights', 'FlightController@index');
                 Route::get('flights/search', 'FlightController@search');
                 Route::get('flights/{id}', 'FlightController@get');

app/Services/FareService.php

@@ -293,13 +293,13 @@ class FareService extends Service
      * Save the list of fares
      *
      * @param Pirep $pirep
-     * @param PirepFare[] $fares
+     * @param array $fares ['fare_id', 'count']
      *
      * @throws \Exception
      */
     public function saveForPirep(Pirep $pirep, array $fares)
     {
-        if (!$fares || empty($fares)) {
+        if (!$fares) {
             return;
         }
 
@@ -308,9 +308,13 @@ class FareService extends Service
 
         // Add them in
         foreach ($fares as $fare) {
-            $fare->pirep_id = $pirep->id;
+            $fare['pirep_id'] = $pirep->id;
+            // other fields: ['fare_id', 'count']
+
             Log::info('Saving fare pirep='.$pirep->id.', fare='.$fare['count']);
-            $fare->save();
+
+            $field = new PirepFare($fare);
+            $field->save();
         }
     }
 }

app/Services/Finance/PirepFinanceService.php

@@ -8,10 +8,7 @@ use App\Models\Aircraft;
 use App\Models\Airport;
 use App\Models\Enums\ExpenseType;
 use App\Models\Enums\FareType;
-use App\Models\Enums\FuelType;
 use App\Models\Enums\PirepSource;
-use App\Models\Enums\PirepState;
-use App\Models\Enums\PirepStatus;
 use App\Models\Expense;
 use App\Models\Pirep;
 use App\Models\Subfleet;
@@ -154,39 +151,18 @@ class PirepFinanceService extends Service
      */
     public function payFuelCosts(Pirep $pirep): void
     {
-        // Get Airport Fuel Prices or Use Defaults
         $ap = $pirep->dpt_airport;
-
+        // Get Airport Fuel Cost or revert back to settings
-        // Get Aircraft Fuel Type from Subfleet
+        if (empty($ap->fuel_jeta_cost)) {
-        // And set $fuel_cost according to type (Failsafe is Jet A)
+            $fuel_cost = setting('airports.default_jet_a_fuel_cost');
-        $sf = $pirep->aircraft->subfleet;
-        if ($sf) {
-            $fuel_type = $sf->fuel_type;
         } else {
-            $fuel_type = FuelType::JET_A;
+            $fuel_cost = $ap->fuel_jeta_cost;
-        }
-
-        if ($fuel_type === FuelType::LOW_LEAD) {
-            $fuel_cost = !empty($ap->fuel_100ll_cost) ? $ap->fuel_100ll_cost : setting('airports.default_100ll_fuel_cost');
-        } elseif ($fuel_type === FuelType::MOGAS) {
-            $fuel_cost = !empty($ap->fuel_mogas_cost) ? $ap->fuel_mogas_cost : setting('airports.default_mogas_fuel_cost');
-        } else { // Default to JetA
-            $fuel_cost = !empty($ap->fuel_jeta_cost) ? $ap->fuel_jeta_cost : setting('airports.default_jet_a_fuel_cost');
         }
 
         if (setting('pireps.advanced_fuel', false)) {
+            $ac = $pirep->aircraft;
             // Reading second row by skip(1) to reach the previous accepted pirep. Current pirep is at the first row
-            // To get proper fuel values, we need to fetch current pirep and older ones only. Scenario: ReCalculating finances
+            $prev_flight = Pirep::where('aircraft_id', $ac->id)->where('state', 2)->where('status', 'ONB')->orderby('submitted_at', 'desc')->skip(1)->first();
-            $prev_flight = Pirep::where([
-                'aircraft_id' => $pirep->aircraft->id,
-                'state'       => PirepState::ACCEPTED,
-                'status'      => PirepStatus::ARRIVED,
-            ])
-                ->where('submitted_at', '<=', $pirep->submitted_at)
-                ->orderby('submitted_at', 'desc')
-                ->skip(1)
-                ->first();
-
             if ($prev_flight) {
                 // If there is a pirep use its values to calculate the remaining fuel
                 // and calculate the uplifted fuel amount for this pirep
@@ -205,7 +181,8 @@ class PirepFinanceService extends Service
         }
 
         $debit = Money::createFromAmount($fuel_amount * $fuel_cost);
-        Log::info('Finance: Fuel cost, (fuel='.$fuel_amount.', cost='.$fuel_cost.') D='.$debit->getAmount());
+        Log::info('Finance: Fuel cost, (fuel='.$fuel_amount.', cost='.$fuel_cost.') D='
+            .$debit->getAmount());
 
         $this->financeSvc->debitFromJournal(
             $pirep->airline->journal,
@@ -306,29 +283,20 @@ class PirepFinanceService extends Service
             }
 
             // Form the memo, with some specific ones depending on the group
-            if ($expense->ref_model === Subfleet::class) {
+            if ($expense->ref_model === Subfleet::class
-                if ((int) ($expense->ref_model_id) === $pirep->aircraft->subfleet->id) {
+                && $expense->ref_model_id === $pirep->aircraft->subfleet->id
-                    $memo = "Subfleet Expense: $expense->name ({$pirep->aircraft->subfleet->name}) dd";
+            ) {
-                    $transaction_group = "Subfleet: $expense->name ({$pirep->aircraft->subfleet->name})";
+                $memo = "Subfleet Expense: {$expense->name} ({$pirep->aircraft->subfleet->name})";
-                } else { // Skip any subfleets that weren't used for this flight
+                $transaction_group = "Subfleet: {$expense->name} ({$pirep->aircraft->subfleet->name})";
-                    return;
+            } elseif ($expense->ref_model === Aircraft::class
-                }
+                      && $expense->ref_model_id === $pirep->aircraft->id
-            } elseif ($expense->ref_model === Aircraft::class) {
+            ) {
-                if ((int) ($expense->ref_model_id) === $pirep->aircraft->id) {
+                $memo = "Aircraft Expense: {$expense->name} ({$pirep->aircraft->name})";
-                    $memo = "Aircraft Expense: $expense->name ({$pirep->aircraft->name})";
+                $transaction_group = "Aircraft: {$expense->name} "
-                    $transaction_group = "Aircraft: $expense->name "
                     ."({$pirep->aircraft->name}-{$pirep->aircraft->registration})";
-                } else { // Skip any aircraft expenses that weren't used for this flight
-                    return;
-                }
             } else {
-                // Skip any expenses that aren't for the airline this flight was for
+                $memo = "Expense: {$expense->name}";
-                if ($expense->airline_id && $expense->airline_id !== $pirep->airline_id) {
+                $transaction_group = "Expense: {$expense->name}";
-                    return;
-                }
-
-                $memo = "Expense: $expense->name";
-                $transaction_group = "Expense: $expense->name";
             }
 
             $debit = Money::createFromAmount($expense->amount);
@@ -371,8 +339,8 @@ class PirepFinanceService extends Service
         $expenses->map(function (Expense $expense, $i) use ($pirep) {
             Log::info('Finance: PIREP: '.$pirep->id.', airport expense:', $expense->toArray());
 
-            $memo = "Airport Expense: $expense->name ($expense->ref_model_id)";
+            $memo = "Airport Expense: {$expense->name} ({$expense->ref_model_id})";
-            $transaction_group = "Airport: $expense->ref_model_id";
+            $transaction_group = "Airport: {$expense->ref_model_id}";
 
             $debit = Money::createFromAmount($expense->amount);
 

app/Services/ImportExport/FlightImporter.php

@@ -85,6 +85,7 @@ class FlightImporter extends ImportExport
             'flight_number' => $row['flight_number'],
             'route_code'    => $row['route_code'],
             'route_leg'     => $row['route_leg'],
+            'visible'       => true,
         ], $row);
 
         $row['dpt_airport'] = strtoupper($row['dpt_airport']);
@@ -98,10 +99,6 @@ class FlightImporter extends ImportExport
             $flight->setAttribute('alt_airport_id', $row['alt_airport']);
         }
 
-        // Handle Route and Level Fields
-        $flight->setAttribute('route', strtoupper($row['route']));
-        $flight->setAttribute('level', $row['level']);
-
         // Any specific transformations
 
         // Check for a valid value

app/Services/Installer/ConfigService.php

@@ -16,9 +16,9 @@ use Symfony\Component\HttpFoundation\File\Exception\FileException;
 class ConfigService extends Service
 {
     protected static $defaultValues = [
-        'APP_ENV'             => 'production',
+        'APP_ENV'             => 'prod',
         'APP_KEY'             => '',
-        'APP_DEBUG'           => false,
+        'APP_DEBUG'           => true,
         'APP_LOCALE'          => 'en',
         'DEBUG_TOOLBAR'       => false,
         'SITE_NAME'           => '',

app/Services/Installer/MigrationService.php

@@ -68,7 +68,7 @@ class MigrationService extends Service
             $availMigrations[] = $filepath;
         }
 
-        //Log::info('Migrations available: '.count($availMigrations));
+        Log::info('Migrations available: '.count($availMigrations));
 
         return $availMigrations;
     }
@@ -77,12 +77,12 @@ class MigrationService extends Service
      * Run all of the migrations that are available. Just call artisan since
      * it looks into all of the module directories, etc
      */
-    public function runAllMigrations(): string
+    public function runAllMigrations()
     {
         // A little ugly, run the main migration first, this makes sure the migration table is there
         $output = '';
 
-        Artisan::call('migrate', ['--force' => true]);
+        Artisan::call('migrate');
         $output .= trim(Artisan::output());
 
         // Then get any remaining migrations that are left over
@@ -92,14 +92,10 @@ class MigrationService extends Service
         $migrator = $this->getMigrator();
         $availMigrations = $this->migrationsAvailable();
 
-        if (count($availMigrations) > 0) {
         Log::info('Running '.count($availMigrations).' available migrations');
         $ret = $migrator->run($availMigrations);
         Log::info('Ran '.count($ret).' migrations');
 
         return $output."\n".implode("\n", $ret);
     }
-
-        return $output;
-    }
 }

app/Services/Installer/SeederService.php

@@ -21,10 +21,7 @@ class SeederService extends Service
     private $offsets = [];
 
     // Map an environment to a seeder directory, if we want to share
-    public static $seed_mapper = [
+    public static $seed_mapper = [];
-        'local'      => 'dev',
-        'production' => 'prod',
-    ];
 
     public function __construct(DatabaseService $databaseSvc)
     {

app/Services/Metar/AviationWeather.php

@@ -48,10 +48,6 @@ class AviationWeather extends Metar
             $res = $this->httpClient->get($url, []);
             $xml = simplexml_load_string($res);
 
-            if ($xml->errors && count($xml->errors->children()) > 0) {
-                return '';
-            }
-
             $attrs = $xml->data->attributes();
             if (!isset($attrs['num_results'])) {
                 return '';

app/Services/ModuleService.php

@@ -126,11 +126,7 @@ class ModuleService extends Service
                 'enabled' => 1,
             ]);
 
-            try {
+            Artisan::call('module:migrate '.$module_name);
-                Artisan::call('module:migrate '.$module_name, ['--force' => true]);
-            } catch (Exception $e) {
-                Log::error('Error running migration for '.$module_name.'; error='.$e);
-            }
 
             return true;
         }
@@ -229,7 +225,7 @@ class ModuleService extends Service
         }
 
         Artisan::call('config:cache');
-        Artisan::call('module:migrate '.$module, ['--force' => true]);
+        Artisan::call('module:migrate '.$module);
 
         return flash()->success('Module Installed');
     }
@@ -250,7 +246,7 @@ class ModuleService extends Service
         ]);
 
         if ($status === true) {
-            Artisan::call('module:migrate '.$module->name, ['--force' => true]);
+            Artisan::call('module:migrate '.$module->name);
         }
 
         return true;

app/Services/PirepService.php

@@ -11,16 +11,13 @@ use App\Events\PirepRejected;
 use App\Events\UserStatsChanged;
 use App\Exceptions\AircraftInvalid;
 use App\Exceptions\AircraftNotAtAirport;
-use App\Exceptions\AircraftNotAvailable;
 use App\Exceptions\AircraftPermissionDenied;
 use App\Exceptions\AirportNotFound;
 use App\Exceptions\PirepCancelNotAllowed;
-use App\Exceptions\PirepError;
 use App\Exceptions\UserNotAtAirport;
 use App\Models\Acars;
 use App\Models\Aircraft;
 use App\Models\Enums\AcarsType;
-use App\Models\Enums\AircraftState;
 use App\Models\Enums\FlightType;
 use App\Models\Enums\PirepSource;
 use App\Models\Enums\PirepState;
@@ -36,6 +33,7 @@ use App\Repositories\AircraftRepository;
 use App\Repositories\AirportRepository;
 use App\Repositories\PirepRepository;
 use Carbon\Carbon;
+use function count;
 use Illuminate\Database\Eloquent\ModelNotFoundException;
 use Illuminate\Support\Facades\Log;
 
@@ -44,18 +42,16 @@ class PirepService extends Service
     private $aircraftRepo;
     private $airportRepo;
     private $airportSvc;
-    private $fareSvc;
     private $geoSvc;
     private $pirepRepo;
     private $simBriefSvc;
     private $userSvc;
 
     /**
+     * @param AircraftRepository $aircraftRepo
+     * @param GeoService         $geoSvc
      * @param AirportRepository  $airportRepo
      * @param AirportService     $airportSvc
-     * @param AircraftRepository $aircraftRepo
-     * @param FareService        $fareSvc
-     * @param GeoService         $geoSvc
      * @param PirepRepository    $pirepRepo
      * @param SimBriefService    $simBriefSvc
      * @param UserService        $userSvc
@@ -64,7 +60,6 @@ class PirepService extends Service
         AirportRepository $airportRepo,
         AirportService $airportSvc,
         AircraftRepository $aircraftRepo,
-        FareService $fareSvc,
         GeoService $geoSvc,
         PirepRepository $pirepRepo,
         SimBriefService $simBriefSvc,
@@ -73,7 +68,6 @@ class PirepService extends Service
         $this->airportRepo = $airportRepo;
         $this->airportSvc = $airportSvc;
         $this->aircraftRepo = $aircraftRepo;
-        $this->fareSvc = $fareSvc;
         $this->geoSvc = $geoSvc;
         $this->pirepRepo = $pirepRepo;
         $this->simBriefSvc = $simBriefSvc;
@@ -83,17 +77,15 @@ class PirepService extends Service
     /**
      * Create a prefiled PIREP
      *
-     * @param User              $user
+     * @param \App\Models\User $user
      * @param array            $attrs
-     * @param PirepFieldValue[] $fields
-     * @param PirepFare[]       $fares
      *
      * @throws AirportNotFound If one of the departure or arrival airports isn't found locally
      * @throws \Exception
      *
      * @return \App\Models\Pirep
      */
-    public function prefile(User $user, array $attrs, array $fields = [], array $fares = []): Pirep
+    public function prefile(User $user, array $attrs): Pirep
     {
         $attrs['user_id'] = $user->id;
         $attrs['state'] = PirepState::IN_PROGRESS;
@@ -139,33 +131,13 @@ class PirepService extends Service
             throw new AircraftPermissionDenied($user, $pirep->aircraft);
         }
 
-        // See if this aircraft is valid
+        // See if this aircraft is at the departure airport
         /** @var Aircraft $aircraft */
         $aircraft = $this->aircraftRepo->findWithoutFail($pirep->aircraft_id);
         if ($aircraft === null) {
             throw new AircraftInvalid($aircraft);
         }
 
-        // See if this aircraft is available for flight
-        /** @var Aircraft $aircraft */
-        $aircraft = $this->aircraftRepo->where('id', $pirep->aircraft_id)->where('state', AircraftState::PARKED)->first();
-        if ($aircraft === null) {
-            throw new AircraftNotAvailable($pirep->aircraft);
-        }
-
-        // See if this aircraft is being used by another user's active simbrief ofp
-        if (setting('simbrief.block_aircraft', false)) {
-            $sb_aircraft = SimBrief::select('aircraft_id')
-                ->where('aircraft_id', $pirep->aircraft_id)
-                ->where('user_id', '!=', $pirep->user_id)
-                ->whereNotNull('flight_id')
-                ->count();
-            if ($sb_aircraft > 0) {
-                throw new AircraftNotAvailable($pirep->aircraft);
-            }
-        }
-
-        // See if this aircraft is at the departure airport
         /* @noinspection NotOptimalIfConditionsInspection */
         if (setting('pireps.only_aircraft_at_dpt_airport') && $aircraft->airport_id !== $pirep->dpt_airport_id) {
             throw new AircraftNotAtAirport($pirep->aircraft);
@@ -181,25 +153,10 @@ class PirepService extends Service
             }
         }
 
-        $pirep->status = PirepStatus::INITIATED;
-        $pirep->save();
-        $pirep->refresh();
-
-        // Check if there is a simbrief_id, update it to have the pirep_id
-        // Keep the flight_id until the end of flight (pirep file)
-        if (array_key_exists('simbrief_id', $attrs)) {
-            /** @var SimBrief $simbrief */
-            $simbrief = SimBrief::find($attrs['simbrief_id']);
-            if ($simbrief) {
-                $this->simBriefSvc->attachSimbriefToPirep($pirep, $simbrief, true);
-            }
-        }
-
-        $this->updateCustomFields($pirep->id, $fields);
-        $this->fareSvc->saveForPirep($pirep, $fares);
-
         event(new PirepPrefiled($pirep));
 
+        $pirep->save();
+
         return $pirep;
     }
 
@@ -211,10 +168,10 @@ class PirepService extends Service
      *
      * @return Pirep
      */
-    public function create(Pirep $pirep, array $fields = []): Pirep
+    public function create(Pirep $pirep, array $field_values = []): Pirep
     {
-        if (empty($fields)) {
+        if (empty($field_values)) {
-            $fields = [];
+            $field_values = [];
         }
 
         // Check the block times. If a block on (arrival) time isn't
@@ -250,24 +207,10 @@ class PirepService extends Service
         $pirep->save();
         $pirep->refresh();
 
-        $this->updateCustomFields($pirep->id, $fields);
+        if (count($field_values) > 0) {
-
+            $this->updateCustomFields($pirep->id, $field_values);
-        return $pirep;
         }
 
-    /**
-     * @param PirepFieldValue[] $fields
-     * @param PirepFare[]       $fares
-     *
-     * @throws \Prettus\Validator\Exceptions\ValidatorException
-     * @throws \Exception
-     */
-    public function update(string $pirep_id, array $attrs, array $fields = [], array $fares = []): Pirep
-    {
-        $pirep = $this->pirepRepo->update($attrs, $pirep_id);
-        $this->updateCustomFields($pirep_id, $fields);
-        $this->fareSvc->saveForPirep($pirep, $fares);
-
         return $pirep;
     }
 
@@ -276,29 +219,16 @@ class PirepService extends Service
      *
      * @param Pirep                   $pirep
      * @param array                   $attrs
-     * @param PirepFieldValue[] $fields
+     * @param array PirepFieldValue[] $field_values
-     * @param PirepFare[]       $fares
      *
      * @throws \Exception
      *
      * @return Pirep
      */
-    public function file(Pirep $pirep, array $attrs = [], array $fields = [], array $fares = []): Pirep
+    public function file(Pirep $pirep, array $attrs = [], array $field_values = []): Pirep
     {
-        if (empty($fields)) {
+        if (empty($field_values)) {
-            $fields = [];
+            $field_values = [];
-        }
-
-        // Check if the PIREP has already been submitted
-        $is_already_submitted = in_array($pirep->state, [
-            PirepState::PENDING,
-            PirepState::ACCEPTED,
-            PirepState::CANCELLED,
-            PirepState::REJECTED,
-        ], true);
-
-        if ($is_already_submitted) {
-            throw new PirepError($pirep, 'PIREP has already been submitted');
         }
 
         $attrs['state'] = PirepState::PENDING;
@@ -343,8 +273,9 @@ class PirepService extends Service
         $pirep->save();
         $pirep->refresh();
 
-        $this->updateCustomFields($pirep->id, $fields);
+        if (count($field_values) > 0) {
-        $this->fareSvc->saveForPirep($pirep, $fares);
+            $this->updateCustomFields($pirep->id, $field_values);
+        }
 
         return $pirep;
     }
@@ -473,19 +404,6 @@ class PirepService extends Service
             }
         }
 
-        // Check if there is a simbrief_id, change it to be set to the PIREP
-        // at the end of the flight when it's been submitted finally.
-        // Prefile, Save (as draft) and File already have this but the Submit button
-        // visible at pireps.show blade uses this function so Simbrief also needs to
-        // checked here too (to remove the flight_id and release the aircraft)
-        if (!empty($pirep->simbrief)) {
-            /** @var SimBrief $simbrief */
-            $simbrief = SimBrief::find($pirep->simbrief->id);
-            if ($simbrief) {
-                $this->simBriefSvc->attachSimbriefToPirep($pirep, $simbrief);
-            }
-        }
-
         Log::info('New PIREP filed', [$pirep]);
         event(new PirepFiled($pirep));
 
@@ -541,41 +459,30 @@ class PirepService extends Service
      */
     public function delete(Pirep $pirep): void
     {
-        $user_id = $pirep->user_id;
-
         $w = ['pirep_id' => $pirep->id];
         PirepComment::where($w)->forceDelete();
         PirepFare::where($w)->forceDelete();
         PirepFieldValue::where($w)->forceDelete();
         SimBrief::where($w)->forceDelete();
         $pirep->forceDelete();
-
-        // Update the user's last PIREP
-        $last_pirep = Pirep::where(['user_id' => $user_id, 'state' => PirepState::ACCEPTED])
-            ->latest('submitted_at')
-            ->first();
-
-        $user = User::find($user_id);
-        $user->last_pirep_id = !empty($last_pirep) ? $last_pirep->id : null;
-        $user->save();
     }
 
     /**
      * Update any custom PIREP fields
      *
-     * @param string            $pirep_id
+     * @param       $pirep_id
-     * @param PirepFieldValue[] $field_values
+     * @param array $field_values
      */
-    public function updateCustomFields(string $pirep_id, array $field_values): void
+    public function updateCustomFields($pirep_id, array $field_values)
     {
-        if (!$field_values || empty($field_values)) {
-            return;
-        }
-
         foreach ($field_values as $fv) {
             PirepFieldValue::updateOrCreate(
-                ['pirep_id' => $pirep_id, 'name' => $fv->name],
+                ['pirep_id' => $pirep_id,
-                ['value' => $fv->value, 'source' => $fv->source]
+                    'name'  => $fv['name'],
+                ],
+                ['value'     => $fv['value'],
+                    'source' => $fv['source'],
+                ]
             );
         }
     }
@@ -588,7 +495,7 @@ class PirepService extends Service
      *
      * @return Pirep
      */
-    public function changeState(Pirep $pirep, int $new_state): Pirep
+    public function changeState(Pirep $pirep, int $new_state)
     {
         Log::info('PIREP '.$pirep->id.' state change from '.$pirep->state.' to '.$new_state);
 

app/Services/SimBriefService.php

@@ -30,9 +30,7 @@ class SimBriefService extends Service
      * @param string $ofp_id    The SimBrief OFP ID
      * @param string $flight_id The flight ID
      * @param string $ac_id     The aircraft ID
-     * @param array  $fares        Full list of fares for the flight
+     * @param array  $fares     Full list of fares for the flightß
-     * @param string $sb_userid    User's Simbrief ID (Used for Update)
-     * @param string $sb_static_id Static ID for the generated OFP (Used for Update)
      *
      * @return SimBrief|null
      */
@@ -41,18 +39,10 @@ class SimBriefService extends Service
         string $ofp_id,
         string $flight_id,
         string $ac_id,
-        array $fares = [],
+        array $fares = []
-        string $sb_user_id = null,
-        string $sb_static_id = null
     ) {
         $uri = str_replace('{id}', $ofp_id, config('phpvms.simbrief_url'));
 
-        if ($sb_user_id && $sb_static_id) {
-            // $uri = str_replace('{sb_user_id}', $sb_user_id, config('phpvms.simbrief_update_url'));
-            // $uri = str_replace('{sb_static_id}', $sb_static_id, $uri);
-            $uri = 'https://www.simbrief.com/api/xml.fetcher.php?userid='.$sb_user_id.'&static_id='.$sb_static_id;
-        }
-
         $opts = [
             'connect_timeout' => 2, // wait two seconds by default
             'allow_redirects' => false,
@@ -142,23 +132,21 @@ class SimBriefService extends Service
      *
      * 1. Read from the XML the basic PIREP info (dep, arr), and then associate the PIREP
      *    to the flight ID
-     * 2. Remove the flight ID from the SimBrief model and assign the pirep ID to the row
+     * 2. Remove the flight ID from the SimBrief field and assign the pirep_id to the row
-     *    at the end of the flight. Keep flight ID until the flight ends (pirep file).
      * 3. Update the planned flight route in the acars table
      * 4. Add additional flight fields (ones which match ACARS)
      *
      * @param          $pirep
      * @param SimBrief $simBrief The briefing to create the PIREP from
-     * @param bool     $keep_flight True keeps the flight_id, default is false
      *
      * @return \App\Models\Pirep
      */
-    public function attachSimbriefToPirep($pirep, SimBrief $simBrief, $keep_flight = false): Pirep
+    public function attachSimbriefToPirep($pirep, SimBrief $simBrief): Pirep
     {
         $this->addRouteToPirep($pirep, $simBrief);
 
         $simBrief->pirep_id = $pirep->id;
-        $simBrief->flight_id = !empty($keep_flight) ? $pirep->flight_id : null;
+        $simBrief->flight_id = null;
         $simBrief->save();
 
         return $pirep;
@@ -197,24 +185,24 @@ class SimBriefService extends Service
     }
 
     /**
-     * Remove any expired entries from the SimBrief table.
+     * Remove any expired entries from the SimBrief table. Expired means there's
-     * Expired means there's a flight_id attached to it, but no pirep_id
+     * a flight_id attached to it, but no pirep_id (meaning it was never used for
-     * (meaning it was never used for an actual flight)
+     * an actual flight)
      */
     public function removeExpiredEntries(): void
     {
-        $expire_hours = setting('simbrief.expire_hours', 6);
+        $expire_days = setting('simbrief.expire_days', 5);
-        $expire_time = Carbon::now('UTC')->subHours($expire_hours);
+        $expire_time = Carbon::now('UTC')->subDays($expire_days)->toDateTimeString();
 
         $briefs = SimBrief::where([
-            ['pirep_id', null],
+            ['pirep_id', '=', ''],
-            ['created_at', '<=', $expire_time],
+            ['created_at', '<', $expire_time],
         ])->get();
 
         foreach ($briefs as $brief) {
             $brief->delete();
 
-            // TODO: Delete any assets (Which assets ?)
+            // TODO: Delete any assets
         }
     }
 }

app/Services/UserService.php

@@ -139,6 +139,13 @@ class UserService extends Service
      */
     public function removeUser(User $user)
     {
+        $user->name = 'Deleted User';
+        $user->email = Utils::generateApiKey().'@deleted-user.com';
+        $user->api_key = Utils::generateApiKey();
+        $user->password = Hash::make(Utils::generateApiKey());
+        $user->state = UserState::DELETED;
+        $user->save();
+
         // Detach all roles from this user
         $user->detachRoles($user->roles);
 
@@ -147,18 +154,6 @@ class UserService extends Service
 
         // Remove any bids
         Bid::where('user_id', $user->id)->delete();
-
-        // If this user has PIREPs, do a soft delete. Otherwise, just delete them outright
-        if ($user->pireps->count() > 0) {
-            $user->name = 'Deleted User';
-            $user->email = Utils::generateApiKey().'@deleted-user.com';
-            $user->api_key = Utils::generateApiKey();
-            $user->password = Hash::make(Utils::generateApiKey());
-            $user->state = UserState::DELETED;
-            $user->save();
-        } else {
-            $user->delete();
-        }
     }
 
     /**
@@ -304,41 +299,49 @@ class UserService extends Service
      * currently active users. If the user doesn't have a PIREP, then the creation date
      * of the user record is used to determine the difference
      */
-    public function findUsersOnLeave()
+    public function findUsersOnLeave(): array
     {
         $leave_days = setting('pilots.auto_leave_days');
         if ($leave_days === 0) {
             return [];
         }
 
+        $return_users = [];
+
         $date = Carbon::now('UTC');
-        $users = User::where('state', UserState::ACTIVE)->get();
+        $users = User::with(['last_pirep'])->where('state', UserState::ACTIVE)->get();
 
         /** @var User $user */
-        return $users->filter(function ($user, $i) use ($date, $leave_days) {
+        foreach ($users as $user) {
-            // If any role for this user has the "disable_activity_check" feature activated, skip this user
-            foreach ($user->roles()->get() as $role) {
-                /** @var Role $role */
-                if ($role->disable_activity_checks) {
-                    return false;
-                }
-            }
-
             // If they haven't submitted a PIREP, use the date that the user was created
-            $last_pirep = Pirep::where(['user_id' => $user->id])->latest('submitted_at')->first();
+            if (!$user->last_pirep) {
-            if (!$last_pirep) {
                 $diff_date = $user->created_at;
             } else {
-                $diff_date = $last_pirep->created_at;
+                $diff_date = $user->last_pirep->submitted_at;
             }
 
             // See if the difference is larger than what the setting calls for
             if ($date->diffInDays($diff_date) <= $leave_days) {
-                return false;
+                continue;
             }
 
-            return true;
+            $skip = false;
-        });
+            // If any role for this user has the "disable_activity_check" feature activated, skip this user
+            foreach ($user->roles()->get() as $role) {
+                /** @var Role $role */
+                if ($role->disable_activity_checks) {
+                    $skip = true;
+                    break;
+                }
+            }
+
+            if ($skip) {
+                continue;
+            }
+            $return_users[] = $user;
+        }
+
+        return $return_users;
     }
 
     /**

app/Support/Discord.php

@@ -1,35 +0,0 @@
-<?php
-
-namespace App\Support;
-
-use Illuminate\Support\Facades\Log;
-
-class Discord
-{
-    /**
-     * Get a user's private channel ID from Discord
-     *
-     * @param string $discord_id
-     */
-    public static function getPrivateChannelId(string $discord_id)
-    {
-        /** @var HttpClient $httpClient */
-        $httpClient = app(HttpClient::class);
-
-        try {
-            $response = $httpClient->post(
-                'https://discord.com/api/users/@me/channels',
-                [
-                    'recipient_id' => $discord_id,
-                ]
-            );
-
-            dd($response);
-            return $response->id;
-        } catch (\Exception $ex) {
-            dd($ex);
-            Log::error('Could not get private channel id for '.$discord_id.';'.$ex->getMessage());
-            return '';
-        }
-    }
-}

app/Support/HttpClient.php

@@ -3,7 +3,6 @@
 namespace App\Support;
 
 use GuzzleHttp\Client as GuzzleClient;
-use GuzzleHttp\RequestOptions;
 
 /**
  * Helper for HTTP stuff
@@ -12,8 +11,9 @@ class HttpClient
 {
     private $httpClient;
 
-    public function __construct(GuzzleClient $httpClient)
+    public function __construct(
-    {
+        GuzzleClient $httpClient
+    ) {
         $this->httpClient = $httpClient;
     }
 
@@ -45,29 +45,6 @@ class HttpClient
         return $body;
     }
 
-    /**
-     * @param       $uri
-     * @param       $body
-     * @param array $opts
-     *
-     * @return mixed
-     */
-    public function post($uri, $body, array $opts = [])
-    {
-        $opts = array_merge([
-            'connect_timeout'    => 2,
-            RequestOptions::JSON => $body,
-        ], $opts);
-
-        $response = $this->httpClient->post($uri, $opts);
-        $content_type = $response->getHeaderLine('content-type');
-        if (strpos($content_type, 'application/json') !== false) {
-            $body = \GuzzleHttp\json_decode($body, true);
-        }
-
-        return $body;
-    }
-
     /**
      * Download a file to a given path
      *

app/Support/Resources/CustomAnonymousResourceCollection.php

@@ -1,16 +0,0 @@
-<?php
-
-namespace App\Support\Resources;
-
-use Illuminate\Http\Resources\Json\AnonymousResourceCollection;
-use Illuminate\Pagination\AbstractPaginator;
-
-class CustomAnonymousResourceCollection extends AnonymousResourceCollection
-{
-    public function toResponse($request)
-    {
-        return $this->resource instanceof AbstractPaginator
-                    ? (new CustomPaginatedResourceResponse($this))->toResponse($request)
-                    : parent::toResponse($request);
-    }
-}

app/Support/Resources/CustomPaginatedResourceResponse.php

@@ -1,33 +0,0 @@
-<?php
-
-namespace App\Support\Resources;
-
-use Illuminate\Http\Resources\Json\PaginatedResourceResponse;
-use Illuminate\Support\Arr;
-
-class CustomPaginatedResourceResponse extends PaginatedResourceResponse
-{
-    protected function paginationLinks($paginated)
-    {
-        return [
-            'first' => null,
-            'last'  => null,
-            'prev'  => null,
-            'next'  => null,
-        ];
-    }
-
-    protected function meta($paginated)
-    {
-        $meta = Arr::except($paginated, [
-            'data',
-            'first_page_url',
-            'last_page_url',
-            'prev_page_url',
-            'next_page_url',
-            'links',
-        ]);
-
-        $meta['path'] = $meta['path'] + request()->query();
-    }
-}

app/Widgets/LatestPilots.php

@@ -3,7 +3,6 @@
 namespace App\Widgets;
 
 use App\Contracts\Widget;
-use App\Models\Enums\UserState;
 use App\Repositories\UserRepository;
 
 /**
@@ -21,11 +20,10 @@ class LatestPilots extends Widget
     public function run()
     {
         $userRepo = app(UserRepository::class);
-        $userRepo = $userRepo->where('state', '!=', UserState::DELETED)->orderby('created_at', 'desc')->take($this->config['count'])->get();
 
         return view('widgets.latest_pilots', [
             'config' => $this->config,
-            'users'  => $userRepo,
+            'users'  => $userRepo->with(['airline'])->recent($this->config['count']),
         ]);
     }
 }

app/helpers.php

@@ -30,10 +30,6 @@ if (!function_exists('in_mask')) {
      */
     function in_mask($mask, $value)
     {
-        if (empty($mask)) {
-            $mask = 0;
-        }
-
         return ($mask & $value) === $value;
     }
 }
@@ -369,7 +365,7 @@ if (!function_exists('secstohhmm')) {
      */
     function secstohhmm($seconds)
     {
-        $seconds = round((float) $seconds);
+        $seconds = round($seconds);
         $hhmm = sprintf('%02d%02d', ($seconds / 3600), ($seconds / 60 % 60));
         echo $hhmm;
     }

composer.json

@@ -15,14 +15,10 @@
         "ext-bcmath": "*",
         "ext-pdo": "*",
         "ext-intl": "*",
-        "symfony/polyfill-intl-icu": "*",
-        "symfony/polyfill-intl-idn": "*",
-        "symfony/polyfill-mbstring": "*",
-        "symfony/polyfill-php74": "*",
-        "symfony/polyfill-php80": "*",
         "composer/composer": "~1.0",
         "composer/installers": "~1.0",
         "laravel/framework": "~8.0",
+        "akaunting/money": "^1.0",
         "anhskohbo/no-captcha": "^3.0",
         "appstract/laravel-opcache": "^4.0",
         "arrilot/laravel-widgets": "~3.13.0",
@@ -33,7 +29,7 @@
         "guzzlehttp/guzzle": "~6.5",
         "hashids/hashids": "^4.1.0",
         "igaster/laravel-theme": "^2.0",
-        "intervention/image": "^2.4",
+        "intervention/image": "2.4.*",
         "irazasyed/laravel-gamp": "^1.8",
         "jmikola/geojson": "1.0.*",
         "joshbrw/laravel-module-installer": "^2.0",
@@ -53,6 +49,7 @@
         "pragmarx/version": ">=v1.2.3",
         "prettus/l5-repository": "~2.7.0",
         "santigarcor/laratrust": "~6.3",
+        "sebastiaanluca/laravel-helpers": "~6.0",
         "semver/semver": "~1.1.0",
         "spatie/valuestore": "~1.2",
         "symfony/polyfill-iconv": "~1.22.0",
@@ -64,11 +61,8 @@
         "madnest/madzipper": "^1.1.0",
         "elcobvg/laravel-opcache": "^0.4.1",
         "laravel/legacy-factories": "^1.1",
-        "fakerphp/faker": "^v1.14",
+        "fakerphp/faker": "^1.13",
-        "wildbit/swiftmailer-postmark": "^3.3",
+        "wildbit/swiftmailer-postmark": "^3.3"
-        "queueworker/sansdaemon": "^1.2",
-        "jpkleemans/attribute-events": "^1.1",
-        "akaunting/laravel-money": "^1.2"
     },
     "require-dev": {
         "barryvdh/laravel-debugbar": "^3.5",

config/app.php

@@ -66,6 +66,7 @@ return [
         Collective\Html\HtmlServiceProvider::class,
         Laracasts\Flash\FlashServiceProvider::class,
         Prettus\Repository\Providers\RepositoryServiceProvider::class,
+        SebastiaanLuca\Helpers\Collections\CollectionMacrosServiceProvider::class,
         Irazasyed\LaravelGAMP\LaravelGAMPServiceProvider::class,
         Igaster\LaravelTheme\themeServiceProvider::class,
         Nwidart\Modules\LaravelModulesServiceProvider::class,

config/logging.php

@@ -40,7 +40,7 @@ return [
             'driver'   => 'stack',
             'channels' => [
                 'cron_rotating',
-                //'stdout',
+                'stdout',
             ],
         ],
         'single' => [

config/phpvms.php

@@ -52,11 +52,6 @@ return [
      */
     'simbrief_url' => 'https://www.simbrief.com/ofp/flightplans/xml/{id}.xml',
 
-    /*
-     * URL for fetching an updated Simbrief flight plan via API
-     */
-    'simbrief_update_url' => 'https://www.simbrief.com/api/xml.fetcher.php?userid={sb_user_id}&static_id={sb_static_id}',
-
     /*
      * Your vaCentral API key
      */

config/queue.php

@@ -16,11 +16,6 @@ return [
 
     'default' => env('QUEUE_DRIVER', 'sync'),
 
-    /**
-     * If you're using the queue worker, then disable running queued tasks via cron
-     */
-    'worker' => env('QUEUE_WORKER', false),
-
     /*
     |--------------------------------------------------------------------------
     | Queue Connections

config/session.php

@@ -16,7 +16,7 @@ return [
     */
 
     'driver'          => env('SESSION_DRIVER', 'file'),
-    'lifetime'        => env('SESSION_LIFETIME', 120),
+    'lifetime'        => 120,
     'expire_on_close' => false,
     'encrypt'         => false,
     'files'           => storage_path('framework/sessions'),