FGFS-4.1/simgear
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

REVIEW: Memory Leak - ChildInfo copy-ctor

Browse Source 
447,264 bytes in 39 blocks are indirectly lost
This commit is contained in:
Scott Giese
2020-08-22 14:59:27 -05:00
parent 38e38bf3d3
commit 10ffa82ea6
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
simgear/io/HTTPRepository.cxx
+3
View File
@@ -579,6 +579,9 @@ private:
if (typeData == "d") ci.type = ChildInfo::DirectoryType; if (typeData == "d") ci.type = ChildInfo::DirectoryType;
if (typeData == "t") ci.type = ChildInfo::TarballType; if (typeData == "t") ci.type = ChildInfo::TarballType;
// REVIEW: Memory Leak - 447,264 bytes in 39 blocks are indirectly lost
// emplace_back is triggering an allocation which is leading to a leak
// Implies that ci is lacking a proper copy-ctor/assignment-op
children.emplace_back(ci); children.emplace_back(ci);
children.back().path = absolutePath() / tokens[1]; children.back().path = absolutePath() / tokens[1];
if (tokens.size() > 3) { if (tokens.size() > 3) {