From e1aba1364b9899e5516ad1238f4cc3549163f31f Mon Sep 17 00:00:00 2001 From: James Turner Date: Wed, 25 May 2022 10:36:43 +0100 Subject: [PATCH] Disable the 'no shaders defined' error for now Until we have a way to mark techqniues as permanently disabled, remove this check, since it generates false positives. Especially, see model-combined technnique n=9. --- simgear/scene/material/Effect.cxx | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/simgear/scene/material/Effect.cxx b/simgear/scene/material/Effect.cxx index afd72280..78fa21fe 100644 --- a/simgear/scene/material/Effect.cxx +++ b/simgear/scene/material/Effect.cxx @@ -998,12 +998,16 @@ void ShaderProgramBuilder::buildAttribute(Effect* effect, Pass* pass, } } + // disabling this check because some effects have disabled technqiues + // with no shaders defined, intentionally. +#if 0 if (sgprogram->getNumShaders() == 0) { simgear::reportFailure(simgear::LoadFailure::BadData, simgear::ErrorCode::LoadEffectsShaders, "No shader source code defined for effect", effect->filePath()); } +#endif for (const auto& key : prgKey.attributes) { program->addBindAttribLocation(key.first, key.second);