From 0a286b427655d02cad93beb94a99cc68c3743a97 Mon Sep 17 00:00:00 2001 From: Timo <16718859+toger5@users.noreply.github.com> Date: Mon, 22 Sep 2025 12:00:45 +0200 Subject: [PATCH] Never skip lobby for huddles (#3508) (#3509) * Never skip lobby for huddles --------- Signed-off-by: Timo K --- src/UrlParams.test.ts | 6 +++--- src/UrlParams.ts | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/UrlParams.test.ts b/src/UrlParams.test.ts index 850e4091..cd8fc6d5 100644 --- a/src/UrlParams.test.ts +++ b/src/UrlParams.test.ts @@ -272,7 +272,7 @@ describe("UrlParams", () => { computeUrlParams( "?intent=start_call&widgetId=1234&parentUrl=parent.org", ), - ).toMatchObject(startNewCallDefaults("desktop")); + ).toMatchObject({ ...startNewCallDefaults("desktop"), skipLobby: false }); }); it("accepts start_call_dm mobile", () => { @@ -320,12 +320,12 @@ describe("UrlParams", () => { expect(computeUrlParams("?intent=start_call").skipLobby).toBe(false); }); - it("defaults to true if intent is start_call in widget mode", () => { + it("defaults to false if intent is start_call in widget mode", () => { expect( computeUrlParams( "?intent=start_call&widgetId=12345&parentUrl=https%3A%2F%2Flocalhost%2Ffoo", ).skipLobby, - ).toBe(true); + ).toBe(false); }); it("default to false if intent is join_existing", () => { diff --git a/src/UrlParams.ts b/src/UrlParams.ts index f6d135d7..d184a1ae 100644 --- a/src/UrlParams.ts +++ b/src/UrlParams.ts @@ -394,7 +394,7 @@ export const computeUrlParams = (search = "", hash = ""): UrlParams => { }; switch (intent) { case UserIntent.StartNewCall: - intentPreset.skipLobby = true; + intentPreset.skipLobby = false; break; case UserIntent.JoinExistingCall: // On desktop this will be overridden based on which button was used to join the call