From fbc2cd3e9797aa77fd25c60d575b5a74c4b3d781 Mon Sep 17 00:00:00 2001 From: Hugh Nimmo-Smith Date: Wed, 20 Nov 2024 10:31:36 +0000 Subject: [PATCH 1/2] Remove redundant distinctUntilChanged (#2804) Because this.scope.state() does this for us --- src/state/CallViewModel.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/src/state/CallViewModel.ts b/src/state/CallViewModel.ts index 423a0822..05bf3616 100644 --- a/src/state/CallViewModel.ts +++ b/src/state/CallViewModel.ts @@ -260,7 +260,6 @@ class UserMedia { ), ), startWith(false), - distinctUntilChanged(), // Make this Observable hot so that the timers don't reset when you // resubscribe this.scope.state(), From 826d0ee40d806ebaf3179e9f9ed8f0f1bfe42da8 Mon Sep 17 00:00:00 2001 From: Hugh Nimmo-Smith Date: Wed, 20 Nov 2024 10:32:21 +0000 Subject: [PATCH 2/2] Rxjs subjects should not be exposed (#2805) This rule will encourage us to do the right thing and better abstract. See https://github.com/cartant/eslint-plugin-rxjs/blob/main/docs/rules/no-exposed-subjects.md --- .eslintrc.cjs | 1 + 1 file changed, 1 insertion(+) diff --git a/.eslintrc.cjs b/.eslintrc.cjs index bedf1c68..31dccb6a 100644 --- a/.eslintrc.cjs +++ b/.eslintrc.cjs @@ -37,6 +37,7 @@ module.exports = { "@typescript-eslint/promise-function-async": "error", "@typescript-eslint/require-await": "error", "@typescript-eslint/await-thenable": "error", + "rxjs/no-exposed-subjects": "error", }, settings: { react: {