Matrix/element-call-Github
1
0
Fork 0
mirror of https://github.com/vector-im/element-call.git synced 2026-08-29 21:15:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add tests for openid errors

Browse Source
This commit is contained in:
Will Hunt
2025-12-11 17:35:04 +00:00
parent d2299b22f4
commit 165f638035
1 changed files with 53 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

76
src/state/CallViewModel/localMember/LocalTransport.test.ts
View File

@@ -11,11 +11,12 @@ import {
describe, describe,
expect, expect,
it, it,
MockedObject, type MockedObject,
vi, vi,
} from "vitest"; } from "vitest";
import { type CallMembership } from "matrix-js-sdk/lib/matrixrtc"; import { type CallMembership } from "matrix-js-sdk/lib/matrixrtc";
import { BehaviorSubject } from "rxjs"; import { BehaviorSubject, lastValueFrom } from "rxjs";
import fetchMock from "fetch-mock";
import { mockConfig, flushPromises } from "../../../utils/test"; import { mockConfig, flushPromises } from "../../../utils/test";
import { createLocalTransport$ } from "./LocalTransport"; import { createLocalTransport$ } from "./LocalTransport";
@@ -27,7 +28,6 @@ import {
} from "../../../utils/errors"; } from "../../../utils/errors";
import * as openIDSFU from "../../../livekit/openIDSFU"; import * as openIDSFU from "../../../livekit/openIDSFU";
import { customLivekitUrl } from "../../../settings/settings"; import { customLivekitUrl } from "../../../settings/settings";
import fetchMock from "fetch-mock";
describe("LocalTransport", () => { describe("LocalTransport", () => {
let scope: ObservableScope; let scope: ObservableScope;
@@ -188,6 +188,20 @@ describe("LocalTransport", () => {
type: "livekit", type: "livekit",
}); });
}); });
it("fails fast if the openID request fails for backend config", async () => {
localTransportOpts.client._unstable_getRTCTransports.mockResolvedValue([
{ type: "livekit", livekit_service_url: "https://lk.example.org" },
]);
openIdResolver.reject(
new FailToGetOpenIdToken(new Error("Test driven error")),
);
try {
await lastValueFrom(createLocalTransport$(localTransportOpts));
throw Error("Expected test to throw");
} catch (ex) {
expect(ex).toBeInstanceOf(FailToGetOpenIdToken);
}
});
it("supports getting transport via well-known", async () => { it("supports getting transport via well-known", async () => {
localTransportOpts.client.getDomain.mockReturnValue("example.org"); localTransportOpts.client.getDomain.mockReturnValue("example.org");
fetchMock.getOnce("https://example.org/.well-known/matrix/client", { fetchMock.getOnce("https://example.org/.well-known/matrix/client", {
@@ -206,27 +220,43 @@ describe("LocalTransport", () => {
}); });
expect(fetchMock.done()).toEqual(true); expect(fetchMock.done()).toEqual(true);
}); });
}); it("fails fast if the openId request fails for the well-known config", async () => {
localTransportOpts.client.getDomain.mockReturnValue("example.org");
it("throws if no options are available", async () => { fetchMock.getOnce("https://example.org/.well-known/matrix/client", {
const localTransport$ = createLocalTransport$({ "org.matrix.msc4143.rtc_foci": [
scope, { type: "livekit", livekit_service_url: "https://lk.example.org" },
roomId: "!room:example.org", ],
useOldestMember$: constant(false), });
memberships$: constant(new Epoch<CallMembership[]>([])), openIdResolver.reject(
client: { new FailToGetOpenIdToken(new Error("Test driven error")),
getDomain: () => "", );
// eslint-disable-next-line @typescript-eslint/naming-convention try {
_unstable_getRTCTransports: async () => Promise.resolve([]), await lastValueFrom(createLocalTransport$(localTransportOpts));
// These won't be called in this error path but satisfy the type throw Error("Expected test to throw");
getOpenIdToken: vi.fn(), } catch (ex) {
getDeviceId: vi.fn(), expect(ex).toBeInstanceOf(FailToGetOpenIdToken);
}, }
}); });
await flushPromises(); it("throws if no options are available", async () => {
const localTransport$ = createLocalTransport$({
scope,
roomId: "!room:example.org",
useOldestMember$: constant(false),
memberships$: constant(new Epoch<CallMembership[]>([])),
client: {
getDomain: () => "",
// eslint-disable-next-line @typescript-eslint/naming-convention
_unstable_getRTCTransports: async () => Promise.resolve([]),
// These won't be called in this error path but satisfy the type
getOpenIdToken: vi.fn(),
getDeviceId: vi.fn(),
},
});
await flushPromises();
expect(() => localTransport$.value).toThrow( expect(() => localTransport$.value).toThrow(
new MatrixRTCTransportMissingError(""), new MatrixRTCTransportMissingError(""),
); );
});
}); });
}); });