From 1e400bc5502bee7f46e6a658fe55cb39cc34c369 Mon Sep 17 00:00:00 2001 From: Timo K Date: Tue, 10 Mar 2026 18:26:12 +0100 Subject: [PATCH] remove unsused import --- .../pip-call-button-interaction.test.ts | 93 +++++++++---------- 1 file changed, 45 insertions(+), 48 deletions(-) diff --git a/playwright/widget/pip-call-button-interaction.test.ts b/playwright/widget/pip-call-button-interaction.test.ts index 77659672..84cee3fa 100644 --- a/playwright/widget/pip-call-button-interaction.test.ts +++ b/playwright/widget/pip-call-button-interaction.test.ts @@ -10,62 +10,59 @@ import { expect, test } from "@playwright/test"; import { widgetTest } from "../fixtures/widget-user.ts"; import { HOST1, TestHelpers } from "./test-helpers.ts"; -widgetTest( - "Footer interaction in PiP", - async ({ addUser, browserName, page }) => { - test.skip( - browserName === "firefox", - "The is test is not working on firefox CI environment. No mic/audio device inputs so cam/mic are disabled", - ); +widgetTest("Footer interaction in PiP", async ({ addUser, browserName }) => { + test.skip( + browserName === "firefox", + "The is test is not working on firefox CI environment. No mic/audio device inputs so cam/mic are disabled", + ); - test.slow(); + test.slow(); - const valere = await addUser("Valere", HOST1); + const valere = await addUser("Valere", HOST1); + await valere.page.pause(); + const callRoom = "CallRoom"; + await TestHelpers.createRoom("CallRoom", valere.page); - const callRoom = "CallRoom"; - await TestHelpers.createRoom("CallRoom", valere.page); + await TestHelpers.createRoom("OtherRoom", valere.page); - await TestHelpers.createRoom("OtherRoom", valere.page); + await TestHelpers.switchToRoomNamed(valere.page, callRoom); - await TestHelpers.switchToRoomNamed(valere.page, callRoom); + // Start the call as Valere + await TestHelpers.startCallInCurrentRoom(valere.page, false); + await expect( + valere.page.locator('iframe[title="Element Call"]'), + ).toBeVisible(); - // Start the call as Valere - await TestHelpers.startCallInCurrentRoom(valere.page, false); - await expect( - valere.page.locator('iframe[title="Element Call"]'), - ).toBeVisible(); + await TestHelpers.joinCallFromLobby(valere.page); + // wait a bit so that the PIP has rendered + await valere.page.waitForTimeout(600); - await TestHelpers.joinCallFromLobby(valere.page); - // wait a bit so that the PIP has rendered - await valere.page.waitForTimeout(600); + // Switch to the other room, the call should go to PIP + await TestHelpers.switchToRoomNamed(valere.page, "OtherRoom"); - // Switch to the other room, the call should go to PIP - await TestHelpers.switchToRoomNamed(valere.page, "OtherRoom"); + // We should see the PIP overlay + const iFrame = valere.page + .locator('iframe[title="Element Call"]') + .contentFrame(); - // We should see the PIP overlay - const iFrame = valere.page - .locator('iframe[title="Element Call"]') - .contentFrame(); + { + // Check for a bug where the video had the wrong fit in PIP + const hangupButton = iFrame.getByRole("button", { name: "End call" }); + const videoMuteButton = iFrame.getByRole("button", { + name: "Stop video", + }); + const audioMuteButton = iFrame.getByRole("button", { + name: "Mute microphone", + }); + await expect(hangupButton).toBeVisible(); + await expect(videoMuteButton).toBeVisible(); + await expect(audioMuteButton).toBeVisible(); - { - // Check for a bug where the video had the wrong fit in PIP - const hangupButton = iFrame.getByRole("button", { name: "End call" }); - const videoMuteButton = iFrame.getByRole("button", { - name: "Stop video", - }); - const audioMuteButton = iFrame.getByRole("button", { - name: "Mute microphone", - }); - await expect(hangupButton).toBeVisible(); - await expect(videoMuteButton).toBeVisible(); - await expect(audioMuteButton).toBeVisible(); + // TODO once we have the EW version that supports the interactive pip element we can activate those checks + // await videoMuteButton.click(); + // await audioMuteButton.click(); - // TODO once we have the EW version that supports the interactive pip element we can activate those checks - // await videoMuteButton.click(); - // await audioMuteButton.click(); - - // await expect(videoMuteButton).toHaveCSS("disabled", "true"); - // await expect(audioMuteButton).toHaveCSS("disabled", "true"); - } - }, -); + // await expect(videoMuteButton).toHaveCSS("disabled", "true"); + // await expect(audioMuteButton).toHaveCSS("disabled", "true"); + } +});