From 207b161b3ba25a7eae243a741c0fb7c3dfaf8eb9 Mon Sep 17 00:00:00 2001 From: Timo K Date: Thu, 11 Dec 2025 17:17:56 +0100 Subject: [PATCH] fix logger and dismiss button presses --- playwright/fixtures/widget-user.ts | 10 +++++++++- src/room/GroupCallView.tsx | 1 - src/room/InCallView.tsx | 4 +++- 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/playwright/fixtures/widget-user.ts b/playwright/fixtures/widget-user.ts index b0c46788..51dffbc6 100644 --- a/playwright/fixtures/widget-user.ts +++ b/playwright/fixtures/widget-user.ts @@ -126,8 +126,16 @@ async function registerUser( page.getByRole("heading", { name: `Welcome ${username}` }), ).toBeVisible(); + await page.pause(); + const browserUnsupportedToast = page + .getByText("Element does not support this browser") + .locator("..") + .locator(".."); + // Dismiss incompatible browser toast - const dismissButton = page.getByRole("button", { name: "Dismiss" }); + const dismissButton = browserUnsupportedToast.getByRole("button", { + name: "Dismiss", + }); try { await expect(dismissButton).toBeVisible({ timeout: 700 }); await dismissButton.click(); diff --git a/src/room/GroupCallView.tsx b/src/room/GroupCallView.tsx index 1542678e..dfd11ff3 100644 --- a/src/room/GroupCallView.tsx +++ b/src/room/GroupCallView.tsx @@ -446,7 +446,6 @@ export const GroupCallView: FC = ({ let body: ReactNode; if (externalError) { - logger.debug("External error occurred:", externalError); // If an error was recorded within this component but outside // GroupCallErrorBoundary, create a component that rethrows the error from // within the error boundary, so it can be handled uniformly diff --git a/src/room/InCallView.tsx b/src/room/InCallView.tsx index 18acf843..add8154a 100644 --- a/src/room/InCallView.tsx +++ b/src/room/InCallView.tsx @@ -24,7 +24,7 @@ import { type MatrixRTCSession } from "matrix-js-sdk/lib/matrixrtc"; import classNames from "classnames"; import { BehaviorSubject, map } from "rxjs"; import { useObservable } from "observable-hooks"; -import { logger } from "matrix-js-sdk/lib/logger"; +import { logger as rootLogger } from "matrix-js-sdk/lib/logger"; import { VoiceCallSolidIcon, VolumeOnSolidIcon, @@ -109,6 +109,8 @@ import { useTrackProcessorObservable$ } from "../livekit/TrackProcessorContext.t import { type Layout } from "../state/layout-types.ts"; import { ObservableScope } from "../state/ObservableScope.ts"; +const logger = rootLogger.getChild("[InCallView]"); + const maxTapDurationMs = 400; export interface ActiveCallProps