From 22f16174efebac62f917ab74589a86f47dea6d83 Mon Sep 17 00:00:00 2001 From: fkwp Date: Mon, 4 May 2026 09:16:55 +0200 Subject: [PATCH] addressing review comments --- config/config.sample.json | 1 - src/config/ConfigOptions.ts | 1 + src/state/CallViewModel/localMember/HomeserverConnected.ts | 3 +-- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/config/config.sample.json b/config/config.sample.json index bb0e4dfd..126d7626 100644 --- a/config/config.sample.json +++ b/config/config.sample.json @@ -12,7 +12,6 @@ "feature_use_device_session_member_events": true }, "ssla": "https://static.element.io/legal/element-software-and-services-license-agreement-uk-1.pdf", - "sync_disconnect_grace_period_ms": 10000, "matrix_rtc_session": { "wait_for_key_rotation_ms": 3000, "membership_event_expiry_ms": 180000000, diff --git a/src/config/ConfigOptions.ts b/src/config/ConfigOptions.ts index 1781dc97..93403a96 100644 --- a/src/config/ConfigOptions.ts +++ b/src/config/ConfigOptions.ts @@ -162,6 +162,7 @@ export interface ResolvedConfigOptions extends ConfigOptions { server_name: string; }; }; + sync_disconnect_grace_period_ms: number; ssla: string; } diff --git a/src/state/CallViewModel/localMember/HomeserverConnected.ts b/src/state/CallViewModel/localMember/HomeserverConnected.ts index 06d660be..445a4d2a 100644 --- a/src/state/CallViewModel/localMember/HomeserverConnected.ts +++ b/src/state/CallViewModel/localMember/HomeserverConnected.ts @@ -64,8 +64,7 @@ export function createHomeserverConnected$( gracePeriodMs?: number, ): HomeserverConnected { // Get grace period from parameter or config (default 10000ms) - const graceMs = - gracePeriodMs ?? Config.get().sync_disconnect_grace_period_ms ?? 10000; + const graceMs = gracePeriodMs ?? Config.get().sync_disconnect_grace_period_ms; const syncing$ = ( fromEvent(client, ClientEvent.Sync) as Observable<[SyncState]>