From 2817362e15b37be0606b4eba6b2b62f7167fcd8d Mon Sep 17 00:00:00 2001 From: Valere Date: Mon, 19 Jan 2026 11:46:17 +0100 Subject: [PATCH] Do not end call with error in case of MediaDeviceError --- src/state/CallViewModel/localMember/LocalMember.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/state/CallViewModel/localMember/LocalMember.ts b/src/state/CallViewModel/localMember/LocalMember.ts index 44b6c63b..f5f883f9 100644 --- a/src/state/CallViewModel/localMember/LocalMember.ts +++ b/src/state/CallViewModel/localMember/LocalMember.ts @@ -266,11 +266,11 @@ export const createLocalMembership$ = ({ mediaErrors$.pipe(scope.bind()).subscribe((error) => { if (error) { + // This is a MediaDevice error, can be PermissionDenied, NotFound, DeviceInUse, Other. + // Will also occurs if you cancel screen sharing browser prompt. + // This is not necessarily fatal, since the user might be able to join without media. + // XXX We might want to give some user feedback here to let them know their media is not working. logger.error(`Failed to create local tracks:`, error); - setMatrixError( - // TODO is it fatal? Do we need to create a new Specialized Error? - new UnknownCallError(new Error(`Media device error: ${error}`)), - ); } }); // MATRIX RELATED