Keep the CI sdk package name so main's preview deploy finds it

ploy previews run pr-deploy.yaml from main, which downloads
build-output-sdk,
so a renamed artifact can never be found from a pull request. Keep the
package
name and point build:sdk:production and build:sdk:development at the
CallViewModel bundle the preview is meant to carry.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This commit is contained in:
Timo K.
2026-10-13 19:04:02 +02:00
co-authored by Claude Fable 5.1
parent 27dcfb8bb7
commit 28e1a9e22f
7 changed files with 17 additions and 8 deletions
@@ -64,5 +64,6 @@ jobs:
with: with:
name: build-output-${{ inputs.package }} name: build-output-${{ inputs.package }}
path: dist path: dist
if-no-files-found: error
# We'll only use this in a triggered job, then we're done with it # We'll only use this in a triggered job, then we're done with it
retention-days: 1 retention-days: 1
+4 -1
View File
@@ -73,7 +73,10 @@ jobs:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
build_sdk_element_call: build_sdk_element_call:
# Use the embedded package vite build # The 'sdk' package is the CallViewModel bundle that predates the sdk/
# package (build:sdk:production, sdk-target-based-on-call-view-model/), not
# the package itself. The name is shared with pr-deploy.yaml, which always
# runs from main, so it stays until the bundle's consumers have moved over.
uses: ./.github/workflows/build-element-call.yaml uses: ./.github/workflows/build-element-call.yaml
with: with:
package: sdk package: sdk
+3 -1
View File
@@ -78,7 +78,9 @@ Code that builds in only one is a bug.
`pnpm lint:externals`). Interface only so far; the design is `sdk-plan.md`. `pnpm lint:externals`). Interface only so far; the design is `sdk-plan.md`.
- `build:sdk-target-based-on-call-view-model` — the SDK demo that predates the - `build:sdk-target-based-on-call-view-model` — the SDK demo that predates the
package, one bundle of the `CallViewModel`; entry package, one bundle of the `CallViewModel`; entry
`sdk-target-based-on-call-view-model/main.ts`. `sdk-target-based-on-call-view-model/main.ts`. CI's `sdk` package
(`build:sdk:production` / `build:sdk:development`, the Netlify `-sdk` preview)
is still this bundle, not `build:sdk`.
- `build:component` — `@element-hq/element-call-component`, sources in `component/` - `build:component` — `@element-hq/element-call-component`, sources in `component/`
(its own pnpm project; run pnpm from the repo root). Host API is in the README; (its own pnpm project; run pnpm from the repo root). Host API is in the README;
`pnpm lint:externals` rejects an import of a `react` / `react-dom` / `pnpm lint:externals` rejects an import of a `react` / `react-dom` /
+2 -2
View File
@@ -18,9 +18,9 @@
"build:sdk": "pnpm build:sdk:js && pnpm build:sdk:types", "build:sdk": "pnpm build:sdk:js && pnpm build:sdk:types",
"build:sdk:js": "pnpm build:full --config vite-sdk.config.js", "build:sdk:js": "pnpm build:full --config vite-sdk.config.js",
"build:sdk:types": "tsc -p sdk/tsconfig.build.json", "build:sdk:types": "tsc -p sdk/tsconfig.build.json",
"build:sdk:production": "pnpm build:sdk",
"build:sdk:development": "pnpm build:sdk:js --mode development && pnpm build:sdk:types",
"build:sdk-target-based-on-call-view-model": "pnpm build:full --config vite-sdk-target-based-on-call-view-model.config.js", "build:sdk-target-based-on-call-view-model": "pnpm build:full --config vite-sdk-target-based-on-call-view-model.config.js",
"build:sdk:production": "pnpm build:sdk-target-based-on-call-view-model",
"build:sdk:development": "pnpm build:sdk-target-based-on-call-view-model --mode development",
"build:component": "pnpm build:component:js && pnpm build:component:types", "build:component": "pnpm build:component:js && pnpm build:component:types",
"build:component:js": "pnpm build:full --config vite-component.config.js", "build:component:js": "pnpm build:full --config vite-component.config.js",
"build:component:types": "tsc -p component/tsconfig.build.json", "build:component:types": "tsc -p component/tsconfig.build.json",
@@ -23,8 +23,11 @@ pnpm build:sdk-target-based-on-call-view-model
in the repository root. (`pnpm build:sdk` builds the `sdk/` package instead.) in the repository root. (`pnpm build:sdk` builds the `sdk/` package instead.)
It will create `sdk-target-based-on-call-view-model/dist` containing the compiled js CI's `sdk` package (`build:sdk:production`, `build:sdk:development`, the
file, `matrixrtc-sdk.js`. `build-output-sdk` artifact and the `pr<N>-sdk` Netlify preview) is still this
bundle, not the `sdk/` package, until its consumers have moved over.
It will create `dist` containing the compiled js file, `matrixrtc-sdk.js`.
This file needs to be hosted. Locally (via `npx serve -l 81234 --cors`) or on a remote server. This file needs to be hosted. Locally (via `npx serve -l 81234 --cors`) or on a remote server.
+2 -1
View File
@@ -8,7 +8,8 @@ Please see LICENSE in the repository root for full details.
/** /**
* EXPERIMENTAL * EXPERIMENTAL
* *
* This file is the entrypoint for the sdk build of element call: `pnpm build:sdk` * This file is the entrypoint for the sdk build of element call:
* `pnpm build:sdk-target-based-on-call-view-model`
* use in widgets. * use in widgets.
* It exposes the `createMatrixRTCSdk` which creates the `MatrixRTCSdk` interface (see below) that * It exposes the `createMatrixRTCSdk` which creates the `MatrixRTCSdk` interface (see below) that
* can be used to join a rtc session and exchange realtime data. * can be used to join a rtc session and exchange realtime data.
@@ -18,7 +18,6 @@ export default defineConfig(() => ({
// Otherwise the developer's own config.json in `public` is copied into the output // Otherwise the developer's own config.json in `public` is copied into the output
publicDir: false, publicDir: false,
build: { build: {
outDir: "sdk-target-based-on-call-view-model/dist",
sourcemap: true, sourcemap: true,
manifest: true, manifest: true,
lib: { lib: {