Matrix/element-call-Github
1
0
Fork 0
mirror of https://github.com/vector-im/element-call.git synced 2026-08-08 20:09:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

Simplify reaction sounds

Browse Source
This commit is contained in:
Half-Shot
2024-12-03 14:46:06 +00:00
parent 0c331a05ad
commit 2a45be88e9
2 changed files with 8 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/room/CallEventAudioRenderer.tsx
View File

@@ -72,8 +72,8 @@ export function CallEventAudioRenderer({
({ joined, ids }) => ({ joined, ids }) =>
ids.length <= MAX_PARTICIPANT_COUNT_FOR_SOUND && joined.length > 0, ids.length <= MAX_PARTICIPANT_COUNT_FOR_SOUND && joined.length > 0,
), ),
throttle((_) => interval(THROTTLE_SOUND_EFFECT_MS)), throttle(() => interval(THROTTLE_SOUND_EFFECT_MS)),
debounce((_) => interval(DEBOUNCE_SOUND_EFFECT_MS)), debounce(() => interval(DEBOUNCE_SOUND_EFFECT_MS)),
) )
.subscribe((prev) => { .subscribe((prev) => {
console.log("Playing join sound for", ...prev.joined, "|", prev); console.log("Playing join sound for", ...prev.joined, "|", prev);
@@ -86,8 +86,8 @@ export function CallEventAudioRenderer({
({ ids, left }) => ({ ids, left }) =>
ids.length <= MAX_PARTICIPANT_COUNT_FOR_SOUND && left.length > 0, ids.length <= MAX_PARTICIPANT_COUNT_FOR_SOUND && left.length > 0,
), ),
throttle((_) => interval(THROTTLE_SOUND_EFFECT_MS)), throttle(() => interval(THROTTLE_SOUND_EFFECT_MS)),
debounce((_) => interval(DEBOUNCE_SOUND_EFFECT_MS)), debounce(() => interval(DEBOUNCE_SOUND_EFFECT_MS)),
) )
.subscribe(() => { .subscribe(() => {
audioEngineCtx.playSound("left"); audioEngineCtx.playSound("left");

13
src/room/ReactionAudioRenderer.tsx
View File

@@ -38,18 +38,13 @@ export function ReactionsAudioRenderer(): ReactNode {
if (!shouldPlay) { if (!shouldPlay) {
return; return;
} }
const oldReactionSet = new Set( for (const [sender, reaction] of Object.entries(reactions)) {
Object.values(oldReactions).map((r) => r.name), if (oldReactions[sender]) {
);
for (const reactionName of new Set(
Object.values(reactions).map((r) => r.name),
)) {
if (oldReactionSet.has(reactionName)) {
// Don't replay old reactions // Don't replay old reactions
return; return;
} }
if (SoundMap[reactionName]) { if (SoundMap[reaction.name]) {
audioEngineCtx.playSound(reactionName); audioEngineCtx.playSound(reaction.name);
} else { } else {
// Fallback sounds. // Fallback sounds.
audioEngineCtx.playSound("generic"); audioEngineCtx.playSound("generic");