From 3a189d155bc9b5c8c13e300833135bb8d4d938b3 Mon Sep 17 00:00:00 2001 From: Robin Date: Tue, 22 Sep 2026 09:56:02 +0200 Subject: [PATCH] Remove references to outdated variables or types --- src/state/CallViewModel/localMember/LocalMember.ts | 2 +- .../CallViewModel/remoteMembers/ConnectionManager.ts | 3 ++- src/state/SessionBehaviors.ts | 12 ++++-------- 3 files changed, 7 insertions(+), 10 deletions(-) diff --git a/src/state/CallViewModel/localMember/LocalMember.ts b/src/state/CallViewModel/localMember/LocalMember.ts index bf5080902..9622ace9e 100644 --- a/src/state/CallViewModel/localMember/LocalMember.ts +++ b/src/state/CallViewModel/localMember/LocalMember.ts @@ -658,7 +658,7 @@ export const createLocalMembership$ = ({ }); }); - // Keep matrix rtc session in sync with advertisedTransport$, connectRequested$ + // Join and leave the session as needed scope.reconcile( scope.behavior(combineLatest([joinParams$, joinAndPublishRequested$])), async ([joinParams, shouldConnect]) => { diff --git a/src/state/CallViewModel/remoteMembers/ConnectionManager.ts b/src/state/CallViewModel/remoteMembers/ConnectionManager.ts index 4af08b49b..35418fdf0 100644 --- a/src/state/CallViewModel/remoteMembers/ConnectionManager.ts +++ b/src/state/CallViewModel/remoteMembers/ConnectionManager.ts @@ -179,7 +179,8 @@ export function createConnectionManager$({ function* (transports) { for (const transport of transports) { if (isLocalTransport(transport)) { - // This is the local transport; only the `LocalTransportWithSFUConfig` has a `sfuConfig` field. + // This is the local transport; only the `LocalTransport` + // interface has a `sfuConfig` field. yield { keys: [ transport.transport.livekit_service_url, diff --git a/src/state/SessionBehaviors.ts b/src/state/SessionBehaviors.ts index 784e33666..8d3986b68 100644 --- a/src/state/SessionBehaviors.ts +++ b/src/state/SessionBehaviors.ts @@ -22,6 +22,10 @@ import { } from "./ObservableScope"; import { type Behavior } from "./Behavior"; +/** + * Tracks the transports used by ourselves, plus all other MatrixRTC session + * members. + */ export const membershipsAndTransports$ = ( scope: ObservableScope, memberships$: Behavior>, @@ -31,14 +35,6 @@ export const membershipsAndTransports$ = ( >; transports$: Behavior>; } => { - /** - * Lists the transports used by ourselves, plus all other MatrixRTC session - * members. - * For completeness this also lists the preferred transport and - * whether we are in multi-SFU mode or sticky events mode. - * `advertisedTransport$` reads these values together, so bundling them avoids inconsistent state or - * excessive updates when using RxJS. - */ const membershipsWithTransport$: Behavior< Epoch< {