From 43f1b89535b184ad4cbc8677bf0b795c75b1fab3 Mon Sep 17 00:00:00 2001
From: Robin <robin@robin.town>
Date: Wed, 20 May 2026 12:38:18 +0200
Subject: [PATCH] Stop the settings button from appearing while footer is
 fading out

The designs actually never want us to show the settings button in the footer if an app bar is in use (as in Element X mobile apps), so just avoid showing it at all in that case.
---
 src/room/InCallView.tsx | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/room/InCallView.tsx b/src/room/InCallView.tsx
index 49e7abfc..87db59bf 100644
--- a/src/room/InCallView.tsx
+++ b/src/room/InCallView.tsx
@@ -570,8 +570,6 @@ export const InCallView: FC<InCallViewProps> = ({
     matrixRoom.roomId,
   );
 
-  const settingsButtonInAppBar =
-    headerStyle === HeaderStyle.AppBar && showHeader;
   useAppBarSecondaryButton(
     <SettingsIconButton
       key="settings"
@@ -603,7 +601,9 @@ export const InCallView: FC<InCallViewProps> = ({
       audioOutputSwitcher={audioOutputSwitcher ?? undefined}
       // Only pass the openSettings function if the settings button is not in the app bar.
       // If there is no fn the button will be hidden in the footer.
-      openSettings={settingsButtonInAppBar ? undefined : openSettings}
+      openSettings={
+        headerStyle === HeaderStyle.AppBar ? undefined : openSettings
+      }
       hangup={vm.hangup}
       //Debug props
       debugTileLayout={debugTileLayout}