From 58f430eb324415146de81b077b9cc5419790aa16 Mon Sep 17 00:00:00 2001 From: Timo K Date: Mon, 4 May 2026 18:25:04 +0200 Subject: [PATCH] review --- src/room/InCallView.tsx | 2 -- src/useCallViewKeyboardShortcuts.ts | 3 +++ 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/room/InCallView.tsx b/src/room/InCallView.tsx index d1cfdf10..7fc97e27 100644 --- a/src/room/InCallView.tsx +++ b/src/room/InCallView.tsx @@ -227,8 +227,6 @@ export const InCallView: FC = ({ const toggleVideo = useBehavior(muteStates.video.toggle$); const setAudioEnabled = useBehavior(muteStates.audio.setEnabled$); - // This function incorrectly assumes that there is a camera and microphone, which is not always the case. - // TODO: Make sure that this module is resilient when it comes to camera/microphone availability! useCallViewKeyboardShortcuts( toggleAudio, toggleVideo, diff --git a/src/useCallViewKeyboardShortcuts.ts b/src/useCallViewKeyboardShortcuts.ts index 32b253a2..9022d22f 100644 --- a/src/useCallViewKeyboardShortcuts.ts +++ b/src/useCallViewKeyboardShortcuts.ts @@ -64,7 +64,10 @@ const KeyToReactionMap: Record = Object.fromEntries( * @param sendReaction - triggered on (1,2,3,...) * @param toggleHandRaised - triggered on (h) * Additionally this method listens to the (escape) key to trigger the onBackButtonPressed callback, which is used to navigate to pip in the native app. + * + * Note: This function incorrectly assumes that there is a camera and microphone, which is not always the case. */ +// TODO: Make sure that this module is resilient when it comes to camera/microphone availability! export function useCallViewKeyboardShortcuts( toggleAudio: (() => void) | null, toggleVideo: (() => void) | null,