From 6c81f695908df923e7c43ca5bcd05a379256f132 Mon Sep 17 00:00:00 2001
From: Hugh Nimmo-Smith <hughns@users.noreply.github.com>
Date: Wed, 11 Dec 2024 14:30:16 +0000
Subject: [PATCH] Rename developerSettingsTab to developerMode for consistency
 (#2889)

---
 src/settings/PreferencesSettingsTab.tsx | 10 ++++------
 src/settings/SettingsModal.tsx          |  4 ++--
 src/settings/settings.ts                |  5 +----
 3 files changed, 7 insertions(+), 12 deletions(-)

diff --git a/src/settings/PreferencesSettingsTab.tsx b/src/settings/PreferencesSettingsTab.tsx
index bdf021b4..fd4be1ae 100644
--- a/src/settings/PreferencesSettingsTab.tsx
+++ b/src/settings/PreferencesSettingsTab.tsx
@@ -14,7 +14,7 @@ import {
   showHandRaisedTimer as showHandRaisedTimerSetting,
   showReactions as showReactionsSetting,
   playReactionsSound as playReactionsSoundSetting,
-  developerSettingsTab as developerSettingsTabSetting,
+  developerMode as developerModeSetting,
   useSetting,
 } from "./settings";
 
@@ -37,9 +37,7 @@ export const PreferencesSettingsTab: FC = () => {
     fn(e.target.checked);
   };
 
-  const [developerSettingsTab, setDeveloperSettingsTab] = useSetting(
-    developerSettingsTabSetting,
-  );
+  const [developerMode, setDeveloperMode] = useSetting(developerModeSetting);
 
   return (
     <div>
@@ -82,13 +80,13 @@ export const PreferencesSettingsTab: FC = () => {
         <InputField
           id="developerSettingsTab"
           type="checkbox"
-          checked={developerSettingsTab}
+          checked={developerMode}
           label={t("settings.preferences_tab.developer_mode_label")}
           description={t(
             "settings.preferences_tab.developer_mode_label_description",
           )}
           onChange={(event: ChangeEvent<HTMLInputElement>): void =>
-            setDeveloperSettingsTab(event.target.checked)
+            setDeveloperMode(event.target.checked)
           }
         />
       </FieldRow>
diff --git a/src/settings/SettingsModal.tsx b/src/settings/SettingsModal.tsx
index f3936a31..c1466e8a 100644
--- a/src/settings/SettingsModal.tsx
+++ b/src/settings/SettingsModal.tsx
@@ -23,7 +23,7 @@ import { widget } from "../widget";
 import {
   useSetting,
   soundEffectVolumeSetting,
-  developerSettingsTab,
+  developerMode,
 } from "./settings";
 import { isFirefox } from "../Platform";
 import { PreferencesSettingsTab } from "./PreferencesSettingsTab";
@@ -66,7 +66,7 @@ export const SettingsModal: FC<Props> = ({
   const [soundVolume, setSoundVolume] = useSetting(soundEffectVolumeSetting);
   const [soundVolumeRaw, setSoundVolumeRaw] = useState(soundVolume);
 
-  const [showDeveloperSettingsTab] = useSetting(developerSettingsTab);
+  const [showDeveloperSettingsTab] = useSetting(developerMode);
 
   const audioTab: Tab<SettingsTab> = {
     key: "audio",
diff --git a/src/settings/settings.ts b/src/settings/settings.ts
index 63c38a57..e8dda379 100644
--- a/src/settings/settings.ts
+++ b/src/settings/settings.ts
@@ -68,10 +68,7 @@ export const useOptInAnalytics = (): [
   return PosthogAnalytics.instance.isEnabled() ? setting : [false, null];
 };
 
-export const developerSettingsTab = new Setting(
-  "developer-settings-tab",
-  false,
-);
+export const developerMode = new Setting("developer-settings-tab", false);
 
 export const duplicateTiles = new Setting("duplicate-tiles", 0);