From 7532f72c9094926cb3971680b437f76221fd955c Mon Sep 17 00:00:00 2001
From: Timo K <toger5@hotmail.de>
Date: Fri, 21 Nov 2025 18:49:30 +0100
Subject: [PATCH] use edit in place (WIP) This is WIP since it will submite ->
 reload the page onSave

---
 locales/en/app.json                           | 10 ++-
 src/settings/DeveloperSettingsTab.tsx         | 83 +++++++++----------
 .../DeveloperSettingsTab.test.tsx.snap        | 76 +++++++----------
 3 files changed, 75 insertions(+), 94 deletions(-)

diff --git a/locales/en/app.json b/locales/en/app.json
index 8bc121bd..4d3d5d6c 100644
--- a/locales/en/app.json
+++ b/locales/en/app.json
@@ -64,7 +64,14 @@
   "developer_mode": {
     "always_show_iphone_earpiece": "Show iPhone earpiece option on all platforms",
     "crypto_version": "Crypto version: {{version}}",
-    "custom_livekit_url": "Custom Livekit-url",
+    "custom_livekit_url": {
+      "current_url": "Overwrite: ",
+      "from_config": "Currently, no overwrite is set. Url from well-known or config is used.",
+      "label": "Custom Livekit-url",
+      "reset": "Reset overwrite",
+      "save": "Save",
+      "saving": "Saving..."
+    },
     "debug_tile_layout_label": "Debug tile layout",
     "device_id": "Device ID: {{id}}",
     "duplicate_tiles_label": "Number of additional tile copies per participant",
@@ -90,7 +97,6 @@
     },
     "mute_all_audio": "Mute all audio (participants, reactions, join sounds)",
     "show_connection_stats": "Show connection statistics",
-    "update": "Update",
     "url_params": "URL parameters"
   },
   "disconnected_banner": "Connectivity to the server has been lost.",
diff --git a/src/settings/DeveloperSettingsTab.tsx b/src/settings/DeveloperSettingsTab.tsx
index 5374b978..ed022370 100644
--- a/src/settings/DeveloperSettingsTab.tsx
+++ b/src/settings/DeveloperSettingsTab.tsx
@@ -21,7 +21,7 @@ import {
 } from "matrix-js-sdk";
 import { logger } from "matrix-js-sdk/lib/logger";
 import {
-  Button,
+  EditInPlace,
   Root as Form,
   Heading,
   HelpMessage,
@@ -114,7 +114,7 @@ export const DeveloperSettingsTab: FC<Props> = ({
   }, [livekitRooms]);
 
   return (
-    <Form>
+    <Form onSubmit={(e) => e.preventDefault()}>
       <p>
         {t("developer_mode.hostname", {
           hostname: window.location.hostname || "unknown",
@@ -213,48 +213,43 @@ export const DeveloperSettingsTab: FC<Props> = ({
           )}
         />{" "}
       </FieldRow>
-      {/*// TODO this feels a bit off... There has to be better way to create the desired look.
-        Also the indent should be further to the left...*/}
-      <InlineField
-        name={t("developer_mode.custom_livekit_url")}
-        control={<></>}
-      >
-        <Label>{t("developer_mode.custom_livekit_url")}</Label>
-        <HelpMessage>
-          {customLivekitUrl === null
-            ? "Use Default"
-            : `Current:${customLivekitUrl}`}
-        </HelpMessage>
-      </InlineField>
-      <FieldRow>
-        <InputField
-          id="customLivekitUrl"
-          type="text"
-          label={t("developer_mode.custom_livekit_url")}
-          value={customLivekitUrlTextBuffer}
-          onChange={useCallback(
-            (event: ChangeEvent<HTMLInputElement>): void => {
-              setCustomLivekitUrlTextBuffer(event.target.value);
-            },
-            [setCustomLivekitUrlTextBuffer],
-          )}
-        />
-        <Button
-          onClick={useCallback(
-            (e: React.MouseEvent<HTMLButtonElement, MouseEvent>) => {
-              e.preventDefault();
-              setCustomLivekitUrl(
-                customLivekitUrlTextBuffer === ""
-                  ? null
-                  : customLivekitUrlTextBuffer,
-              );
-            },
-            [setCustomLivekitUrl, customLivekitUrlTextBuffer],
-          )}
-        >
-          {t("developer_mode.update")}
-        </Button>
-      </FieldRow>
+      <EditInPlace
+        onSubmit={(e) => e.preventDefault()}
+        helpLabel={
+          customLivekitUrl === null
+            ? t("developer_mode.custom_livekit_url.from_config")
+            : t("developer_mode.custom_livekit_url.current_url") +
+              customLivekitUrl
+        }
+        label={t("developer_mode.custom_livekit_url.label")}
+        saveButtonLabel={t("developer_mode.custom_livekit_url.save")}
+        savingLabel={t("developer_mode.custom_livekit_url.saving")}
+        cancelButtonLabel={t("developer_mode.custom_livekit_url.reset")}
+        onSave={useCallback(
+          (e: React.FormEvent<HTMLFormElement>) => {
+            // e.preventDefault();
+            setCustomLivekitUrl(
+              customLivekitUrlTextBuffer === ""
+                ? null
+                : customLivekitUrlTextBuffer,
+            );
+          },
+          [setCustomLivekitUrl, customLivekitUrlTextBuffer],
+        )}
+        onChange={useCallback(
+          (event: ChangeEvent<HTMLInputElement>): void => {
+            setCustomLivekitUrlTextBuffer(event.target.value);
+          },
+          [setCustomLivekitUrlTextBuffer],
+        )}
+        onCancel={useCallback(
+          (e: React.FormEvent<HTMLFormElement>) => {
+            // e.preventDefault();
+            setCustomLivekitUrl(null);
+          },
+          [setCustomLivekitUrl],
+        )}
+      />
       <Heading as="h3" type="body" weight="semibold" size="lg">
         {t("developer_mode.matrixRTCMode.title")}
       </Heading>
diff --git a/src/settings/__snapshots__/DeveloperSettingsTab.test.tsx.snap b/src/settings/__snapshots__/DeveloperSettingsTab.test.tsx.snap
index ddaa9b7f..ca861eb6 100644
--- a/src/settings/__snapshots__/DeveloperSettingsTab.test.tsx.snap
+++ b/src/settings/__snapshots__/DeveloperSettingsTab.test.tsx.snap
@@ -190,14 +190,11 @@ exports[`DeveloperSettingsTab > renders and matches snapshot 1`] = `
       </div>
        
     </div>
-    <div
-      class="_inline-field_19upo_32"
+    <form
+      class="_root_19upo_16"
     >
       <div
-        class="_inline-field-control_19upo_44"
-      />
-      <div
-        class="_inline-field-body_19upo_38"
+        class="_field_19upo_26"
       >
         <label
           class="_label_19upo_59"
@@ -205,42 +202,25 @@ exports[`DeveloperSettingsTab > renders and matches snapshot 1`] = `
         >
           Custom Livekit-url
         </label>
+        <div
+          class="_controls_17lij_8"
+        >
+          <input
+            aria-describedby="radix-«r7»"
+            class="_control_sqdq4_10"
+            id="radix-«r6»"
+            name="input"
+            title=""
+          />
+        </div>
         <span
           class="_message_19upo_85 _help-message_19upo_91"
           id="radix-«r7»"
         >
-          Use Default
+          Currently, no overwrite is set. Url from well-known or config is used.
         </span>
       </div>
-    </div>
-    <div
-      class="fieldRow"
-    >
-      <div
-        class="field inputField"
-      >
-        <input
-          aria-describedby="«r8»"
-          id="customLivekitUrl"
-          type="text"
-          value=""
-        />
-        <label
-          for="customLivekitUrl"
-        >
-          Custom Livekit-url
-        </label>
-      </div>
-      <button
-        class="_button_vczzf_8"
-        data-kind="primary"
-        data-size="lg"
-        role="button"
-        tabindex="0"
-      >
-        Update
-      </button>
-    </div>
+    </form>
     <h3
       class="_typography_6v6n8_153 _font-body-lg-semibold_6v6n8_74"
     >
@@ -256,10 +236,10 @@ exports[`DeveloperSettingsTab > renders and matches snapshot 1`] = `
           class="_container_1e0uz_10"
         >
           <input
-            aria-describedby="radix-«ra» radix-«rc» radix-«re»"
+            aria-describedby="radix-«r9» radix-«rb» radix-«rd»"
             checked=""
             class="_input_1e0uz_18"
-            id="radix-«r9»"
+            id="radix-«r8»"
             name="«r0»"
             title=""
             type="radio"
@@ -275,13 +255,13 @@ exports[`DeveloperSettingsTab > renders and matches snapshot 1`] = `
       >
         <label
           class="_label_19upo_59"
-          for="radix-«r9»"
+          for="radix-«r8»"
         >
           Legacy: state events & oldest membership SFU
         </label>
         <span
           class="_message_19upo_85 _help-message_19upo_91"
-          id="radix-«ra»"
+          id="radix-«r9»"
         >
           Compatible with old versions of EC that do not support multi SFU
         </span>
@@ -297,9 +277,9 @@ exports[`DeveloperSettingsTab > renders and matches snapshot 1`] = `
           class="_container_1e0uz_10"
         >
           <input
-            aria-describedby="radix-«ra» radix-«rc» radix-«re»"
+            aria-describedby="radix-«r9» radix-«rb» radix-«rd»"
             class="_input_1e0uz_18"
-            id="radix-«rb»"
+            id="radix-«ra»"
             name="«r0»"
             title=""
             type="radio"
@@ -315,13 +295,13 @@ exports[`DeveloperSettingsTab > renders and matches snapshot 1`] = `
       >
         <label
           class="_label_19upo_59"
-          for="radix-«rb»"
+          for="radix-«ra»"
         >
           Compatibility: state events & multi SFU
         </label>
         <span
           class="_message_19upo_85 _help-message_19upo_91"
-          id="radix-«rc»"
+          id="radix-«rb»"
         >
           Compatible with homeservers that do not support sticky events (but all other EC clients are v0.17.0 or later)
         </span>
@@ -337,9 +317,9 @@ exports[`DeveloperSettingsTab > renders and matches snapshot 1`] = `
           class="_container_1e0uz_10"
         >
           <input
-            aria-describedby="radix-«ra» radix-«rc» radix-«re»"
+            aria-describedby="radix-«r9» radix-«rb» radix-«rd»"
             class="_input_1e0uz_18"
-            id="radix-«rd»"
+            id="radix-«rc»"
             name="«r0»"
             title=""
             type="radio"
@@ -355,13 +335,13 @@ exports[`DeveloperSettingsTab > renders and matches snapshot 1`] = `
       >
         <label
           class="_label_19upo_59"
-          for="radix-«rd»"
+          for="radix-«rc»"
         >
           Matrix 2.0: sticky events & multi SFU
         </label>
         <span
           class="_message_19upo_85 _help-message_19upo_91"
-          id="radix-«re»"
+          id="radix-«rd»"
         >
           Compatible only with homservers supporting sticky events and all EC clients v0.17.0 or later
         </span>