Matrix/element-call-Github
1
0
Fork 0
mirror of https://github.com/vector-im/element-call.git synced 2026-07-30 19:39:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

remove redundant toBeVisible before click

Browse Source
This commit is contained in:
Valere
2026-04-22 18:49:51 +02:00
parent 5c4d6d0317
commit 78e7adc4c6
1 changed files with 16 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
playwright/widget/test-helpers.ts
View File

@@ -29,8 +29,10 @@ export class TestHelpers {
voice: boolean = false, voice: boolean = false,
): Promise<void> { ): Promise<void> {
const buttonName = voice ? "Voice call" : "Video call"; const buttonName = voice ? "Voice call" : "Video call";
await expect(page.getByRole("button", { name: buttonName })).toBeVisible();
await page.getByRole("button", { name: buttonName }).click(); await page.getByRole("button", { name: buttonName }).click({
timeout: 5000,
});
await expect( await expect(
page.getByRole("menuitem", { name: "Element Call" }), page.getByRole("menuitem", { name: "Element Call" }),
@@ -63,8 +65,9 @@ export class TestHelpers {
await expect(page.getByText(label)).toBeVisible({ await expect(page.getByText(label)).toBeVisible({
timeout: 10000, timeout: 10000,
}); });
await expect(page.getByRole("button", { name: "Join" })).toBeVisible(); await page.getByRole("button", { name: "Join" }).click({
await page.getByRole("button", { name: "Join" }).click(); timeout: 5000,
});
} }
/** /**
@@ -191,7 +194,9 @@ export class TestHelpers {
.getByRole("button", { name: "New conversation" }) .getByRole("button", { name: "New conversation" })
.click(); .click();
await page.getByRole("menuitem", { name: "New Room" }).click(); await page.getByRole("menuitem", { name: "New Room" }).click({
timeout: 5000,
});
await page.getByRole("textbox", { name: "Name" }).fill(name); await page.getByRole("textbox", { name: "Name" }).fill(name);
await page.getByRole("button", { name: "Create room" }).click(); await page.getByRole("button", { name: "Create room" }).click();
await expect(page.getByText("You created this room.")).toBeVisible({ await expect(page.getByText("You created this room.")).toBeVisible({
@@ -226,9 +231,12 @@ export class TestHelpers {
roomName: string, roomName: string,
page: Page, page: Page,
): Promise<void> { ): Promise<void> {
await expect(page.getByRole("option", { name: roomName })).toBeVisible(); await page.getByRole("option", { name: roomName }).click({
await page.getByRole("option", { name: roomName }).click(); timeout: 10000,
await page.getByRole("button", { name: "Accept" }).click(); });
await page.getByRole("button", { name: "Accept" }).click({
timeout: 5000,
});
await expect( await expect(
page.getByRole("main").getByRole("heading", { name: roomName }), page.getByRole("main").getByRole("heading", { name: roomName }),