Very bit test overhaul. All displayname tests are now done in the

Metadata file. and not in the CallViewModel anymore.

src/utils/displayname-integration.test.ts

@@ -6,10 +6,10 @@ Please see LICENSE in the repository root for full details.
 */
 
 import { afterEach, beforeAll, describe, expect, test, vi } from "vitest";
+import { type RoomMember } from "matrix-js-sdk";
 
 import { shouldDisambiguate } from "./displayname";
 import { alice } from "./test-fixtures";
-import { mockMatrixRoom } from "./test";
 
 // Ideally these tests would be in ./displayname.test.ts but I can't figure out how to
 // just spy on the removeHiddenChars() function without impacting the other tests.
@@ -29,7 +29,7 @@ describe("shouldDisambiguate", () => {
   });
 
   test("should only call removeHiddenChars once for a single displayname", () => {
-    const room = mockMatrixRoom({});
+    const room: Map<string, Pick<RoomMember, "userId">> = new Map([]);
     shouldDisambiguate(alice, [], room);
     expect(jsUtils.removeHiddenChars).toHaveBeenCalledTimes(1);
     for (let i = 0; i < 10; i++) {

src/utils/displayname.test.ts

@@ -20,62 +20,70 @@ import {
   daveRTL,
 } from "./test-fixtures";
 import { mockMatrixRoom } from "./test";
+import { roomToMembersMap } from "../state/CallViewModel/remoteMembers/MatrixMemberMetadata";
 
 describe("shouldDisambiguate", () => {
   test("should not disambiguate a solo member", () => {
-    const room = mockMatrixRoom({});
-    expect(shouldDisambiguate(alice, [], room)).toEqual(false);
+    const room = mockMatrixRoom({
+      getMembers: () => [],
+    });
+    expect(shouldDisambiguate(alice, [], roomToMembersMap(room))).toEqual(
+      false,
+    );
   });
   test("should not disambiguate a member with an empty displayname", () => {
     const room = mockMatrixRoom({
-      getMember: (u) =>
-        [alice, aliceDoppelganger].find((m) => m.userId === u) ?? null,
+      getMembers: () => [alice, aliceDoppelganger],
     });
     expect(
       shouldDisambiguate(
         { rawDisplayName: "", userId: alice.userId },
         [aliceRtcMember, aliceDoppelgangerRtcMember],
-        room,
+        roomToMembersMap(room),
       ),
     ).toEqual(false);
   });
   test("should disambiguate a member with RTL characters", () => {
-    const room = mockMatrixRoom({});
-    expect(shouldDisambiguate(daveRTL, [], room)).toEqual(true);
+    const room = mockMatrixRoom({ getMembers: () => [] });
+    expect(shouldDisambiguate(daveRTL, [], roomToMembersMap(room))).toEqual(
+      true,
+    );
   });
   test("should disambiguate a member with a matching displayname", () => {
     const room = mockMatrixRoom({
-      getMember: (u) =>
-        [alice, aliceDoppelganger].find((m) => m.userId === u) ?? null,
+      getMembers: () => [alice, aliceDoppelganger],
     });
     expect(
       shouldDisambiguate(
         alice,
         [aliceRtcMember, aliceDoppelgangerRtcMember],
-        room,
+        roomToMembersMap(room),
       ),
     ).toEqual(true);
     expect(
       shouldDisambiguate(
         aliceDoppelganger,
         [aliceRtcMember, aliceDoppelgangerRtcMember],
-        room,
+        roomToMembersMap(room),
       ),
     ).toEqual(true);
   });
   test("should disambiguate a member with a matching displayname with hidden spaces", () => {
     const room = mockMatrixRoom({
-      getMember: (u) =>
-        [bob, bobZeroWidthSpace].find((m) => m.userId === u) ?? null,
+      getMembers: () => [bob, bobZeroWidthSpace],
     });
     expect(
-      shouldDisambiguate(bob, [bobRtcMember, bobZeroWidthSpaceRtcMember], room),
+      shouldDisambiguate(
+        bob,
+        [bobRtcMember, bobZeroWidthSpaceRtcMember],
+        roomToMembersMap(room),
+      ),
     ).toEqual(true);
     expect(
       shouldDisambiguate(
         bobZeroWidthSpace,
         [bobRtcMember, bobZeroWidthSpaceRtcMember],
-        room,
+        roomToMembersMap(room),
       ),
     ).toEqual(true);
   });
@@ -83,11 +91,14 @@ describe("shouldDisambiguate", () => {
     "should disambiguate a member with a displayname containing a mxid-like string '%s'",
     (rawDisplayName) => {
       const room = mockMatrixRoom({
-        getMember: (u) =>
-          [alice, aliceDoppelganger].find((m) => m.userId === u) ?? null,
+        getMembers: () => [alice, aliceDoppelganger],
       });
       expect(
-        shouldDisambiguate({ rawDisplayName, userId: alice.userId }, [], room),
+        shouldDisambiguate(
+          { rawDisplayName, userId: alice.userId },
+          [],
+          roomToMembersMap(room),
+        ),
       ).toEqual(true);
     },
   );

src/utils/test-fixtures.ts

@@ -37,7 +37,6 @@ export const aliceDoppelganger = mockMatrixRoomMember(
     rawDisplayName: "Alice",
   },
 );
-export const aliceDoppelgangerId = `${aliceDoppelganger.userId}:${aliceDoppelgangerRtcMember.deviceId}`;
 
 export const bobRtcMember = mockRtcMembership("@bob:example.org", "BBBB");
 export const bob = mockMatrixRoomMember(bobRtcMember, {
@@ -55,10 +54,8 @@ export const bobZeroWidthSpace = mockMatrixRoomMember(
     rawDisplayName: "Bo\u200bb",
   },
 );
-export const bobZeroWidthSpaceId = `${bobZeroWidthSpace.userId}:${bobZeroWidthSpaceRtcMember.deviceId}`;
 
 export const daveRTLRtcMember = mockRtcMembership("@dave2:example.org", "DDDD");
 export const daveRTL = mockMatrixRoomMember(daveRTLRtcMember, {
   rawDisplayName: "\u202eevaD",
 });
-export const daveRTLId = `${daveRTL.userId}:${daveRTLRtcMember.deviceId}`;